Bug 31891 - Regression: show "MARC staging results" with clear link to manage staged batch
Summary: Regression: show "MARC staging results" with clear link to manage staged batch
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
: 31892 (view as bug list)
Depends on: 27421
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-20 15:01 UTC by Andrew Fuerste-Henry
Modified: 2023-06-08 22:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31891: (bug 27421 follow-up) Remove one additional click (4.43 KB, patch)
2022-11-16 06:46 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31891: (bug 27421 follow-up) Remove one additional click (4.81 KB, patch)
2022-11-16 07:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31891: (bug 27421 follow-up) Remove one additional click (4.86 KB, patch)
2022-11-16 13:54 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31891: (bug 27421 follow-up) Remove one additional click (4.95 KB, patch)
2022-11-18 10:58 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2022-10-20 15:01:35 UTC
Moving marc batch import actions to background jobs has introduced some confusing clicks to the process. Before this change, after staging a batch one was taken to a "MARC staging results" page with details of how the staging went and, most importantly, a link straight to the batch you'd just staged (at manage-marc-import.pl?import_batch_id=).

Now, however, one must click the status bar to get to details of the job and then click "View batch" from there. Not only is that an extra click and page load, but neither of those links are particularly large or obvious.

We need a clearer and easier patch from staging a batch to managing the batch.
Comment 1 Jonathan Druart 2022-11-16 06:46:42 UTC
Created attachment 143933 [details] [review]
Bug 31891: (bug 27421 follow-up) Remove one additional click

From comment 0
"""
Moving marc batch import actions to background jobs has introduced some confusing
clicks to the process. Before this change, after staging a batch one was taken
to a "MARC staging results" page with details of how the staging went and, most
importantly, a link straight to the batch you'd just staged
(at manage-marc-import.pl?import_batch_id).

Now, however, one must click the status bar to get to details of the job
and then click "View batch" from there. Not only is that an extra click
and page load, but neither of those links are particularly large or
obvious.
"""

Test plan:
- Stage a record for import, notice that the "View batch" link appears
when the job is finished
- Add order to basket from a new file, select a file and import
Notice that the "Add staged files to basket" link is displayed when the
job is finished

Note for QA: We should have a js_callback in the background_job include
file instead.
Comment 2 Jonathan Druart 2022-11-16 07:08:36 UTC
https://snipboard.io/fDocvA.jpg
Comment 3 Jonathan Druart 2022-11-16 07:10:27 UTC
Created attachment 143935 [details] [review]
Bug 31891: (bug 27421 follow-up) Remove one additional click

From comment 0
"""
Moving marc batch import actions to background jobs has introduced some confusing
clicks to the process. Before this change, after staging a batch one was taken
to a "MARC staging results" page with details of how the staging went and, most
importantly, a link straight to the batch you'd just staged
(at manage-marc-import.pl?import_batch_id).

Now, however, one must click the status bar to get to details of the job
and then click "View batch" from there. Not only is that an extra click
and page load, but neither of those links are particularly large or
obvious.
"""

Test plan:
- Stage a record for import, notice that the "View batch" link appears
when the job is finished
- Add order to basket from a new file, select a file and import
Notice that the "Add staged files to basket" link is displayed when the
job is finished

Note for QA: We should have a js_callback in the background_job include
file instead.
Comment 4 Katrin Fischer 2022-11-16 13:54:50 UTC
Created attachment 143955 [details] [review]
Bug 31891: (bug 27421 follow-up) Remove one additional click

From comment 0
"""
Moving marc batch import actions to background jobs has introduced some confusing
clicks to the process. Before this change, after staging a batch one was taken
to a "MARC staging results" page with details of how the staging went and, most
importantly, a link straight to the batch you'd just staged
(at manage-marc-import.pl?import_batch_id).

Now, however, one must click the status bar to get to details of the job
and then click "View batch" from there. Not only is that an extra click
and page load, but neither of those links are particularly large or
obvious.
"""

Test plan:
- Stage a record for import, notice that the "View batch" link appears
when the job is finished
- Add order to basket from a new file, select a file and import
Notice that the "Add staged files to basket" link is displayed when the
job is finished

Note for QA: We should have a js_callback in the background_job include
file instead.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-11-16 20:44:32 UTC
*** Bug 31892 has been marked as a duplicate of this bug. ***
Comment 6 Marcel de Rooy 2022-11-18 10:33:08 UTC
QAing
Comment 7 Marcel de Rooy 2022-11-18 10:58:47 UTC
Created attachment 144056 [details] [review]
Bug 31891: (bug 27421 follow-up) Remove one additional click

From comment 0
"""
Moving marc batch import actions to background jobs has introduced some confusing
clicks to the process. Before this change, after staging a batch one was taken
to a "MARC staging results" page with details of how the staging went and, most
importantly, a link straight to the batch you'd just staged
(at manage-marc-import.pl?import_batch_id).

Now, however, one must click the status bar to get to details of the job
and then click "View batch" from there. Not only is that an extra click
and page load, but neither of those links are particularly large or
obvious.
"""

Test plan:
- Stage a record for import, notice that the "View batch" link appears
when the job is finished
- Add order to basket from a new file, select a file and import
Notice that the "Add staged files to basket" link is displayed when the
job is finished

Note for QA: We should have a js_callback in the background_job include
file instead.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Marcel de Rooy 2022-11-18 10:59:41 UTC
Does not include new strings.

Strings are already present:
koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/stage_marc_for_import.inc:            <a href="/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=[% report.import_batch_id | uri %]">View batch</a>
koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/stage_marc_for_import.inc:            <a id="addtobasket" class="btn btn-default" href="/cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=[% report.import_batch_id | html %]&basketno=[% report.basket_id | html %]&booksellerid=[% report.vendor_id | html %]">Add staged files to basket</a>
Comment 9 Marcel de Rooy 2022-11-18 11:00:45 UTC
You could argue that this patch is somewhere between bug and enhancement..
Comment 10 Tomás Cohen Arazi 2022-11-22 12:31:09 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!