Bug 31768 - Tags is a 'Tool' but doesn't include the tools nav sidebar
Summary: Tags is a 'Tool' but doesn't include the tools nav sidebar
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Katrin Fischer
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-10-13 12:22 UTC by Martin Renvoize (ashimema)
Modified: 2023-12-28 20:44 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03,22.05.10,21.11.18
Circulation function:


Attachments
Bug 31768: Add tools toolbar to tags page (1.23 KB, patch)
2023-02-06 22:08 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31860: Standardize capitalization used for item subfield descriptions (6.65 KB, patch)
2023-02-06 22:29 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31768: Add tools toolbar to tags page (1.27 KB, patch)
2023-02-07 09:35 UTC, David Nind
Details | Diff | Splinter Review
Bug 31768: Add tools toolbar to tags page (1.34 KB, patch)
2023-02-07 10:01 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2022-10-13 12:22:46 UTC
We should improve consistency by adding the tools sidebar navigation to the Tags page.
Comment 1 Owen Leonard 2022-10-24 13:17:40 UTC
I'm removing the dependency on 30952 since the issue predates the redesign.
Comment 2 Katrin Fischer 2023-02-06 22:08:30 UTC
Created attachment 146301 [details] [review]
Bug 31768: Add tools toolbar to tags page

The tags tool was missing the toolbar on the left side.
With the filters, this patch adds the toolbar below, like
we do on other pages like HTML customizations.

To test:
* Go to Tools > Tags
* Verify no toolbar
* Apply patch
* Verify toolbar is now present
* Compare to other tool pages
* Sign off :)
Comment 3 Katrin Fischer 2023-02-06 22:29:40 UTC Comment hidden (obsolete)
Comment 4 David Nind 2023-02-07 09:35:34 UTC
Created attachment 146309 [details] [review]
Bug 31768: Add tools toolbar to tags page

The tags tool was missing the toolbar on the left side.
With the filters, this patch adds the toolbar below, like
we do on other pages like HTML customizations.

To test:
* Go to Tools > Tags
* Verify no toolbar
* Apply patch
* Verify toolbar is now present
* Compare to other tool pages
* Sign off :)

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Martin Renvoize (ashimema) 2023-02-07 10:01:55 UTC
Created attachment 146313 [details] [review]
Bug 31768: Add tools toolbar to tags page

The tags tool was missing the toolbar on the left side.
With the filters, this patch adds the toolbar below, like
we do on other pages like HTML customizations.

To test:
* Go to Tools > Tags
* Verify no toolbar
* Apply patch
* Verify toolbar is now present
* Compare to other tool pages
* Sign off :)

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize (ashimema) 2023-02-07 10:02:17 UTC
Yeay, thanks Katrin

Passing QA
Comment 7 Tomás Cohen Arazi (tcohen) 2023-02-07 13:50:45 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-02-08 16:37:31 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 9 Lucas Gass (lukeg) 2023-02-15 21:27:14 UTC
Backported to 22.05.x for upcoming 22.05.10
Comment 10 Arthur Suzuki 2023-02-17 13:03:08 UTC
applied to 21.11.x for 21.11.18
Comment 11 Wainui Witika-Park 2023-03-15 02:17:44 UTC
Not backported to 21.05.x