The label for Serial enumeration / chronology (952$h) is displayed as "Serial Enumeration / chronology" - note the capital "E". For consistency, this should be displayed in sentence case wherever it is required in the staff interface and OPAC, including: - details view in the staff interface: MARC view, edit items table, add and edit item form - MARC view in the OPAC: holdings table Note: Libraries can update this themselves by updating $952$h for all the frameworks it is used in.
Created attachment 146304 [details] [review] Bug 31860: Standardize capitalization used for item subfield descriptions This standardizes "Total Holds" to "Total holds" etc. Also changed is UNIMARC * "Collection code" to "Collection" like MARC21 * "Current Location" to "Current library" like MARC21 (holdingbranch) * "Permanent Location" to "Home library" like MARC21 (homebranch) To test: * You'll need to apply the patch and then run the web installer to create your frameworks * Once you got a fresh installation, got to Administration > Bibliographic frameworks > Choose any * Go to 995 (for UNIMARC) or 952 (for MARC21) * Check the descriptions of the subfields for capitalization and spelling errors https://bugs.koha-community.org/show_bug.cgi?id=31768
Created attachment 146308 [details] [review] Bug 31860: Standardize capitalization used for item subfield descriptions This standardizes "Total Holds" to "Total holds" etc. Also changed is UNIMARC * "Collection code" to "Collection" like MARC21 * "Current Location" to "Current library" like MARC21 (holdingbranch) * "Permanent Location" to "Home library" like MARC21 (homebranch) To test: * You'll need to apply the patch and then run the web installer to create your frameworks * Once you got a fresh installation, got to Administration > Bibliographic frameworks > Choose any * Go to 995 (for UNIMARC) or 952 (for MARC21) * Check the descriptions of the subfields for capitalization and spelling errors Signed-off-by: David Nind <david@davidnind.com>
Thanks Katrin for spotting the other occurrences that needed updating! The only one I wasn't sure about was URI, and whether it should be capitalised when spelt in full. The dictionaries and other resources I looked up were inconclusive... Also, I amended the commit message to remove the Bugzilla link after the test plan to bug 31768. Testing notes (using KTD): 1. After applying the patch, I did a reset_all - this loaded the updated text for the descriptions. 2. To test the UNIMARC changes (955) I amended the KTD .env file to change KOHA_MARC_FLAVOUR=unimarc and then started up KTD to get a UNIMARC instance.
> The only one I wasn't sure about was URI, and whether it should be > capitalised when spelt in full. The dictionaries and other resources I > looked up were inconclusive... I was not completely sure either. Can't we just update the label to URI or URL? :) > > Also, I amended the commit message to remove the Bugzilla link after the > test plan to bug 31768. Thanks, that was due to me having a bug typo first. > Testing notes (using KTD): > > 1. After applying the patch, I did a reset_all - this loaded the updated > text for the descriptions. > > 2. To test the UNIMARC changes (955) I amended the KTD .env file to change > KOHA_MARC_FLAVOUR=unimarc and then started up KTD to get a UNIMARC instance.
Created attachment 146317 [details] [review] Bug 31860: Standardize capitalization used for item subfield descriptions This standardizes "Total Holds" to "Total holds" etc. Also changed is UNIMARC * "Collection code" to "Collection" like MARC21 * "Current Location" to "Current library" like MARC21 (holdingbranch) * "Permanent Location" to "Home library" like MARC21 (homebranch) To test: * You'll need to apply the patch and then run the web installer to create your frameworks * Once you got a fresh installation, got to Administration > Bibliographic frameworks > Choose any * Go to 995 (for UNIMARC) or 952 (for MARC21) * Check the descriptions of the subfields for capitalization and spelling errors Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Looks good to me.. Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.