Bug 31837 - Add page-section to basket summary page
Summary: Add page-section to basket summary page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31757 31932
  Show dependency treegraph
 
Reported: 2022-10-16 14:35 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31837: Add page-section class to tables on basket.tt (33.23 KB, patch)
2022-10-19 23:10 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31837: Add page-section class to tables on basket.tt (33.28 KB, patch)
2022-10-20 08:45 UTC, David Nind
Details | Diff | Splinter Review
Bug 31837: Add page-section class to tables on basket.tt (33.34 KB, patch)
2022-10-23 11:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31837: (follow-up) Move page-section to include h2 headings (2.20 KB, patch)
2022-10-23 11:53 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31837: Add page-section class to tables on basket.tt (33.40 KB, patch)
2022-10-24 08:28 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31837: (follow-up) Move page-section to include h2 headings (2.26 KB, patch)
2022-10-24 08:28 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-16 14:35:28 UTC
When receiving a shipment, the list of pending and then received orders (table below the first one) requires the treatment with page-section classes.
Comment 1 Lucas Gass 2022-10-19 23:10:35 UTC
Created attachment 142217 [details] [review]
Bug 31837: Add page-section class to tables on basket.tt

This patch adds the page-section class to the orders and cancelled orders tables.

To test:
1. Have a vendor, basket, and create an order.
2. Go look at the table on basket.tt and make sure the orders table looks good.
3. Cancel some orders and look at the cancelled order table, make sure it also looks good.

Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div.
Comment 2 David Nind 2022-10-20 08:45:35 UTC
Created attachment 142232 [details] [review]
Bug 31837: Add page-section class to tables on basket.tt

This patch adds the page-section class to the orders and cancelled orders tables.

To test:
1. Have a vendor, basket, and create an order.
2. Go look at the table on basket.tt and make sure the orders table looks good.
3. Cancel some orders and look at the cancelled order table, make sure it also looks good.

Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-10-21 11:50:44 UTC
This one is confusing to me... it fixes the basket page, but it looks like I intended to file for parcels?
Comment 4 Katrin Fischer 2022-10-21 11:55:15 UTC
Ok, I see waht happened here... this is actually the fix for bug 31820 :P

I'll switch things around a bit, so we also have a bug for the receive page.
Comment 5 Katrin Fischer 2022-10-21 12:01:19 UTC
Hi Lucas, compared this to some other pages and it looks like the h2/h3 are usually inside the page-section. Could we move them here as well?
The h1 appears to always be outside.

For comparison see patron form, patron details and patron import.
Comment 6 Lucas Gass 2022-10-21 14:14:45 UTC
Sorry, for the confusion here Cait. I'll move these patches over to Bug 31820 and address the heading problem.
Comment 7 Katrin Fischer 2022-10-21 14:19:46 UTC
(In reply to Lucas Gass from comment #6)
> Sorry, for the confusion here Cait. I'll move these patches over to Bug
> 31820 and address the heading problem.

Please don't move, I fixed the descriptions and the patch is ok here now!
Comment 8 Katrin Fischer 2022-10-23 11:53:24 UTC
Created attachment 142459 [details] [review]
Bug 31837: Add page-section class to tables on basket.tt

This patch adds the page-section class to the orders and cancelled orders tables.

To test:
1. Have a vendor, basket, and create an order.
2. Go look at the table on basket.tt and make sure the orders table looks good.
3. Cancel some orders and look at the cancelled order table, make sure it also looks good.

Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2022-10-23 11:53:32 UTC
Created attachment 142460 [details] [review]
Bug 31837: (follow-up) Move page-section to include h2 headings

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Martin Renvoize 2022-10-24 08:07:47 UTC
This template needs an indentation cleanup.. rather confusing as it stands.

More directly related.. I think perhaps each of the top columns should also be carded.. but that's not immediately trivial, as I just found.. so I'll open a new bug for that one..

Finally.. there's also a bug around the 'Managed by'.. the 'add user' is on the wrong side of the label.
Comment 11 Martin Renvoize 2022-10-24 08:08:48 UTC
Working on a follow-up
Comment 12 Martin Renvoize 2022-10-24 08:28:01 UTC
Created attachment 142473 [details] [review]
Bug 31837: Add page-section class to tables on basket.tt

This patch adds the page-section class to the orders and cancelled orders tables.

To test:
1. Have a vendor, basket, and create an order.
2. Go look at the table on basket.tt and make sure the orders table looks good.
3. Cancel some orders and look at the cancelled order table, make sure it also looks good.

Note: I made some indentation changes. I also did NOT add a new wrapper to the cancelled orders table, it already had one so I just added the page-section div to the existing div.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 13 Martin Renvoize 2022-10-24 08:28:07 UTC
Created attachment 142474 [details] [review]
Bug 31837: (follow-up) Move page-section to include h2 headings

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 14 Martin Renvoize 2022-10-24 08:28:57 UTC
OK.. I gave up.. this template is a real mess.

So.. passing QA as is and I'll raise a new bug for going through the template
Comment 15 Tomás Cohen Arazi 2022-10-24 13:58:37 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!