Bug 31932 - The basket summary page template needs a cleanup
Summary: The basket summary page template needs a cleanup
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 31837
Blocks: 32733
  Show dependency treegraph
 
Reported: 2022-10-24 08:32 UTC by Martin Renvoize
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 31932: The basket summary page template needs a cleanup (132.05 KB, patch)
2023-01-25 16:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31932: (follow-up) Markup comments (13.16 KB, patch)
2023-01-25 16:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31932: The basket summary page template needs a cleanup (132.12 KB, patch)
2023-01-26 10:28 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31932: (follow-up) Markup comments (13.23 KB, patch)
2023-01-26 10:28 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31932: The basket summary page template needs a cleanup (132.17 KB, patch)
2023-01-27 13:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31932: (follow-up) Markup comments (13.28 KB, patch)
2023-01-27 13:06 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-10-24 08:32:24 UTC
The indentation on basket.tt is really confusing and could do with a cleanup.. lots of nested conditions without consistent nesting end points.

I'd also love to see the top two col sections marked up with page-section to 'card' them, and we could do with fixing where the 'add user' link appear on the 'Managed by' row.

Lots of little things.
Comment 1 Owen Leonard 2023-01-25 16:40:07 UTC
Created attachment 145664 [details] [review]
Bug 31932: The basket summary page template needs a cleanup

This patch reindents the Acquisitions basket template so that it has
consistent indentation. These changes should have no visible effect on
the page.

To test, apply the patch and go to Acquisitions.

Locate a vendor and add a basket and some orders if necessary.

Test as much of the page's functionality as possible, e.g. toolbar
controls, in-table controls, managed-by and managing library controls,
etc. Try adding an internal note, adding a vendor note, and deleting the
basket.

Everything should look correct and work correctly.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.
Comment 2 Owen Leonard 2023-01-25 16:40:14 UTC
Created attachment 145665 [details] [review]
Bug 31932: (follow-up) Markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 Martin Renvoize 2023-01-26 10:28:30 UTC
Created attachment 145686 [details] [review]
Bug 31932: The basket summary page template needs a cleanup

This patch reindents the Acquisitions basket template so that it has
consistent indentation. These changes should have no visible effect on
the page.

To test, apply the patch and go to Acquisitions.

Locate a vendor and add a basket and some orders if necessary.

Test as much of the page's functionality as possible, e.g. toolbar
controls, in-table controls, managed-by and managing library controls,
etc. Try adding an internal note, adding a vendor note, and deleting the
basket.

Everything should look correct and work correctly.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-01-26 10:28:34 UTC
Created attachment 145687 [details] [review]
Bug 31932: (follow-up) Markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2023-01-26 10:31:03 UTC
Much clearer, thanks for this Owen.. I had meant to come back to it myself but there's never enough time is there!

It's much more understandable now.  Signing off
Comment 6 Katrin Fischer 2023-01-27 13:06:17 UTC
Created attachment 145736 [details] [review]
Bug 31932: The basket summary page template needs a cleanup

This patch reindents the Acquisitions basket template so that it has
consistent indentation. These changes should have no visible effect on
the page.

To test, apply the patch and go to Acquisitions.

Locate a vendor and add a basket and some orders if necessary.

Test as much of the page's functionality as possible, e.g. toolbar
controls, in-table controls, managed-by and managing library controls,
etc. Try adding an internal note, adding a vendor note, and deleting the
basket.

Everything should look correct and work correctly.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 7 Katrin Fischer 2023-01-27 13:06:21 UTC
Created attachment 145737 [details] [review]
Bug 31932: (follow-up) Markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 8 Tomás Cohen Arazi 2023-01-27 19:19:25 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Matt Blenkinsop 2023-01-31 14:33:37 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 10 Lucas Gass 2023-02-01 18:58:53 UTC
Missing dependencies for 22.05.x, no backport