Bug 31861 - Table controls on checkouts table are buttons
Summary: Table controls on checkouts table are buttons
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 31754
Blocks: 31962
  Show dependency treegraph
 
Reported: 2022-10-18 19:36 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Screenshot of checkouts table (38.35 KB, image/png)
2022-10-18 19:36 UTC, Katrin Fischer
Details
Bug 31861: Table controls on checkouts table are buttons (5.87 KB, patch)
2022-10-19 16:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31861: Table controls on checkouts table are buttons (5.92 KB, patch)
2022-10-19 18:43 UTC, David Nind
Details | Diff | Splinter Review
Bug 31861: Table controls on checkouts table are buttons (5.98 KB, patch)
2022-10-21 12:50 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31861: (follow-up) Fix disabled clear search button (855 bytes, patch)
2022-10-24 12:13 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31861: (follow-up) Fix disabled clear search button (921 bytes, patch)
2022-10-24 12:30 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-18 19:36:55 UTC
Created attachment 142088 [details]
Screenshot of checkouts table

The table controls to export, print and change columns on the checkouts table in patron account look much different to the table controls on other tables.
Comment 1 Owen Leonard 2022-10-19 16:09:05 UTC
Created attachment 142192 [details] [review]
Bug 31861: Table controls on checkouts table are buttons

This patch updates the style of DataTables buttons (columns, export, and
configure), in cases where the buttons are the only control being
displayed (no page controls, filter, etc).

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation and check an item out to a patron.
- If necessary, click the "Show checkouts" button to reveal the table of
  checkouts.
- The "Columns," "Export," and "Configure" controls should look the same
  as they do in other situations, with no button-style border.
- Go to Circulation -> Check in and check in the item. The table of
  checked-in items should show the same style controls.
Comment 2 David Nind 2022-10-19 18:43:09 UTC
Created attachment 142198 [details] [review]
Bug 31861: Table controls on checkouts table are buttons

This patch updates the style of DataTables buttons (columns, export, and
configure), in cases where the buttons are the only control being
displayed (no page controls, filter, etc).

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation and check an item out to a patron.
- If necessary, click the "Show checkouts" button to reveal the table of
  checkouts.
- The "Columns," "Export," and "Configure" controls should look the same
  as they do in other situations, with no button-style border.
- Go to Circulation -> Check in and check in the item. The table of
  checked-in items should show the same style controls.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2022-10-21 12:50:55 UTC
Created attachment 142359 [details] [review]
Bug 31861: Table controls on checkouts table are buttons

This patch updates the style of DataTables buttons (columns, export, and
configure), in cases where the buttons are the only control being
displayed (no page controls, filter, etc).

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Go to Circulation and check an item out to a patron.
- If necessary, click the "Show checkouts" button to reveal the table of
  checkouts.
- The "Columns," "Export," and "Configure" controls should look the same
  as they do in other situations, with no button-style border.
- Go to Circulation -> Check in and check in the item. The table of
  checked-in items should show the same style controls.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2022-10-21 12:51:27 UTC
Resolves issue found, improves consistency and no regressions found.

Passing QA
Comment 5 Martin Renvoize 2022-10-24 11:05:30 UTC
OK.. there is a regression here..

The 'Clear filter' link becomes a button again after this patch.. and causes page jiggle.. this seems to undo something fixed in bug 31754
Comment 6 Owen Leonard 2022-10-24 12:13:32 UTC
Created attachment 142495 [details] [review]
Bug 31861: (follow-up) Fix disabled clear search button

The disabled clear search button should not have a border and background
set.
Comment 7 Martin Renvoize 2022-10-24 12:30:47 UTC
Created attachment 142497 [details] [review]
Bug 31861: (follow-up) Fix disabled clear search button

The disabled clear search button should not have a border and background
set.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize 2022-10-24 12:31:15 UTC
Thanks for quick follow-up.. PQA now :)
Comment 9 Tomás Cohen Arazi 2022-10-24 14:45:59 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!