Bug 31962 - Add tooltip to 'configure' on datatable controls
Summary: Add tooltip to 'configure' on datatable controls
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on: 31861
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-24 19:56 UTC by Katrin Fischer
Modified: 2024-07-04 20:38 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03
Circulation function:


Attachments
Bug 31962: Add tooltip to 'configure' on datatable controls (3.58 KB, patch)
2023-01-06 21:07 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31962: Add tooltip to 'configure' on datatable controls (3.62 KB, patch)
2023-01-07 11:11 UTC, David Nind
Details | Diff | Splinter Review
Bug 31962: Add tooltip to 'configure' on datatable controls (3.69 KB, patch)
2023-01-31 12:47 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-24 19:56:31 UTC
When you hover over Export and print, there is a tooltip in the form of a speech bubble showing on top. But if you hover over configure, a normal tooltip shows below.

To test:
* Go to a patron account
* Check out any book
* Hover over table controls
Comment 1 Katrin Fischer 2023-01-06 21:07:25 UTC
Created attachment 145106 [details] [review]
Bug 31962: Add tooltip to 'configure' on datatable controls

This makes sure that the last button on the datatable controls
also has a tooltip, like the other buttons.

To test:
* Without the patch:
* Check out an item and look at the table of checkouts
* Look at the detail page of a record with at least one item
* Confirm that the 'configure' button doesn't have a tooltip appear
  as a bubble like the other buttons
* Apply patch
* Restart_all and reload pages
* Make sure the styling of the 'configure' tooltip now matches that
  of the other buttons
Comment 2 David Nind 2023-01-07 11:11:00 UTC
Created attachment 145133 [details] [review]
Bug 31962: Add tooltip to 'configure' on datatable controls

This makes sure that the last button on the datatable controls
also has a tooltip, like the other buttons.

To test:
* Without the patch:
* Check out an item and look at the table of checkouts
* Look at the detail page of a record with at least one item
* Confirm that the 'configure' button doesn't have a tooltip appear
  as a bubble like the other buttons
* Apply patch
* Restart_all and reload pages
* Make sure the styling of the 'configure' tooltip now matches that
  of the other buttons

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2023-01-31 12:47:32 UTC
Created attachment 145851 [details] [review]
Bug 31962: Add tooltip to 'configure' on datatable controls

This makes sure that the last button on the datatable controls
also has a tooltip, like the other buttons.

To test:
* Without the patch:
* Check out an item and look at the table of checkouts
* Look at the detail page of a record with at least one item
* Confirm that the 'configure' button doesn't have a tooltip appear
  as a bubble like the other buttons
* Apply patch
* Restart_all and reload pages
* Make sure the styling of the 'configure' tooltip now matches that
  of the other buttons

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2023-01-31 12:47:58 UTC
Nice consistency improvement, no regressions found.

Passing QA, Thanks Katrin.
Comment 5 Tomás Cohen Arazi (tcohen) 2023-01-31 13:48:11 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-01-31 18:10:50 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.