Bug 31911 - Headings are inconsistent in rotating collections
Summary: Headings are inconsistent in rotating collections
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 31770
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-21 14:04 UTC by Martin Renvoize
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31911: Improve rotating collections item management (4.31 KB, patch)
2022-10-21 14:18 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31911: Improve rotating collections item management (4.31 KB, patch)
2022-10-24 13:38 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31911: (follow-up) Rename second level heading (1.24 KB, patch)
2022-10-24 13:38 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31911: Improve rotating collections item management (4.36 KB, patch)
2022-10-24 19:40 UTC, David Nind
Details | Diff | Splinter Review
Bug 31911: (follow-up) Rename second level heading (1.29 KB, patch)
2022-10-24 19:40 UTC, David Nind
Details | Diff | Splinter Review
Bug 31911: Improve rotating collections item management (4.36 KB, patch)
2022-10-24 19:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31911: (follow-up) Rename second level heading (1.29 KB, patch)
2022-10-24 19:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Screenshot - list of rotating collections (30.38 KB, image/png)
2022-10-24 19:43 UTC, David Nind
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-10-21 14:04:39 UTC
Headings are placed above the main action toolbar on the 'Add/remove items from collection' page of 'Rotating collections'.
Comment 1 Martin Renvoize 2022-10-21 14:18:27 UTC
Created attachment 142398 [details] [review]
Bug 31911: Improve rotating collections item management

This patch renames 'Add/remove items from collection' to just 'Manage
items' in the button in the rotating collections list table, the page
heading and the breadcrumbs.

We also move the heading below the toolbar to be consistent with
elsewhere, remove a superflous second level heading and wrap the content
table in a page-section too.
Comment 2 Katrin Fischer 2022-10-23 13:38:05 UTC
I think this is a good improvement, but I am in doubt about this heading:
Total items: 2

It doesn't feel like a heading to me, but more like it should appear in the line below one.

Maybe the heading could be: Items in collection ?
Comment 3 Martin Renvoize 2022-10-24 13:38:54 UTC
Created attachment 142504 [details] [review]
Bug 31911: Improve rotating collections item management

This patch renames 'Add/remove items from collection' to just 'Manage
items' in the button in the rotating collections list table, the page
heading and the breadcrumbs.

We also move the heading below the toolbar to be consistent with
elsewhere, remove a superflous second level heading and wrap the content
table in a page-section too.
Comment 4 Martin Renvoize 2022-10-24 13:38:58 UTC
Created attachment 142505 [details] [review]
Bug 31911: (follow-up) Rename second level heading

This patch, as suggested, renames the second level heading to 'Items in
collection' and move the 'Total items: {count}' into a paragraph.
Comment 5 David Nind 2022-10-24 19:40:27 UTC
Created attachment 142558 [details] [review]
Bug 31911: Improve rotating collections item management

This patch renames 'Add/remove items from collection' to just 'Manage
items' in the button in the rotating collections list table, the page
heading and the breadcrumbs.

We also move the heading below the toolbar to be consistent with
elsewhere, remove a superflous second level heading and wrap the content
table in a page-section too.

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2022-10-24 19:40:33 UTC
Created attachment 142559 [details] [review]
Bug 31911: (follow-up) Rename second level heading

This patch, as suggested, renames the second level heading to 'Items in
collection' and move the 'Total items: {count}' into a paragraph.

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Katrin Fischer 2022-10-24 19:42:00 UTC
Created attachment 142560 [details] [review]
Bug 31911: Improve rotating collections item management

This patch renames 'Add/remove items from collection' to just 'Manage
items' in the button in the rotating collections list table, the page
heading and the breadcrumbs.

We also move the heading below the toolbar to be consistent with
elsewhere, remove a superflous second level heading and wrap the content
table in a page-section too.

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 Katrin Fischer 2022-10-24 19:42:05 UTC
Created attachment 142561 [details] [review]
Bug 31911: (follow-up) Rename second level heading

This patch, as suggested, renames the second level heading to 'Items in
collection' and move the 'Total items: {count}' into a paragraph.

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 David Nind 2022-10-24 19:43:00 UTC
Created attachment 142562 [details]
Screenshot - list of rotating collections

Something minor (and maybe for another bug) - do we need to show 'Showing 1 to 2 of 2 entries' on a separate line? See the screenshot.

I think on other screens (such as list of items for a record) we show on the same row as the DataTables header.
Comment 10 Katrin Fischer 2022-10-24 19:46:10 UTC
(In reply to David Nind from comment #9)
> Created attachment 142562 [details]
> Screenshot - list of rotating collections
> 
> Something minor (and maybe for another bug) - do we need to show 'Showing 1
> to 2 of 2 entries' on a separate line? See the screenshot.
> 
> I think on other screens (such as list of items for a record) we show on the
> same row as the DataTables header.

I think this has to do with today's changes to the datatable controls, unrelated to this bug. I see the same on the libraries page. 

I kinda like it, because the inofrmation was often missed before, but not sure if intentional or not.
Comment 11 Katrin Fischer 2022-10-24 19:48:07 UTC
It was bug 31861 and bug 31754.
Comment 12 Tomás Cohen Arazi 2022-10-24 20:23:29 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 13 David Nind 2022-10-24 22:30:33 UTC
(In reply to Katrin Fischer from comment #10)
> (In reply to David Nind from comment #9)
> > Created attachment 142562 [details]
> > Screenshot - list of rotating collections
> > 
> > Something minor (and maybe for another bug) - do we need to show 'Showing 1
> > to 2 of 2 entries' on a separate line? See the screenshot.
> > 
> > I think on other screens (such as list of items for a record) we show on the
> > same row as the DataTables header.
> 
> I think this has to do with today's changes to the datatable controls,
> unrelated to this bug. I see the same on the libraries page. 
> 
> I kinda like it, because the inofrmation was often missed before, but not
> sure if intentional or not.

Thanks Katrin!