To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span>
Created attachment 149825 [details] [review] Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct.
Created attachment 149836 [details] [review] Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 149843 [details] [review] Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Created attachment 149994 [details] [review] Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 149995 [details] [review] Bug 33551: (follow-up) Remove spans by using TT filter This allows up to keep the restriction name in the title by removing the span tags with a TT filter. Copied from bug 32061. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
The first patch removed not only the spans, but also the restriction type (Manual, etc.) from the title. My follow-up adds them back, but still removes the spans. Maybe we could get another sign-off/QA check?
(In reply to Katrin Fischer from comment #6) > The first patch removed not only the spans, but also the restriction type > (Manual, etc.) from the title. My follow-up adds them back, but still > removes the spans. Maybe we could get another sign-off/QA check? Probably a good idea.
(In reply to Lucas Gass from comment #7) > (In reply to Katrin Fischer from comment #6) > > The first patch removed not only the spans, but also the restriction type > > (Manual, etc.) from the title. My follow-up adds them back, but still > > removes the spans. Maybe we could get another sign-off/QA check? > > Probably a good idea. Lucas, do you want to test? We can sign off each others, if you agree to the change of course.
When I try deleting, I have extra quotes. Confirm deletion of restriction 'Manual''') > ...
Created attachment 150215 [details] [review] Bug 33551: (follow-up) fix display when deleting
(In reply to Caroline Cyr La Rose from comment #9) > When I try deleting, I have extra quotes. > > Confirm deletion of restriction 'Manual''') > ... Caroline, I fixed this with a follow-up. Maybe you can try and sign-off since Katrin and I both have patches on this now? I
Created attachment 150226 [details] [review] Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 150227 [details] [review] Bug 33551: (follow-up) Remove spans by using TT filter This allows up to keep the restriction name in the title by removing the span tags with a TT filter. Copied from bug 32061. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 150228 [details] [review] Bug 33551: (follow-up) fix display when deleting Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thank you both!
the remove span is really not future proof. What if you add an other tag to the include? You need another PROCESS that would return the translated restriction type from a given code. It will be used from the existing include, and from your <title>
(In reply to Jonathan Druart from comment #16) > the remove span is really not future proof. What if you add an other tag to > the include? I agree it's not the prettiest fix, but we already use it in another spot. The span in this case was added to aid translations. Maybe we could add a note to the PROCESS for now? I could also file a separate bug for a 'no span' option. > You need another PROCESS that would return the translated restriction type > from a given code. It will be used from the existing include, and from your > <title> Sorry, I read it three times, but still not get it :( Can you explain? Happy to file it as a new bug, but it might not be for me right now.
Created attachment 150565 [details] [review] [ALTERNATIVE-PATCH] Bug 33551: Remove span from restriction-types.inc
Why not simply this patch?
Ok, you win - that's a good idea.
Created attachment 150617 [details] [review] Bug 33551: Remove span from restriction-types.inc Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 150618 [details] [review] Bug 33551: (QA follow-up) Fix TT filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I've tested in the GUI, but also updated the po files to verify that the changes show up as strings and can be translated. Also fixed some TT filters ;)
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Missing dependencies for 22.05.x, no backport.