Bug 32072 - Consistent classes for primary buttons: Cataloging
Summary: Consistent classes for primary buttons: Cataloging
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 32067 33655
  Show dependency treegraph
 
Reported: 2022-11-02 12:22 UTC by Owen Leonard
Modified: 2024-07-04 20:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:


Attachments
Bug 32072: Consistent classes for primary buttons: Cataloging (22.34 KB, patch)
2022-11-02 12:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32072: Consistent classes for primary buttons: Cataloging (22.40 KB, patch)
2022-11-10 10:25 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32072: Consistent classes for primary buttons: Cataloging (22.16 KB, patch)
2022-11-11 18:51 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-02 12:22:01 UTC
As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary buttons:

This patch will update buttons in cataloging templates so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes.

In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary.
Comment 1 Owen Leonard 2022-11-02 12:33:23 UTC
Created attachment 142951 [details] [review]
Bug 32072: Consistent classes for primary buttons: Cataloging

This patch makes changes the button markup in Cataloging templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Cataloging to confirm
that everything looks correct. In most cases there are no visible
changes.
Comment 2 Katrin Fischer 2022-11-10 10:25:21 UTC
Created attachment 143636 [details] [review]
Bug 32072: Consistent classes for primary buttons: Cataloging

This patch makes changes the button markup in Cataloging templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Cataloging to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2022-11-10 18:15:20 UTC
Going straight to PQA here.
Comment 4 Owen Leonard 2022-11-11 18:51:57 UTC
Created attachment 143797 [details] [review]
Bug 32072: Consistent classes for primary buttons: Cataloging

This patch makes changes the button markup in Cataloging templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Cataloging to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2022-11-11 19:54:24 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Owen Leonard 2023-09-19 13:04:04 UTC
Depends on Bug 30952 - New design for staff interface, not in 22.05.x.