Bug 33655 - z39.50 search no longer shows search in progress
Summary: z39.50 search no longer shows search in progress
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32072
Blocks:
  Show dependency treegraph
 
Reported: 2023-05-02 19:32 UTC by Donna
Modified: 2023-06-15 19:17 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33655: z39.50 search no longer shows search in progress (5.17 KB, patch)
2023-05-10 10:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33655: z39.50 search no longer shows search in progress (5.22 KB, patch)
2023-05-11 00:17 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 33655: z39.50 search no longer shows search in progress (5.30 KB, patch)
2023-05-11 06:35 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Donna 2023-05-02 19:32:02 UTC
With 22.11 when adding a new bib record via z39.50 import there is no longer any indication that a search has been submitted.  Previously, the cursor icon would change to the busy status, but now there is no change so there is no way to know if the search has been submitted or not.  This leads to staff submitting the same search repeatedly.
Comment 1 Lucas Gass 2023-05-02 22:05:00 UTC
On what version of Koha did this previously work for you? I would love to implement something like I proposed in Bug 30437 here.
Comment 2 Katrin Fischer 2023-05-02 22:06:25 UTC
I was wondering too - maybe only on the advanced editor?
Comment 3 Phil Ringnalda 2023-05-03 21:11:01 UTC
The basic editor, in 22.05.

This is a regression from bug 32072, because https://git.koha-community.org/Koha-community/Koha/src/commit/9c039d4716a099365a45ab8d40d6b1362229f72b/koha-tmpl/intranet-tmpl/prog/js/z3950_search.js#L30 sets cursor: wait on click of a thing with the class "submit" but the submit button for a Z39.50 search no longer has that class.
Comment 4 Owen Leonard 2023-05-10 10:56:33 UTC
Created attachment 150964 [details] [review]
Bug 33655: z39.50 search no longer shows search in progress

This patch adds an id to z39.50 search interface submit buttons so that
the JavaScript event for changing the cursor can be linked to that
instead of the obsolete class.

The patch also adds code copied from Bug 33233 in order to make the
"waiting" cursor revert to the default if the user uses the back button
to return to the search form.

To test, apply the patch and go to Cataloging -> New from Z39.50

- Fill in a search term and click the submit button
- Your cursor should change to a "waiting" cursor while the search is
  performed, before you're redirected to the results.
- From the results page, clicking the back button (or right-clicking the
  page and choosing "Back") should return you to the search form and
  your cursor should be a standard pointer.

Perform the same test from:

- Acquisitions -> Vendor -> Basket -> Add to basket -> From an external
  source
- Authorities -> New from Z39.50/SRU
Comment 5 Phil Ringnalda 2023-05-11 00:17:47 UTC
Created attachment 151040 [details] [review]
Bug 33655: z39.50 search no longer shows search in progress

This patch adds an id to z39.50 search interface submit buttons so that
the JavaScript event for changing the cursor can be linked to that
instead of the obsolete class.

The patch also adds code copied from Bug 33233 in order to make the
"waiting" cursor revert to the default if the user uses the back button
to return to the search form.

To test, apply the patch and go to Cataloging -> New from Z39.50

- Fill in a search term and click the submit button
- Your cursor should change to a "waiting" cursor while the search is
  performed, before you're redirected to the results.
- From the results page, clicking the back button (or right-clicking the
  page and choosing "Back") should return you to the search form and
  your cursor should be a standard pointer.

Perform the same test from:

- Acquisitions -> Vendor -> Basket -> Add to basket -> From an external
  source
- Authorities -> New from Z39.50/SRU

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 6 Jonathan Druart 2023-05-11 06:35:17 UTC
Created attachment 151045 [details] [review]
Bug 33655: z39.50 search no longer shows search in progress

This patch adds an id to z39.50 search interface submit buttons so that
the JavaScript event for changing the cursor can be linked to that
instead of the obsolete class.

The patch also adds code copied from Bug 33233 in order to make the
"waiting" cursor revert to the default if the user uses the back button
to return to the search form.

To test, apply the patch and go to Cataloging -> New from Z39.50

- Fill in a search term and click the submit button
- Your cursor should change to a "waiting" cursor while the search is
  performed, before you're redirected to the results.
- From the results page, clicking the back button (or right-clicking the
  page and choosing "Back") should return you to the search form and
  your cursor should be a standard pointer.

Perform the same test from:

- Acquisitions -> Vendor -> Basket -> Add to basket -> From an external
  source
- Authorities -> New from Z39.50/SRU

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Tomás Cohen Arazi 2023-05-12 14:21:30 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-05-15 12:42:35 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 9 Lucas Gass 2023-06-15 19:17:14 UTC
Missing dependecies for 22.05.x, no backport