Bug 32223 - package.json script paths too specific
Summary: package.json script paths too specific
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords:
Depends on:
Blocks: 32224
  Show dependency tree / graph
 
Reported: 2022-11-16 08:09 UTC by Jonathan Druart
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 32223: Remove node_modules/.bin from package.json (970 bytes, patch)
2022-11-16 08:10 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 32223: Remove node_modules/.bin from package.json (1.00 KB, patch)
2022-11-16 11:32 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-16 08:09:14 UTC 
"build": "node_modules/.bin/gulp build",

We should not specify the node_modules/.bin part if the env is correctly configured.
Comment 1 Jonathan Druart 2022-11-16 08:10:11 UTC 
Created attachment 143942 [details] [review]
Bug 32223: Remove node_modules/.bin from package.json

We should not specify the node_modules/.bin part if the env is correctly configured.
Comment 2 Jonathan Druart 2022-11-16 08:12:35 UTC 
To test:
pull the latest ktd images (to get /kohadevbox/node_modules)
remove your node_modules directory from $SYNC_REPO (if exists)
Run yarn gulp commands to regenerate css files
Comment 3 Tomás Cohen Arazi (tcohen) 2022-11-16 11:32:29 UTC 
Created attachment 143949 [details] [review]
Bug 32223: Remove node_modules/.bin from package.json

We should not specify the node_modules/.bin part if the env is correctly configured.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-11-16 11:44:52 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!