Bug 32224 - Add cypress and prettier to the yarn commands
Summary: Add cypress and prettier to the yarn commands
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 32223
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-16 08:18 UTC by Jonathan Druart
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32224: Add cypress to yarn commands (1.05 KB, patch)
2022-11-16 08:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32224: Add cypress to yarn commands (1.11 KB, patch)
2022-11-16 19:35 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 32224: Add prettier to yarn commands (755 bytes, patch)
2022-11-17 07:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32224: Add cypress to yarn commands (1.11 KB, patch)
2022-11-17 17:03 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 32224: Add prettier to yarn commands (811 bytes, patch)
2022-11-17 17:03 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-16 08:18:09 UTC
Either I am missing something obvious, or we need to add cypress to the scripts of package.json

With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I cannot run
  yarn run cypress run

`cypress run` is working with an adjusted PATH (see https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173792905) but I think both should work.
Comment 1 Jonathan Druart 2022-11-16 08:20:01 UTC
Created attachment 143943 [details] [review]
Bug 32224: Add cypress to yarn commands

Either I am missing something obvious, or we need to add cypress to the scripts of package.json

With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I cannot run
  yarn run cypress run

`cypress run` is working with an adjusted PATH (see https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173792905) but I think both should work.
Comment 2 Tomás Cohen Arazi 2022-11-16 19:35:47 UTC
Created attachment 143969 [details] [review]
Bug 32224: Add cypress to yarn commands

Either I am missing something obvious, or we need to add cypress to the scripts of package.json

With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I cannot run
  yarn run cypress run

`cypress run` is working with an adjusted PATH (see https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173792905) but I think both should work.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Jonathan Druart 2022-11-17 07:50:52 UTC
Looks like we need prettier as well

xt/vue_tidy.t is failing with:
  error Command "prettier" not found.
Comment 4 Jonathan Druart 2022-11-17 07:54:21 UTC
Created attachment 143983 [details] [review]
Bug 32224: Add prettier to yarn commands

xt/vue_tidy.t was failing with:
  error Command "prettier" not found.
Comment 5 Tomás Cohen Arazi 2022-11-17 17:03:00 UTC
Created attachment 144014 [details] [review]
Bug 32224: Add cypress to yarn commands

Either I am missing something obvious, or we need to add cypress to the scripts of package.json

With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I cannot run
  yarn run cypress run

`cypress run` is working with an adjusted PATH (see https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173792905) but I think both should work.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi 2022-11-17 17:03:16 UTC
Created attachment 144015 [details] [review]
Bug 32224: Add prettier to yarn commands

xt/vue_tidy.t was failing with:
  error Command "prettier" not found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 7 Tomás Cohen Arazi 2022-11-17 17:41:13 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!