When looking at Column.pm, you can see that all the columns are translated to nice display messages, but not the ones for suggestions. They are direct copies of the names of the database columns. This means that 'collectiontitle' and similar show up in translations creating some confusion. Should these not also be nice labels? suggestions=> { "author" => __("author"), "copyrightdate" => __("copyrightdate"), "isbn" => __("isbn"), "publishercode" => __("publishercode"), "collectiontitle" => __("collectiontitle"), "place" => __("place"), "quantity" => __("quantity"), "itemtype" => __("itemtype"), "branchcode" => __("branchcode"), "patronreason" => __("patronreason"), "note" => __("note"), "title" => __("title"), }
Yes, I think so.
Created attachment 144137 [details] [review] Bug 32292: Add column descriptions to subscriptions table / complete items table * Adds proper labels to the database columns for suggestions * Adds missing item columns: * coded_location_qualifier * deleted_on * exclude_form_local_holds_priority * Fixes spelling of item type, Uniform resource identifier To test: * Go to reports > Guided reports * Select acquisition or another module using the items * Make sure all entries for the tables items up with nice descriptions * Changes to subscriptions: verify reading the patch, these don't seem to show up yet in guided reports.
Created attachment 144138 [details] [review] Bug 32292: Add column descriptions to aqorders table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing.
Created attachment 144139 [details] [review] Bug 32292: Add column descriptions to biblio table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing.
Created attachment 144140 [details] [review] Bug 32291: Add missing column descriptions to borrowers table Adds missing column descriptions for new features etc. to the existing entry for borrowres columns descriptions. To test: * Go to reports > Guided reports * Select patrons module * Make sure all entries for the tables items and suggestions show up with nice descriptions
Fell down the rabbit hole a little bit here... will file some bugs for other tables still missing.
Created attachment 144141 [details] [review] Bug 32292: Fix POD POD had a typo in suggestions and was missing the new aqorders.
Created attachment 144410 [details] [review] Bug 32292: Add column descriptions to subscriptions table / complete items table * Adds proper labels to the database columns for suggestions * Adds missing item columns: * coded_location_qualifier * deleted_on * exclude_form_local_holds_priority * Fixes spelling of item type, Uniform resource identifier To test: * Go to reports > Guided reports * Select acquisition or another module using the items * Make sure all entries for the tables items up with nice descriptions * Changes to subscriptions: verify reading the patch, these don't seem to show up yet in guided reports. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 144411 [details] [review] Bug 32292: Add column descriptions to aqorders table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 144412 [details] [review] Bug 32292: Add column descriptions to biblio table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 144413 [details] [review] Bug 32291: Add missing column descriptions to borrowers table Adds missing column descriptions for new features etc. to the existing entry for borrowres columns descriptions. To test: * Go to reports > Guided reports * Select patrons module * Make sure all entries for the tables items and suggestions show up with nice descriptions https://bugs.koha-community.org/show_bug.cgi?id=32292 Signed-off-by: David Nind <david@davidnind.com>
Created attachment 144414 [details] [review] Bug 32292: Fix POD POD had a typo in suggestions and was missing the new aqorders. Signed-off-by: David Nind <david@davidnind.com>
Testing notes using KTD (koha-testing-docker): 1. Added Katrin as the assignee :) 2. I couldn't see the suggestions descriptions or fields in any of the guided reports available - I am assuming that they are used/show elsewhere in Koha, and not just the guided reports. 3. I confused myself when testing, so I recorded what this bug takes care of for each of the guided reports, and the other bugs that will fix the remaining descriptions. 4. This bug takes care of all descriptions for items, acqorders, biblio, and borrowers. 5. These bugs will take care of all the other descriptions: - Bug 32312: Circulation - statistics (remaining items) - Bug 32313: Catalog - biblioitems (remaining items) - Bug 32314: Accounts - accountlines (all missing) - Bug 32315: Serials - serial (all missing), serialitems (all missing), subscription (most missing), subscriptionhistory (all missing), subscriptionroutinglist (all missing), acqbooksellers (all missing) 6. Bugs by guided report category: Circulation: - statistics: some missing, bug 32312 - items: OK, fixed by this bug - biblioitems: some missing, bug 32313 Catalog: - items: OK, fixed by this bug - biblioitems: some missing, bug 32313 - biblio: OK, fixed by this bug Patrons: - borrowers: OK, fixed by this bug Acquisitions: - acqorders: OK, fixed by this bug - biblio: OK, fixed by this bug - items: OK, fixed by this bug Accounts: - borrowers: OK, fixed by this bug - accountlines: all missing, bug 32314 Serials: - serial: all missing, bug 32315 - serialitems: all missing, bug 32315 - subscription: most missing, bug 32315 - subscriptionhistory: all missing, bug 32315 - subscriptionroutinglist: all missing, bug 32315 - biblioitems: some missing, bug 32313 - biblio: OK, fixed by this bug - acqbooksellers: all missing, bug 32315
(In reply to David Nind from comment #13) > Testing notes using KTD (koha-testing-docker): > > 1. Added Katrin as the assignee :) Hope Nick doesn't see this :) Great summary, thx David!
Created attachment 145853 [details] [review] Bug 32292: Add column descriptions to subscriptions table / complete items table * Adds proper labels to the database columns for suggestions * Adds missing item columns: * coded_location_qualifier * deleted_on * exclude_form_local_holds_priority * Fixes spelling of item type, Uniform resource identifier To test: * Go to reports > Guided reports * Select acquisition or another module using the items * Make sure all entries for the tables items up with nice descriptions * Changes to subscriptions: verify reading the patch, these don't seem to show up yet in guided reports. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 145854 [details] [review] Bug 32292: Add column descriptions to aqorders table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 145855 [details] [review] Bug 32292: Add column descriptions to biblio table This adds nice descriptions to the aqorders database columns. To test: * Go to Guided reports * Start a new report for acquisitions module * Verify that all aqorders columns show with nice descriptions None should be missing. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 145856 [details] [review] Bug 32292: Add missing column descriptions to borrowers table Adds missing column descriptions for new features etc. to the existing entry for borrowres columns descriptions. To test: * Go to reports > Guided reports * Select patrons module * Make sure all entries for the tables items and suggestions show up with nice descriptions Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 145857 [details] [review] Bug 32292: Fix POD POD had a typo in suggestions and was missing the new aqorders. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Great work, nice cleanup again. Minor fix applied to one patch to fix the bug number typo. Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Created attachment 145868 [details] [review] Bug 32292: Tidy and sort keys This patch does a perltidy on the data structure, but also organizes keys alphabetically to ease maintenance. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Doesn't apply cleanly to 22.05.x, no backport