Bug 32416 - arp - Accelerated reader point searches fail due to conflicting attribute
Summary: arp - Accelerated reader point searches fail due to conflicting attribute
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Zebra (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 20078 28830
Blocks: 32741
  Show dependency treegraph
 
Reported: 2022-12-07 12:54 UTC by Nick Clemens
Modified: 2023-12-28 20:44 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes
Version(s) released in:
23.05.00,22.11.03,22.05.10,21.11.16


Attachments
Bug 32416: Update attribute number for arp search to 9015 (1.69 KB, patch)
2022-12-07 13:03 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32416: Add a warning to the file (856 bytes, patch)
2022-12-07 13:03 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32416: Update attribute number for arp search to 9015 (1.74 KB, patch)
2022-12-09 09:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 32416: Add a warning to the file (904 bytes, patch)
2022-12-09 09:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 32416: Update attribute number for arp search to 9015 (1.83 KB, patch)
2023-01-27 07:59 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32416: Add a warning to the file (1002 bytes, patch)
2023-01-27 07:59 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2022-12-07 12:54:55 UTC
Bug 20078 updated the attribute for arp to 2014 to avoid conflict with 9013 not-on-loan-count

Bug 28830 then added Control-number-identifier as 2014, breaking arp again
Comment 1 Nick Clemens 2022-12-07 13:03:01 UTC
Created attachment 144465 [details] [review]
Bug 32416: Update attribute number for arp search to 9015

Bug 20078 updated the attribute for arp to 2014 to avoid conflict with 9013 not-on-loan-count

Bug 28830 then added Control-number-identifier as 2014, breaking arp again

This patch updates the number to 9015

To test:
1 - Apply first patch
2 - Attempt searching by arp, no results (add a unique 526$d to a record to ease searching)
3 - Apply this patch
4 - Copy bib1.att and ccl.properties to the correct locations
    cp etc/zebradb/biblios/etc/bib1.att /etc/koha/zebradb/biblios/etc/bib1.att
    cp etc/zebradb/ccl.properties /etc/koha/zebradb/ccl.properties
5 - Restart zebra
6 - Rebuild indexes
7 - Search again, success!
Comment 2 Nick Clemens 2022-12-07 13:03:06 UTC
Created attachment 144466 [details] [review]
Bug 32416: Add a warning to the file
Comment 3 David Nind 2022-12-09 09:04:50 UTC
Created attachment 144519 [details] [review]
Bug 32416: Update attribute number for arp search to 9015

Bug 20078 updated the attribute for arp to 2014 to avoid conflict with 9013 not-on-loan-count

Bug 28830 then added Control-number-identifier as 2014, breaking arp again

This patch updates the number to 9015

To test:
1 - Apply first patch
2 - Attempt searching by arp, no results (add a unique 526$d to a record to ease searching)
3 - Apply this patch
4 - Copy bib1.att and ccl.properties to the correct locations
    cp etc/zebradb/biblios/etc/bib1.att /etc/koha/zebradb/biblios/etc/bib1.att
    cp etc/zebradb/ccl.properties /etc/koha/zebradb/ccl.properties
5 - Restart zebra
6 - Rebuild indexes
7 - Search again, success!

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-12-09 09:04:55 UTC
Created attachment 144520 [details] [review]
Bug 32416: Add a warning to the file

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2022-12-09 09:08:37 UTC
Testing notes (using KTD):

1. Used notes from bug 20078

2. Added to a record:
   . 526$c (arl) - 5.5
   . 526$d (arp) - 14

3. Used arp:14 in search (both staff interface and OPAC)
Comment 6 Marcel de Rooy 2023-01-27 07:59:14 UTC
Created attachment 145713 [details] [review]
Bug 32416: Update attribute number for arp search to 9015

Bug 20078 updated the attribute for arp to 2014 to avoid conflict with 9013 not-on-loan-count

Bug 28830 then added Control-number-identifier as 2014, breaking arp again

This patch updates the number to 9015

To test:
1 - Apply first patch
2 - Attempt searching by arp, no results (add a unique 526$d to a record to ease searching)
3 - Apply this patch
4 - Copy bib1.att and ccl.properties to the correct locations
    cp etc/zebradb/biblios/etc/bib1.att /etc/koha/zebradb/biblios/etc/bib1.att
    cp etc/zebradb/ccl.properties /etc/koha/zebradb/ccl.properties
5 - Restart zebra
6 - Rebuild indexes
7 - Search again, success!

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Marcel de Rooy 2023-01-27 07:59:19 UTC
Created attachment 145714 [details] [review]
Bug 32416: Add a warning to the file

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Tomás Cohen Arazi 2023-01-27 19:07:06 UTC
Hi y'all. I'm pushing this, but this clearly deserves a regression test IMHO.

I have actually filed bug 32741 in which I provide such regression tests, but would love your help fixing the other cases we didn't catch here :-D
Comment 9 Tomás Cohen Arazi 2023-01-27 19:19:31 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Matt Blenkinsop 2023-01-31 14:28:48 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 11 Lucas Gass 2023-02-01 18:37:44 UTC
Backported to 22.05.x for upcoming 22.05.10
Comment 12 Arthur Suzuki 2023-02-17 09:34:39 UTC
applied to 21.11.x for 21.11.16
Comment 13 wainuiwitikapark 2023-03-15 01:41:10 UTC
Not backported to 21.05.x