Raised on bug 32416, we should prevent this to happen.
Created attachment 145770 [details] [review] Bug 32741: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 145773 [details] [review] Bug 32741: Fix {biblios|authorities}/bib1.att duplicate codes This patch fixes a duplicate attribute code for Author-in-order in the biblios definition. The picked code matches what was already in ccl.properties. Also Chronological-term for authorities gets fixed. To test: 1. Apply the regression tests 2. Run: k$ prove xt/verify_bib1.att.t => FAIL: Some failiures 3. Apply this patch 4. Repeat 1 => SUCCESS: Tests now pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Tests still fail for me after applying the fix patch 8-(.. prove xt/verify_bib1.att.t xt/verify_bib1.att.t .. # Failed test 'Only one occurrence for code (9014)' # at xt/verify_bib1.att.t line 42. # got: '2' # expected: '1' # Looks like you failed 1 test of 289. xt/verify_bib1.att.t .. 1/2 # Failed test 'bib1.att tests for biblios' # at xt/verify_bib1.att.t line 44. # Looks like you failed 1 test of 2. xt/verify_bib1.att.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- xt/verify_bib1.att.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=2, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.12 cusr 0.02 csys = 0.17 CPU) Result: FAIL
(In reply to David Nind from comment #3) > Tests still fail for me after applying the fix patch 8-(.. You applied it on an outdated branch? Bug 32416 fixes that case, and I'm sure I pushed to master.
(In reply to Tomás Cohen Arazi from comment #4) > (In reply to David Nind from comment #3) > > Tests still fail for me after applying the fix patch 8-(.. > > You applied it on an outdated branch? Bug 32416 fixes that case, and I'm > sure I pushed to master. You are absolutely right! (I only updated master about an hour or so ago 8)). Everything now passes with an up-to-date master. Sign off on the way....
Created attachment 145777 [details] [review] Bug 32741: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 145778 [details] [review] Bug 32741: Fix {biblios|authorities}/bib1.att duplicate codes This patch fixes a duplicate attribute code for Author-in-order in the biblios definition. The picked code matches what was already in ccl.properties. Also Chronological-term for authorities gets fixed. To test: 1. Apply the regression tests 2. Run: k$ prove xt/verify_bib1.att.t => FAIL: Some failiures 3. Apply this patch 4. Repeat 1 => SUCCESS: Tests now pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 145936 [details] [review] Bug 32741: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 145937 [details] [review] Bug 32741: Fix {biblios|authorities}/bib1.att duplicate codes This patch fixes a duplicate attribute code for Author-in-order in the biblios definition. The picked code matches what was already in ccl.properties. Also Chronological-term for authorities gets fixed. To test: 1. Apply the regression tests 2. Run: k$ prove xt/verify_bib1.att.t => FAIL: Some failiures 3. Apply this patch 4. Repeat 1 => SUCCESS: Tests now pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice to have regressions tests here now, all works as expected, no regressions. Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Backported to 22.05.x for upcoming 22.05.10
applied to 21.11.x for 21.11.16
Not backported to 21.05.x