Bug 32582 - Mailmap maps to wrong email address
Summary: Mailmap maps to wrong email address
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-06 21:26 UTC by Katrin Fischer
Modified: 2023-06-08 22:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.02


Attachments
Bug 32582: Fix error in .mailmap (1.53 KB, patch)
2023-01-06 21:32 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32582: Fix error in .mailmap (1.58 KB, patch)
2023-01-07 11:00 UTC, David Nind
Details | Diff | Splinter Review
Bug 32582: Fix error in .mailmap (1.67 KB, patch)
2023-01-13 10:16 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-01-06 21:26:34 UTC

    
Comment 1 Katrin Fischer 2023-01-06 21:32:58 UTC
Created attachment 145108 [details] [review]
Bug 32582: Fix error in .mailmap

The .mailmap had the addresses in the wrong
sequence. The .83 address is actually the correct
one.

How this works is easiest to see in git:
* Apply one of my patches, like bug 31962
* Do a git log
* You'll see the email address without .83 as author
* Apply this patch
* You should see the correct email now in both,
  matching the one in the patch file on bugzilla
Comment 2 David Nind 2023-01-07 11:00:54 UTC
Created attachment 145132 [details] [review]
Bug 32582: Fix error in .mailmap

The .mailmap had the addresses in the wrong
sequence. The .83 address is actually the correct
one.

How this works is easiest to see in git:
* Apply one of my patches, like bug 31962
* Do a git log
* You'll see the email address without .83 as author
* Apply this patch
* You should see the correct email now in both,
  matching the one in the patch file on bugzilla

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2023-01-13 10:16:58 UTC
Created attachment 145257 [details] [review]
Bug 32582: Fix error in .mailmap

The .mailmap had the addresses in the wrong
sequence. The .83 address is actually the correct
one.

How this works is easiest to see in git:
* Apply one of my patches, like bug 31962
* Do a git log
* You'll see the email address without .83 as author
* Apply this patch
* You should see the correct email now in both,
  matching the one in the patch file on bugzilla

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2023-01-13 11:17:37 UTC
Thanks Marcel!
Comment 5 Martin Renvoize 2023-01-17 09:40:37 UTC
Nice work everyone!

Pushed to 23.05.x for the next release
Comment 6 Matt Blenkinsop 2023-01-17 15:11:43 UTC
Nice work everyone!

Pushed to stable for 22.11.x