32586 – Reindent items with no checkouts reports template

Bug 32586 - Reindent items with no checkouts reports template

Summary: Reindent items with no checkouts reports template

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Templates (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low minor
Assignee:	Katrin Fischer
QA Contact:	Martin Renvoize (ashimema)

URL:
Keywords:

Depends on:
Blocks:	32587
	Show dependency tree / graph

Reported:	2023-01-07 00:05 UTC by Katrin Fischer
Modified:	2023-12-28 20:43 UTC (History)
CC List:	2 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	23.05.00,22.11.03
Circulation function:

Attachments
Bug 32586: Reindent items with no checkouts report template (14.90 KB, patch) 2023-01-07 00:29 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 32586: Reindent items with no checkouts report template (15.08 KB, patch) 2023-01-07 09:55 UTC, Frédéric Demians	Details \| Diff \| Splinter Review
Bug 32586: Reindent items with no checkouts report template (15.15 KB, patch) 2023-01-31 13:04 UTC, Martin Renvoize (ashimema)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Katrin Fischer 2023-01-07 00:05:07 UTC

Comment 1 Katrin Fischer 2023-01-07 00:29:17 UTC

Created attachment 145121 [details] [review]
Bug 32586: Reindent items with no checkouts report template

The indentation in the template was off and also full of tab
characters, so this does some clean-up prior to doing some
other small changes on separate bugs.

To test:
* Run the 'Items with no checkouts' report in the report module
* Note: If you get an error in this step, you need to turn of
  sql_strict_mode in your koha-conf.xml, but this bug is out
  of scope here.
* Apply patch
* Rerun the report, it should appear unchanged

Comment 2 Frédéric Demians 2023-01-07 09:55:22 UTC

Created attachment 145125 [details] [review]
Bug 32586: Reindent items with no checkouts report template

The indentation in the template was off and also full of tab
characters, so this does some clean-up prior to doing some
other small changes on separate bugs.

To test:
* Run the 'Items with no checkouts' report in the report module
* Note: If you get an error in this step, you need to turn of
  sql_strict_mode in your koha-conf.xml, but this bug is out
  of scope here.
* Apply patch
* Rerun the report, it should appear unchanged

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  → Nice to the eyes, and no regression

Comment 3 Martin Renvoize (ashimema) 2023-01-31 13:04:24 UTC

Created attachment 145858 [details] [review]
Bug 32586: Reindent items with no checkouts report template

The indentation in the template was off and also full of tab
characters, so this does some clean-up prior to doing some
other small changes on separate bugs.

To test:
* Run the 'Items with no checkouts' report in the report module
* Note: If you get an error in this step, you need to turn of
  sql_strict_mode in your koha-conf.xml, but this bug is out
  of scope here.
* Apply patch
* Rerun the report, it should appear unchanged

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  → Nice to the eyes, and no regression
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 4 Martin Renvoize (ashimema) 2023-01-31 13:04:48 UTC

No regressions found, nice cleanup.

Passing QA

Comment 5 Tomás Cohen Arazi (tcohen) 2023-01-31 13:48:29 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 6 Jacob O'Mara 2023-01-31 18:11:19 UTC

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.

Comment 7 Lucas Gass (lukeg) 2023-02-03 22:08:30 UTC

Doesn't apply cleanly to 22.05.x, no backport