Bug 32587 - Add page-section to items with no checkouts report
Summary: Add page-section to items with no checkouts report
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952 32586
Blocks: 31757 32589
  Show dependency treegraph
 
Reported: 2023-01-07 00:31 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32587: Add page-section to 'items with no checkouts' report (9.12 KB, patch)
2023-01-07 01:33 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32587: Add page-section to 'items with no checkouts' report (9.30 KB, patch)
2023-01-07 10:17 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 32587: Add page-section to 'items with no checkouts' report (9.36 KB, patch)
2023-01-31 13:05 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-01-07 00:31:28 UTC

    
Comment 1 Katrin Fischer 2023-01-07 01:33:22 UTC
Created attachment 145122 [details] [review]
Bug 32587: Add page-section to 'items with no checkouts' report

This adds page sections to the summary and result tables
for the 'items with no checkouts' report.

To test:
* Run the 'item with no checkouts' report with different settings
* Confirm result tables are missing the white brackground from
  page-section
* Apply patch
* Confirm the result tables now do have the white background
Comment 2 Frédéric Demians 2023-01-07 10:17:15 UTC
Created attachment 145126 [details] [review]
Bug 32587: Add page-section to 'items with no checkouts' report

This adds page sections to the summary and result tables
for the 'items with no checkouts' report.

To test:
* Run the 'item with no checkouts' report with different settings
* Confirm result tables are missing the white brackground from
  page-section
* Apply patch
* Confirm the result tables now do have the white background

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  → Confirm both problem and solution
Comment 3 Martin Renvoize 2023-01-31 13:05:49 UTC
Created attachment 145859 [details] [review]
Bug 32587: Add page-section to 'items with no checkouts' report

This adds page sections to the summary and result tables
for the 'items with no checkouts' report.

To test:
* Run the 'item with no checkouts' report with different settings
* Confirm result tables are missing the white brackground from
  page-section
* Apply patch
* Confirm the result tables now do have the white background

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  → Confirm both problem and solution
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-01-31 13:06:14 UTC
More great work, thanks Katrin.

No regressions, Passing QA
Comment 5 Tomás Cohen Arazi 2023-01-31 13:48:34 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-01-31 18:11:24 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 7 Lucas Gass 2023-02-03 22:09:28 UTC
Missing dependencies for 22.05.x, no backport