When these prefs are active we add the fines for guarantors/guarantees to the patrons total fines in order to check against the limits. We also then transmit this total as the fines owed by the patron. On SIP machines that take payments, this is read as the amount owed, and when a patron pays this amount they end up with a credit on their account, and no way to transfer that balance to the charges for related patrons. I think we should report when blocked by other patrons, but only transmit the patrons own fines
Created attachment 145304 [details] [review] Bug 32624: Don't include guarantee or guarantor fines in BV (fines amount) in SIP messages This patch chanegs the code to report only the patron's personal fines, and to report a block from other fines in the screen message This is to prevent overpayment on accounts from SIP machines To test: 1 - prove t/db_dependent/SIP/Patron.t
Created attachment 145345 [details] [review] Bug 32624: Don't include guarantee or guarantor fines in BV (fines amount) in SIP messages This patch chanegs the code to report only the patron's personal fines, and to report a block from other fines in the screen message This is to prevent overpayment on accounts from SIP machines To test: 1 - prove t/db_dependent/SIP/Patron.t Signed-off-by: David Nind <david@davidnind.com>
This has caused a lot of problems at our library. Patrons end up trying to pay over and over and the fines won't go away (because they are fines from another account) and then they have a bunch of credit on their library account and we have to go find the other family member cards and resolve the fines manually. Would love to see this get fixed as soon as possible. Thank you for working on it!
My initial reaction to this is that really we aught to be allowing payment of guarantees fines via SIP as apposed to overruling the blocking rules the way we are here. But, I need to dig through the code a bit here before I block it, I've not done that yet and this may be a decent intermediate work around whilst we work on a wider problem of guarantees fines.
OK.. looked at the code now.. seems reasonable. Will work through QA today.
Created attachment 146329 [details] [review] Bug 32624: Don't include guarantee or guarantor fines in BV (fines amount) in SIP messages This patch chanegs the code to report only the patron's personal fines, and to report a block from other fines in the screen message This is to prevent overpayment on accounts from SIP machines To test: 1 - prove t/db_dependent/SIP/Patron.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as described, fixes a real issue and is well covered by tests. Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Backported to 22.05.x for upcoming 22.05.10
applied to 21.11.x for 21.11.18
Not backported to 21.05.x