Bug 33055 - SIP2 adding incorrect fines blocked message
Summary: SIP2 adding incorrect fines blocked message
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Nick Clemens (kidclamp)
QA Contact:
URL:
Keywords:
Depends on: 32624
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-23 15:15 UTC by Nick Clemens (kidclamp)
Modified: 2023-12-28 20:42 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11,21.11.19
Circulation function:

Attachments
Bug 33055: (bug 32624 follow-up) Unit tests (3.05 KB, patch)
2023-02-23 15:35 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked (1.74 KB, patch)
2023-02-23 15:35 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 33055: (bug 32624 follow-up) Unit tests (3.11 KB, patch)
2023-02-24 13:30 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked (1.80 KB, patch)
2023-02-24 13:30 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 33055: (bug 32624 follow-up) Unit tests (3.17 KB, patch)
2023-02-28 16:55 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked (1.86 KB, patch)
2023-02-28 16:55 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-02-23 15:15:06 UTC 
Bug 32624 neglected an if condition on adding the fines blocked message
Comment 1 Nick Clemens (kidclamp) 2023-02-23 15:35:49 UTC 
Created attachment 147258 [details] [review]
Bug 33055: (bug 32624 follow-up) Unit tests
Comment 2 Nick Clemens (kidclamp) 2023-02-23 15:35:51 UTC 
Created attachment 147259 [details] [review]
Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked

To test:
0 - Apply first patch
1 - prove -v t/db_dependent/SIP/Patron.t
2 - It fails
3 - Apply second patch
4 - prove -v t/db_dependent/SIP/Patron.t
5 - It passes!
Comment 3 Martin Renvoize (ashimema) 2023-02-24 13:30:36 UTC 
Created attachment 147330 [details] [review]
Bug 33055: (bug 32624 follow-up) Unit tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2023-02-24 13:30:39 UTC 
Created attachment 147331 [details] [review]
Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked

To test:
0 - Apply first patch
1 - prove -v t/db_dependent/SIP/Patron.t
2 - It fails
3 - Apply second patch
4 - prove -v t/db_dependent/SIP/Patron.t
5 - It passes!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2023-02-24 13:31:28 UTC 
Damn.. annoyed I missed this at QA first time around :(.

Working as expected now, Signing off.
Comment 6 Tomás Cohen Arazi (tcohen) 2023-02-28 16:55:37 UTC 
Created attachment 147507 [details] [review]
Bug 33055: (bug 32624 follow-up) Unit tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 7 Tomás Cohen Arazi (tcohen) 2023-02-28 16:55:40 UTC 
Created attachment 147508 [details] [review]
Bug 33055: (bug 32624 follow-up) Don't send a screen message if not blocked

To test:
0 - Apply first patch
1 - prove -v t/db_dependent/SIP/Patron.t
2 - It fails
3 - Apply second patch
4 - prove -v t/db_dependent/SIP/Patron.t
5 - It passes!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 8 Tomás Cohen Arazi (tcohen) 2023-03-02 12:39:43 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Matt Blenkinsop 2023-03-03 12:06:05 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 10 Lucas Gass (lukeg) 2023-03-10 14:36:23 UTC 
Backported to 22.05.x for upcoming 22.05.11
Comment 11 Arthur Suzuki 2023-03-29 13:04:06 UTC 
applied to 21.11 for 21.11.19
Comment 12 Wainui Witika-Park 2023-04-27 05:37:33 UTC 
Not backported to 21.05.x