Bug 32743 - Reindent the invoice details page
Summary: Reindent the invoice details page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 32746 32769
  Show dependency treegraph
 
Reported: 2023-01-30 11:55 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32743: Reindent the invoice details page (52.68 KB, patch)
2023-01-30 12:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32743: (follow-up) Add markup comments (7.03 KB, patch)
2023-01-30 12:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32743: (follow-up) Add markup comments (7.09 KB, patch)
2023-01-30 23:13 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32743: Reindent the invoice details page (51.93 KB, patch)
2023-01-31 16:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32743: (follow-up) Add markup comments (7.97 KB, patch)
2023-01-31 16:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32743: Reindent the invoice details page (51.98 KB, patch)
2023-02-03 00:44 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32743: (follow-up) Add markup comments (8.03 KB, patch)
2023-02-03 00:44 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32743: Reindent the invoice details page (52.04 KB, patch)
2023-02-05 12:03 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32743: (follow-up) Add markup comments (8.08 KB, patch)
2023-02-05 12:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-01-30 11:55:04 UTC
I would like to reformat the invoice template (invoice.tt) in the staff interface so that it has consistent spacing and indentation.
Comment 1 Owen Leonard 2023-01-30 12:33:24 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-01-30 12:33:28 UTC Comment hidden (obsolete)
Comment 3 Lucas Gass 2023-01-30 23:13:05 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2023-01-31 16:05:14 UTC
Created attachment 145885 [details] [review]
Bug 32743: Reindent the invoice details page

This patch reindents the invoice template so that it has consistent
indentation. These changes should have no visible effect on the page.

To test, apply the patch and go to Acquisitions -> Invoices.

- Perform a search which will return invoice results.
- Click on an invoice to view the details.
- Everything should look normal.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.
Comment 5 Owen Leonard 2023-01-31 16:05:19 UTC
Created attachment 145886 [details] [review]
Bug 32743: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 6 Lucas Gass 2023-02-03 00:44:10 UTC
Created attachment 146043 [details] [review]
Bug 32743: Reindent the invoice details page

This patch reindents the invoice template so that it has consistent
indentation. These changes should have no visible effect on the page.

To test, apply the patch and go to Acquisitions -> Invoices.

- Perform a search which will return invoice results.
- Click on an invoice to view the details.
- Everything should look normal.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 Lucas Gass 2023-02-03 00:44:14 UTC
Created attachment 146044 [details] [review]
Bug 32743: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Katrin Fischer 2023-02-05 12:03:25 UTC
Created attachment 146192 [details] [review]
Bug 32743: Reindent the invoice details page

This patch reindents the invoice template so that it has consistent
indentation. These changes should have no visible effect on the page.

To test, apply the patch and go to Acquisitions -> Invoices.

- Perform a search which will return invoice results.
- Click on an invoice to view the details.
- Everything should look normal.

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2023-02-05 12:03:31 UTC
Created attachment 146193 [details] [review]
Bug 32743: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Tomás Cohen Arazi 2023-02-07 18:30:09 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 11 Pedro Amorim 2023-02-09 11:35:55 UTC
Nice work everyone!

Pushed to master for 22.11.x
Comment 12 Lucas Gass 2023-02-15 21:41:25 UTC
Doesn't apply cleanly to 22.05.x, no backport.