Bug 32813 - Fix cataloguing/value_builder/barcode.pl
Summary: Fix cataloguing/value_builder/barcode.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Julian Maurice
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 11:13 UTC by Julian Maurice
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04.22.05.11, 21.11.19


Attachments
Bug 32813: Fix cataloguing/value_builder/barcode.pl (1.13 KB, patch)
2023-02-03 11:14 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32813: Fix cataloguing/value_builder/barcode.pl (1.18 KB, patch)
2023-02-07 16:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32815: Fix cataloguing/value_builder/callnumber.pl (1.29 KB, patch)
2023-02-07 19:31 UTC, David Nind
Details | Diff | Splinter Review
Bug 32813: Fix cataloguing/value_builder/barcode.pl (1.27 KB, patch)
2023-02-16 10:45 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 11:13:43 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 11:14:17 UTC
Created attachment 146071 [details] [review]
Bug 32813: Fix cataloguing/value_builder/barcode.pl

Use event parameter instead of id.

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Owen Leonard 2023-02-07 16:10:06 UTC
Created attachment 146340 [details] [review]
Bug 32813: Fix cataloguing/value_builder/barcode.pl

Use event parameter instead of id.

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 David Nind 2023-02-07 19:31:17 UTC Comment hidden (obsolete)
Comment 4 David Nind 2023-02-07 19:37:24 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2023-02-16 10:45:19 UTC
Created attachment 146722 [details] [review]
Bug 32813: Fix cataloguing/value_builder/barcode.pl

Use event parameter instead of id.

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2023-02-16 10:46:01 UTC
I dont understand why you created lots of patches and reports for this.
Comment 7 Julian Maurice 2023-02-16 11:17:16 UTC
(In reply to Marcel de Rooy from comment #6)
> I dont understand why you created lots of patches and reports for this.

Because I think it's a lot easier to validate each plugin one by one than all at once. And also a bit because of your comment (bug 30975 comment 12):

> I had a short glance already, but the 92K scared me away ;)

At least some of them are passed QA or signed off now, which is a better state than before
Comment 8 Marcel de Rooy 2023-02-16 12:33:53 UTC
(In reply to Julian Maurice from comment #7)
> (In reply to Marcel de Rooy from comment #6)
> > I dont understand why you created lots of patches and reports for this.
> 
> Because I think it's a lot easier to validate each plugin one by one than
> all at once. And also a bit because of your comment (bug 30975 comment 12):
> 
> > I had a short glance already, but the 92K scared me away ;)
> 
> At least some of them are passed QA or signed off now, which is a better
> state than before

Haha :) Well, now I can do a bunch of them and leave. Otherwise I have to continue..
Comment 9 Tomás Cohen Arazi 2023-02-16 15:02:09 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Martin Renvoize 2023-02-24 07:52:57 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 11 Lucas Gass 2023-03-01 14:18:08 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 12 Arthur Suzuki 2023-03-29 08:54:55 UTC
applied to 21.11.x for 21.11.19
Comment 13 wainuiwitikapark 2023-04-27 03:55:12 UTC
Not backported to 21.05.x