This is part of the refactoring happening in bug 30975
Created attachment 146071 [details] [review] Bug 32813: Fix cataloguing/value_builder/barcode.pl Use event parameter instead of id. This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before
Created attachment 146340 [details] [review] Bug 32813: Fix cataloguing/value_builder/barcode.pl Use event parameter instead of id. This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 146354 [details] [review] Bug 32815: Fix cataloguing/value_builder/callnumber.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com>
Comment on attachment 146354 [details] [review] Bug 32815: Fix cataloguing/value_builder/callnumber.pl Accidentally attached a sign-off for another bug, obsoleting!
Created attachment 146722 [details] [review] Bug 32813: Fix cataloguing/value_builder/barcode.pl Use event parameter instead of id. This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I dont understand why you created lots of patches and reports for this.
(In reply to Marcel de Rooy from comment #6) > I dont understand why you created lots of patches and reports for this. Because I think it's a lot easier to validate each plugin one by one than all at once. And also a bit because of your comment (bug 30975 comment 12): > I had a short glance already, but the 92K scared me away ;) At least some of them are passed QA or signed off now, which is a better state than before
(In reply to Julian Maurice from comment #7) > (In reply to Marcel de Rooy from comment #6) > > I dont understand why you created lots of patches and reports for this. > > Because I think it's a lot easier to validate each plugin one by one than > all at once. And also a bit because of your comment (bug 30975 comment 12): > > > I had a short glance already, but the 92K scared me away ;) > > At least some of them are passed QA or signed off now, which is a better > state than before Haha :) Well, now I can do a bunch of them and leave. Otherwise I have to continue..
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Backported to 22.05.x for upcoming 22.05.11
applied to 21.11.x for 21.11.19
Not backported to 21.05.x