Some of our scripts have a space in the shebang: $ grep -rn --include=*.pl '#! /usr/' * admin/library_groups.pl:1:#! /usr/bin/perl admin/credit_types.pl:1:#! /usr/bin/perl admin/debit_types.pl:1:#! /usr/bin/perl admin/curbside_pickup.pl:1:#! /usr/bin/perl admin/desks.pl:1:#! /usr/bin/perl admin/cities.pl:1:#! /usr/bin/perl admin/classsources.pl:1:#! /usr/bin/perl admin/matching-rules.pl:1:#! /usr/bin/perl admin/background_jobs.pl:1:#! /usr/bin/perl admin/patron-attr-types.pl:1:#! /usr/bin/perl circ/curbside_pickups.pl:1:#! /usr/bin/perl erm/erm.pl:1:#! /usr/bin/perl misc/cronjobs/delete_items.pl:1:#! /usr/bin/perl misc/maintenance/check_syspref_cache.pl:1:#! /usr/bin/perl misc/maintenance/compare_es_to_db.pl:1:#! /usr/bin/perl misc/add_statistics_borrowers_categorycode.pl:1:#! /usr/bin/perl It looks like this is not illegal (see e.g. https://unix.stackexchange.com/questions/276751/is-space-allowed-between-and-bin-bash-in-shebang) but it has been argued that we should be consistent (bug 26658) so we might want to fix this. Unless there is some reason for it that I am not aware of?
Created attachment 146416 [details] [review] Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off
Created attachment 146417 [details] [review] Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: #! /usr/bin/perl This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off
Created attachment 146419 [details] [review] Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: #! /usr/bin/perl This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 146498 [details] [review] Bug 32922: Remove space in shebang Some of our scripts have a space in the "shebang" (first) line: #! /usr/bin/perl This is not illegal, and it does work, but it is good to be consistent, so this patch removes the space. To test: - Run: grep -rn --include=*.pl '#! /usr/' * - See the list of files that have a space in the shebang - Apply the patch - Run the command again, there should be no output, meaning there are no more files with space in the shebang - Have a look at the patch and check that it only changes the shebangs - Sign off Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 146499 [details] [review] Bug 32922: (follow-up) Fix two additional occurences Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Oops.. just spotted this was SO'd by Matt.. but I've gone through a QA process on it already. All working nicely and is a good general consistency improvement. Passing QA.. Tomas, feel free to push back for an independent QA if you want it .
Pushed to master for 23.05. Nice work everyone, thanks!
Created attachment 147193 [details] [review] Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off
Comment on attachment 147193 [details] [review] Bug 29449: Show userid on "Personal details" tab Wrong bug, sorry!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Does not apply to 22.05.x, no backport.