Bath item modification results present the user with a DataTable containing the results. Other tables in Koha can be exported, we should add that feature to this page
Created attachment 146691 [details] [review] Bug 32970: Use KohaTable for display of batch item modification results This patch updates the code to use KohaTables to provide export of the batch modification results. Additionally, searching is added, and the first two columns are made searchable To test: 1 - Perform a match item modification on several items 2 - View the results of the background job 3 - Apply patch 4 - Reload page 5 - Note you now have additional controls including 'search' and 'export' 6 - Test searching and exporting 7 - Confirm all work as expected
(In reply to Nick Clemens from comment #1) > Created attachment 146691 [details] [review] [review] > Bug 32970: Use KohaTable for display of batch item modification results > > This patch updates the code to use KohaTables to provide export of the > batch modification results. > > Additionally, searching is added, and the first two columns are made > searchable > > To test: > 1 - Perform a match item modification on several items > 2 - View the results of the background job > 3 - Apply patch > 4 - Reload page > 5 - Note you now have additional controls including 'search' and > 'export' > 6 - Test searching and exporting > 7 - Confirm all work as expected Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 147965 [details] [review] Bug 32970: Use KohaTable for display of batch item modification results This patch updates the code to use KohaTables to provide export of the batch modification results. Additionally, searching is added, and the first two columns are made searchable To test: 1 - Perform a match item modification on several items 2 - View the results of the background job 3 - Apply patch 4 - Reload page 5 - Note you now have additional controls including 'search' and 'export' 6 - Test searching and exporting 7 - Confirm all work as expected Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
I think we should include columns_settings.inc from includes/background_jobs/batch_item_record_modification.inc instead of admin/background_jobs.tt. Do you agree with that?
Created attachment 148950 [details] [review] Bug 32970: Use KohaTable for display of batch item modification results This patch updates the code to use KohaTables to provide export of the batch modification results. Additionally, searching is added, and the first two columns are made searchable To test: 1 - Perform a match item modification on several items 2 - View the results of the background job 3 - Apply patch 4 - Reload page 5 - Note you now have additional controls including 'search' and 'export' 6 - Test searching and exporting 7 - Confirm all work as expected Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 148951 [details] [review] Bug 32970: (follow-up) Move include to specific job file
Created attachment 149398 [details] [review] Bug 32970: Use KohaTable for display of batch item modification results This patch updates the code to use KohaTables to provide export of the batch modification results. Additionally, searching is added, and the first two columns are made searchable To test: 1 - Perform a match item modification on several items 2 - View the results of the background job 3 - Apply patch 4 - Reload page 5 - Note you now have additional controls including 'search' and 'export' 6 - Test searching and exporting 7 - Confirm all work as expected Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 149399 [details] [review] Bug 32970: (follow-up) Move include to specific job file Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Enhancement. Not pushing to 22.11.x.