Bug 32970 - Allow export of batch item modification results in background jobs
Summary: Allow export of batch item modification results in background jobs
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34225
  Show dependency treegraph
 
Reported: 2023-02-15 15:29 UTC by Nick Clemens
Modified: 2023-07-07 12:18 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00


Attachments
Bug 32970: Use KohaTable for display of batch item modification results (2.40 KB, patch)
2023-02-15 15:32 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32970: Use KohaTable for display of batch item modification results (2.47 KB, patch)
2023-03-08 16:19 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32970: Use KohaTable for display of batch item modification results (2.48 KB, patch)
2023-03-30 07:55 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32970: (follow-up) Move include to specific job file (1.51 KB, patch)
2023-03-30 07:55 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32970: Use KohaTable for display of batch item modification results (2.48 KB, patch)
2023-04-10 16:49 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32970: (follow-up) Move include to specific job file (1.56 KB, patch)
2023-04-10 16:49 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2023-02-15 15:29:52 UTC
Bath item modification results present the user with a DataTable containing the results. Other tables in Koha can be exported, we should add that feature to this page
Comment 1 Nick Clemens 2023-02-15 15:32:30 UTC Comment hidden (obsolete)
Comment 2 Laura Escamilla 2023-03-06 18:24:55 UTC
(In reply to Nick Clemens from comment #1)
> Created attachment 146691 [details] [review] [review]
> Bug 32970: Use KohaTable for display of batch item modification results
> 
> This patch updates the code to use KohaTables to provide export of the
> batch modification results.
> 
> Additionally, searching is added, and the first two columns are made
> searchable
> 
> To test:
> 1 - Perform a match item modification on several items
> 2 - View the results of the background job
> 3 - Apply patch
> 4 - Reload page
> 5 - Note you now have additional controls including 'search' and
>   'export'
> 6 - Test searching and exporting
> 7 - Confirm all work as expected

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 3 ByWater Sandboxes 2023-03-08 16:19:43 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2023-03-24 08:34:20 UTC
I think we should include columns_settings.inc from includes/background_jobs/batch_item_record_modification.inc instead of admin/background_jobs.tt. Do you agree with that?
Comment 5 Nick Clemens 2023-03-30 07:55:48 UTC Comment hidden (obsolete)
Comment 6 Nick Clemens 2023-03-30 07:55:51 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2023-04-10 16:49:36 UTC
Created attachment 149398 [details] [review]
Bug 32970: Use KohaTable for display of batch item modification results

This patch updates the code to use KohaTables to provide export of the
batch modification results.

Additionally, searching is added, and the first two columns are made
searchable

To test:
1 - Perform a match item modification on several items
2 - View the results of the background job
3 - Apply patch
4 - Reload page
5 - Note you now have additional controls including 'search' and
  'export'
6 - Test searching and exporting
7 - Confirm all work as expected

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 8 Katrin Fischer 2023-04-10 16:49:38 UTC
Created attachment 149399 [details] [review]
Bug 32970: (follow-up) Move include to specific job file

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi 2023-05-16 13:18:03 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Pedro Amorim 2023-06-07 10:38:14 UTC
Enhancement. Not pushing to 22.11.x.