Bug 34225 - KohaTable broken on batch item deletion and modification results
Summary: KohaTable broken on batch item deletion and modification results
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32970
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-07 12:18 UTC by Owen Leonard
Modified: 2023-07-18 15:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02


Attachments
Bug 34225: KohaTable broken on batch item deletion and modification results (2.81 KB, patch)
2023-07-07 12:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34225: KohaTable broken on batch item deletion and modification results (2.85 KB, patch)
2023-07-07 16:14 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34225: KohaTable broken on batch item deletion and modification results (2.91 KB, patch)
2023-07-09 14:18 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-07-07 12:18:43 UTC
Bug 32970 updated batchMod.js to use the columns_settings include and KohaTable to create the DataTable in background job results. However, batchMod.js is also used for the results view of batch item modification and batch item deletion. 

Without the addition of columns_settings.inc on these pages as well there is a JS error in the console and the tables are static.
Comment 1 Owen Leonard 2023-07-07 12:24:14 UTC
Created attachment 153171 [details] [review]
Bug 34225: KohaTable broken on batch item deletion and modification results

This patch adds the columns_settings include file to the batch item
modification and batch item deletion templates so that the tables can be
rendered as DataTables.

To test, apply the patch and go to Cataloging -> Batch item
modification.

- Submit a batch of barcodes or item numbers for modification.
- On the next page which shows all the items you submitted, the table
  should be rendered as a DataTable.
- Confirm that sorting, filtering, and export all work correctly.
- Confirm that there are not JS errors in the browser console.
- Perform the same tests on Cataloging -> Batch item deletion.
Comment 2 Sam Lau 2023-07-07 16:14:02 UTC
Created attachment 153190 [details] [review]
Bug 34225: KohaTable broken on batch item deletion and modification results

This patch adds the columns_settings include file to the batch item
modification and batch item deletion templates so that the tables can be
rendered as DataTables.

To test, apply the patch and go to Cataloging -> Batch item
modification.

- Submit a batch of barcodes or item numbers for modification.
- On the next page which shows all the items you submitted, the table
  should be rendered as a DataTable.
- Confirm that sorting, filtering, and export all work correctly.
- Confirm that there are not JS errors in the browser console.
- Perform the same tests on Cataloging -> Batch item deletion.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Katrin Fischer 2023-07-09 14:18:40 UTC
Created attachment 153222 [details] [review]
Bug 34225: KohaTable broken on batch item deletion and modification results

This patch adds the columns_settings include file to the batch item
modification and batch item deletion templates so that the tables can be
rendered as DataTables.

To test, apply the patch and go to Cataloging -> Batch item
modification.

- Submit a batch of barcodes or item numbers for modification.
- On the next page which shows all the items you submitted, the table
  should be rendered as a DataTable.
- Confirm that sorting, filtering, and export all work correctly.
- Confirm that there are not JS errors in the browser console.
- Perform the same tests on Cataloging -> Batch item deletion.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-07-14 18:24:23 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-07-18 11:52:32 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 6 Matt Blenkinsop 2023-07-18 15:23:32 UTC
Not backporting to 22.11.x - missing dependency 32970