Bug 32970 updated batchMod.js to use the columns_settings include and KohaTable to create the DataTable in background job results. However, batchMod.js is also used for the results view of batch item modification and batch item deletion. Without the addition of columns_settings.inc on these pages as well there is a JS error in the console and the tables are static.
Created attachment 153171 [details] [review] Bug 34225: KohaTable broken on batch item deletion and modification results This patch adds the columns_settings include file to the batch item modification and batch item deletion templates so that the tables can be rendered as DataTables. To test, apply the patch and go to Cataloging -> Batch item modification. - Submit a batch of barcodes or item numbers for modification. - On the next page which shows all the items you submitted, the table should be rendered as a DataTable. - Confirm that sorting, filtering, and export all work correctly. - Confirm that there are not JS errors in the browser console. - Perform the same tests on Cataloging -> Batch item deletion.
Created attachment 153190 [details] [review] Bug 34225: KohaTable broken on batch item deletion and modification results This patch adds the columns_settings include file to the batch item modification and batch item deletion templates so that the tables can be rendered as DataTables. To test, apply the patch and go to Cataloging -> Batch item modification. - Submit a batch of barcodes or item numbers for modification. - On the next page which shows all the items you submitted, the table should be rendered as a DataTable. - Confirm that sorting, filtering, and export all work correctly. - Confirm that there are not JS errors in the browser console. - Perform the same tests on Cataloging -> Batch item deletion. Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 153222 [details] [review] Bug 34225: KohaTable broken on batch item deletion and modification results This patch adds the columns_settings include file to the batch item modification and batch item deletion templates so that the tables can be rendered as DataTables. To test, apply the patch and go to Cataloging -> Batch item modification. - Submit a batch of barcodes or item numbers for modification. - On the next page which shows all the items you submitted, the table should be rendered as a DataTable. - Confirm that sorting, filtering, and export all work correctly. - Confirm that there are not JS errors in the browser console. - Perform the same tests on Cataloging -> Batch item deletion. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Not backporting to 22.11.x - missing dependency 32970