Bug 32984 - The EDIFACT message that receives an item should be linked on the 'Acquisition details' tab on catalogue details page
Summary: The EDIFACT message that receives an item should be linked on the 'Acquisitio...
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks: 34853
  Show dependency treegraph
 
Reported: 2023-02-16 15:12 UTC by Nick Clemens (kidclamp)
Modified: 2023-11-28 13:38 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
**Sponsored by** *PTFS Europe Ltd*
Version(s) released in:
23.11.00


Attachments
Bug 32984: Add link to EDI invoice to "Invoice" column if there is one (1.58 KB, patch)
2023-02-16 15:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 32984: Add link to EDI invoice to "Invoice" column if there is one (1.63 KB, patch)
2023-09-08 18:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 32984: (QA follow-up) Update to respect EDIFACT preference (1.40 KB, patch)
2023-09-08 19:02 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-02-16 15:12:01 UTC

    
Comment 1 Kyle M Hall 2023-02-16 15:36:11 UTC
Created attachment 146739 [details] [review]
Bug 32984: Add link to EDI invoice to "Invoice" column if there is one

Test Plan:
1) Find or create an item invoiced via an EDI INVOICE message
2) Ensure you have the edi_manage subpermission
3) View catalogue/detail.pl, not the invoice link in the invoice column
4) Apply this patch
5) Restart all the things!
6) Reload catalogue/detail.pl
7) Note the new "(EDI invoice)" link in the column for the item
8) Verify the link does not show if you do not have the edi_manage
   subpermission
Comment 2 Martin Renvoize 2023-09-08 18:55:22 UTC
Created attachment 155456 [details] [review]
Bug 32984: Add link to EDI invoice to "Invoice" column if there is one

Test Plan:
1) Find or create an item invoiced via an EDI INVOICE message
2) Ensure you have the edi_manage subpermission
3) View catalogue/detail.pl, not the invoice link in the invoice column
4) Apply this patch
5) Restart all the things!
6) Reload catalogue/detail.pl
7) Note the new "(EDI invoice)" link in the column for the item
8) Verify the link does not show if you do not have the edi_manage
   subpermission

Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2023-09-08 18:56:48 UTC
Trivial patch, tested and signed off by a customer of ptfs-europe.

I'm opting to QA as it's useful addition without risk of regressions.

QA scripts are happy and code is simple and working

Passing QA
Comment 4 Martin Renvoize 2023-09-08 19:02:23 UTC
Created attachment 155457 [details] [review]
Bug 32984: (QA follow-up) Update to respect EDIFACT preference

Since the first submission of this patch we have introduced a system
preference to enable/disable edifact in it's entirety. This patch adds
the check for this preference.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Jeremy Evans 2023-09-19 13:56:30 UTC
This is working well but it would be easier to read on the display if the EDI invoice link can start on a new line underneath the Invoice number. At the moment it makes the Invoice number harder to read.
Comment 6 Tomás Cohen Arazi 2023-09-19 19:35:21 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2023-09-20 15:51:09 UTC
Follow-up to take care of comment above added to new bug linked.

Bug 34853
Comment 8 Fridolin Somers 2023-09-21 06:20:32 UTC
Enhancement not pushed to 23.05.x