Bug 34853 - Move EDI link to new line in invoice column of acquisition details display
Summary: Move EDI link to new line in invoice column of acquisition details display
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Martin Renvoize
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on: 32984
Blocks:
  Show dependency treegraph
 
Reported: 2023-09-20 15:42 UTC by Martin Renvoize
Modified: 2024-02-27 10:47 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03


Attachments
Bug 34853: Add clearfix span to Invoice links (2.03 KB, patch)
2023-09-20 15:49 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34853: Add clearfix span to Invoice links (2.09 KB, patch)
2023-09-20 16:08 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 34853: Add clearfix span to Invoice links (2.09 KB, patch)
2024-01-16 17:13 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 34853: Switch to 'div' as suggested (2.15 KB, patch)
2024-01-16 17:13 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-09-20 15:42:45 UTC
A late piece of feedback came in on bug 32984 just as it was being pushed.

>This is working well but it would be easier to read on the display if the EDI invoice link can start on a new line underneath the Invoice number. At the moment it makes the Invoice number harder to read.
Comment 1 Martin Renvoize 2023-09-20 15:49:20 UTC
Created attachment 155953 [details] [review]
Bug 34853: Add clearfix span to Invoice links

This patch adds a clearfix span around the invoicenumber and EDI message
display texts which should result in them each having their own line.
Comment 2 Kyle M Hall 2023-09-20 16:08:49 UTC
Created attachment 155954 [details] [review]
Bug 34853: Add clearfix span to Invoice links

This patch adds a clearfix span around the invoicenumber and EDI message
display texts which should result in them each having their own line.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Victor Grousset/tuxayo 2023-09-27 02:13:29 UTC
Hi, I know nothing about EDI, does the test plan of Bug 28640 helps?

I'm trying to get «1) Find or create an item invoiced via an EDI INVOICE message» from bug 32984's test plan.

But when looking at Bug 28640, this doesn't go as expected:

> 5/ The 'EDI status' should continue to display 'Not ordered'
> 6/ Re-open the basket
> 7/ Close the basket via 'Create EDIFACT order'

I have my vendor with a (too?) minimally filled EDI account. (orders and invoices enabled). And a minimally filled EAN for all libraries.

Maybe this doesn't make any sense this ticket.
Comment 4 Victor Grousset/tuxayo 2023-09-27 02:19:26 UTC
> 7/ Close the basket via 'Create EDIFACT order'

oops, missed the steps that actually block me:

> 8/ Navigate back to the now closed basket
> 9/ Note the 'EDI status' field now displays 'Pending' and the transfer
date.

Still 'Not ordered'
Comment 5 Katrin Fischer 2023-09-29 12:23:58 UTC
A test plan or some test data to quickly import would be great. 

After talking to Owen: why not simply use a div instead of the span? (no class needed)
Comment 6 Martin Renvoize 2023-11-14 21:48:29 UTC
I used a span with clearfix as that's three interface pattern is seen to date for this.
Comment 7 Martin Renvoize 2023-11-14 21:53:40 UTC
This was also meant to be a tiny and quick follow up to the previous bug.
Comment 8 Martin Renvoize 2024-01-16 17:13:18 UTC
Created attachment 161069 [details] [review]
Bug 34853: Add clearfix span to Invoice links

This patch adds a clearfix span around the invoicenumber and EDI message
display texts which should result in them each having their own line.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Martin Renvoize 2024-01-16 17:13:21 UTC
Created attachment 161070 [details] [review]
Bug 34853: Switch to 'div' as suggested

This patch switches us from '<span class="clearfix">' to '<div>' so
we're just using a block level elemenet instead of manipulating an
inline element to act like a block.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Katrin Fischer 2024-01-29 11:28:27 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 11 Fridolin Somers 2024-02-01 15:07:47 UTC
Pushed to 23.11.x for 23.11.03