Bug 32998 - Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib
Summary: Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32969
Blocks: 34093
  Show dependency treegraph
 
Reported: 2023-02-17 15:39 UTC by Owen Leonard
Modified: 2023-06-22 11:02 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00


Attachments
Bug 32998: Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib (563.02 KB, patch)
2023-02-17 17:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32998: Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib (563.07 KB, patch)
2023-03-29 11:28 UTC, Philip Orr
Details | Diff | Splinter Review
Bug 32998: Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib (563.13 KB, patch)
2023-04-09 11:24 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-02-17 15:39:58 UTC
We have both opac-tmpl/lib and opac-tmpl/bootstrap/lib. Each one has various third-party assets which are used in the OPAC. Since these assets do not need to be in a place where the translation tools can access them we should put them together in opac-tmpl/lib.
Comment 1 Owen Leonard 2023-02-17 17:22:48 UTC
Created attachment 146897 [details] [review]
Bug 32998: Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib

This patch moves OPAC third-party assets from opac-tmpl/bootstrap/lib
to opac-tmpl/lib, eliminating some redundancy and making it simpler
to understand where such assets should be found.

To test, apply the patch and confirm that there is no longer a lib
directory under opac-tmpl/bootstrap.

Test various parts of the OPAC to confirm that assets are still loading
correctly. Everything should look right and work correctly. The
browser's developer console should be free of errors.
Comment 2 Philip Orr 2023-03-29 11:28:14 UTC
Created attachment 148902 [details] [review]
Bug 32998: Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib

This patch moves OPAC third-party assets from opac-tmpl/bootstrap/lib
to opac-tmpl/lib, eliminating some redundancy and making it simpler
to understand where such assets should be found.

To test, apply the patch and confirm that there is no longer a lib
directory under opac-tmpl/bootstrap.

Test various parts of the OPAC to confirm that assets are still loading
correctly. Everything should look right and work correctly. The
browser's developer console should be free of errors.

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Comment 3 Katrin Fischer 2023-04-09 11:24:51 UTC
Created attachment 149349 [details] [review]
Bug 32998: Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib

This patch moves OPAC third-party assets from opac-tmpl/bootstrap/lib
to opac-tmpl/lib, eliminating some redundancy and making it simpler
to understand where such assets should be found.

To test, apply the patch and confirm that there is no longer a lib
directory under opac-tmpl/bootstrap.

Test various parts of the OPAC to confirm that assets are still loading
correctly. Everything should look right and work correctly. The
browser's developer console should be free of errors.

Signed-off-by: Philip Orr <philip.orr@lmscloud.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-13 14:49:19 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-04-17 09:15:35 UTC
Enhancement - not backporting to 22.11.x

Nice work everyone!