Bug 32969 - Remove references to jQueryUI assets and style in the OPAC
Summary: Remove references to jQueryUI assets and style in the OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30570 33031
Blocks: 29222 32998
  Show dependency treegraph
 
Reported: 2023-02-15 15:25 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 32969: Remove references to jQueryUI assets and style in the OPAC (65.42 KB, patch)
2023-02-15 15:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32969: (follow-up) Remove obsolete inline CSS (1.98 KB, patch)
2023-02-23 20:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32969: Remove references to jQueryUI assets and style in the OPAC (65.48 KB, patch)
2023-02-23 21:02 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32969: (follow-up) Remove obsolete inline CSS (2.03 KB, patch)
2023-02-23 21:02 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32969: Remove references to jQueryUI assets and style in the OPAC (65.57 KB, patch)
2023-03-24 16:31 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 32969: (follow-up) Remove obsolete inline CSS (2.09 KB, patch)
2023-03-24 16:31 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-02-15 15:25:15 UTC
Now that we've updated the OPAC to use Bootstrap tabs, tooltips, etc, we can remove jQueryUI assets and portions of our CSS which were only relevant to jQueryUI elements.
Comment 1 Owen Leonard 2023-02-15 15:44:05 UTC
Created attachment 146692 [details] [review]
Bug 32969: Remove references to jQueryUI assets and style in the OPAC

This patch removes the jQueryUI assets from Bootstrap OPAC files and
removes the links to those assets from the templates. References in CSS
to jQueryUI-related elements are also removed.

To test, apply the patch and rebuild the OPAC CSS.

Test various pages in the OPAC to confirm that there are no visible
changes. The browser console should not warn of missing files.
Comment 2 Katrin Fischer 2023-02-20 21:38:28 UTC
I found some remaining references ui-tabs:

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt:    ul.ui-tabs-nav li a, ul.ui-tabs-nav li span.a  { padding:0.6em 1em; }
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt:    <style>ul.ui-tabs-nav li a, ul.ui-tabs-nav li span.a  { padding:0.6em 1em; }</style>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                        <div class="toptabs ui-tabs ui-widget ui-widget-content ui-corner-all">
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                            <ul class="ui-tabs-nav ui-helper-reset ui-helper-clearfix ui-widget-header ui-corner-all">
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                                        <li id="privateshelves_tab" class="ui-state-default ui-corner-top ui-tabs-active ui-state-active"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&amp;public=0">Your lists</a></li>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                                        <li id="privateshelves_tab" class="ui-state-default ui-corner-top"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&amp;public=0">Your lists</a></li>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                                    <li id="publicshelves_tab" class="ui-state-default ui-corner-top ui-tabs-active ui-state-active"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&amp;public=1">Public lists</a></li>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                                    <li id="publicshelves_tab" class="ui-state-default ui-corner-top"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&amp;public=1">Public lists</a></li>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                                <div id="privateshelves" class="ui-tabs-panel ui-widget-content ui-corner-bottom" style="display:block;">
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:                                <div id="publicshelves" class="ui-tabs-panel ui-widget-content ui-corner-bottom" style="display:block;">

Did we miss a patch maybe?

I did run the yarn build, but with the patch applied, the list view (list of lists) is indeed broken.
Comment 3 Owen Leonard 2023-02-23 20:46:10 UTC
Created attachment 147263 [details] [review]
Bug 32969: (follow-up) Remove obsolete inline CSS

A couple of templates have some inline CSS intended to style jQueryUI
tabs. These instances can be removed:

- opac-readingrecord.tt: Tabs have been replaced with Bootstrap.
- opac-idref.tt: There doens't appear to be any tab-related markup in
  the template at all.
Comment 4 Katrin Fischer 2023-02-23 21:02:33 UTC
Created attachment 147266 [details] [review]
Bug 32969: Remove references to jQueryUI assets and style in the OPAC

This patch removes the jQueryUI assets from Bootstrap OPAC files and
removes the links to those assets from the templates. References in CSS
to jQueryUI-related elements are also removed.

To test, apply the patch and rebuild the OPAC CSS.

Test various pages in the OPAC to confirm that there are no visible
changes. The browser console should not warn of missing files.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-02-23 21:02:36 UTC
Created attachment 147267 [details] [review]
Bug 32969: (follow-up) Remove obsolete inline CSS

A couple of templates have some inline CSS intended to style jQueryUI
tabs. These instances can be removed:

- opac-readingrecord.tt: Tabs have been replaced with Bootstrap.
- opac-idref.tt: There doens't appear to be any tab-related markup in
  the template at all.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Kyle M Hall 2023-03-24 16:31:13 UTC
Created attachment 148677 [details] [review]
Bug 32969: Remove references to jQueryUI assets and style in the OPAC

This patch removes the jQueryUI assets from Bootstrap OPAC files and
removes the links to those assets from the templates. References in CSS
to jQueryUI-related elements are also removed.

To test, apply the patch and rebuild the OPAC CSS.

Test various pages in the OPAC to confirm that there are no visible
changes. The browser console should not warn of missing files.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Kyle M Hall 2023-03-24 16:31:19 UTC
Created attachment 148678 [details] [review]
Bug 32969: (follow-up) Remove obsolete inline CSS

A couple of templates have some inline CSS intended to style jQueryUI
tabs. These instances can be removed:

- opac-readingrecord.tt: Tabs have been replaced with Bootstrap.
- opac-idref.tt: There doens't appear to be any tab-related markup in
  the template at all.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi 2023-03-27 10:06:22 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Matt Blenkinsop 2023-04-11 09:01:47 UTC
Nice work everyone!

Pushed to stable for 22.11.x