Now that we've updated the OPAC to use Bootstrap tabs, tooltips, etc, we can remove jQueryUI assets and portions of our CSS which were only relevant to jQueryUI elements.
Created attachment 146692 [details] [review] Bug 32969: Remove references to jQueryUI assets and style in the OPAC This patch removes the jQueryUI assets from Bootstrap OPAC files and removes the links to those assets from the templates. References in CSS to jQueryUI-related elements are also removed. To test, apply the patch and rebuild the OPAC CSS. Test various pages in the OPAC to confirm that there are no visible changes. The browser console should not warn of missing files.
I found some remaining references ui-tabs: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt: ul.ui-tabs-nav li a, ul.ui-tabs-nav li span.a { padding:0.6em 1em; } koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt: <style>ul.ui-tabs-nav li a, ul.ui-tabs-nav li span.a { padding:0.6em 1em; }</style> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <div class="toptabs ui-tabs ui-widget ui-widget-content ui-corner-all"> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <ul class="ui-tabs-nav ui-helper-reset ui-helper-clearfix ui-widget-header ui-corner-all"> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <li id="privateshelves_tab" class="ui-state-default ui-corner-top ui-tabs-active ui-state-active"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=0">Your lists</a></li> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <li id="privateshelves_tab" class="ui-state-default ui-corner-top"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=0">Your lists</a></li> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <li id="publicshelves_tab" class="ui-state-default ui-corner-top ui-tabs-active ui-state-active"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=1">Public lists</a></li> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <li id="publicshelves_tab" class="ui-state-default ui-corner-top"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=1">Public lists</a></li> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <div id="privateshelves" class="ui-tabs-panel ui-widget-content ui-corner-bottom" style="display:block;"> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <div id="publicshelves" class="ui-tabs-panel ui-widget-content ui-corner-bottom" style="display:block;"> Did we miss a patch maybe? I did run the yarn build, but with the patch applied, the list view (list of lists) is indeed broken.
Created attachment 147263 [details] [review] Bug 32969: (follow-up) Remove obsolete inline CSS A couple of templates have some inline CSS intended to style jQueryUI tabs. These instances can be removed: - opac-readingrecord.tt: Tabs have been replaced with Bootstrap. - opac-idref.tt: There doens't appear to be any tab-related markup in the template at all.
Created attachment 147266 [details] [review] Bug 32969: Remove references to jQueryUI assets and style in the OPAC This patch removes the jQueryUI assets from Bootstrap OPAC files and removes the links to those assets from the templates. References in CSS to jQueryUI-related elements are also removed. To test, apply the patch and rebuild the OPAC CSS. Test various pages in the OPAC to confirm that there are no visible changes. The browser console should not warn of missing files. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 147267 [details] [review] Bug 32969: (follow-up) Remove obsolete inline CSS A couple of templates have some inline CSS intended to style jQueryUI tabs. These instances can be removed: - opac-readingrecord.tt: Tabs have been replaced with Bootstrap. - opac-idref.tt: There doens't appear to be any tab-related markup in the template at all. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 148677 [details] [review] Bug 32969: Remove references to jQueryUI assets and style in the OPAC This patch removes the jQueryUI assets from Bootstrap OPAC files and removes the links to those assets from the templates. References in CSS to jQueryUI-related elements are also removed. To test, apply the patch and rebuild the OPAC CSS. Test various pages in the OPAC to confirm that there are no visible changes. The browser console should not warn of missing files. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 148678 [details] [review] Bug 32969: (follow-up) Remove obsolete inline CSS A couple of templates have some inline CSS intended to style jQueryUI tabs. These instances can be removed: - opac-readingrecord.tt: Tabs have been replaced with Bootstrap. - opac-idref.tt: There doens't appear to be any tab-related markup in the template at all. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x