To continue the process started by Bug 32507, this patch will update more templates in acquisitions so that they use the new template wrapper for breadcrumbs. - newordersuggestion.tt - ordered.tt - orderreceive.tt - parcel.tt - parcels.tt - spent.tt - supplier.tt - uncertainprice.tt - z3950_search.tt
Created attachment 146922 [details] [review] Bug 33005: Use template wrapper for breadcrumbs: Acquisitions part 3 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions -> -> All available funds table -> Ordered -> Spent -> Vendor -> Vendor details -> Uncertain prices -> Receive shipments (must have at least one open basket) -> If necessary, receive a new shipment. Or click an invoice number to reach the "receive orders" page. -> Click "Receive" in the table listing baskets. -> Basket -> Add to basket -> From a suggestion -> From an external source
Created attachment 147323 [details] [review] Bug 33005: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span>
Created attachment 149241 [details] [review] Bug 33005: Use template wrapper for breadcrumbs: Acquisitions part 3 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions -> -> All available funds table -> Ordered -> Spent -> Vendor -> Vendor details -> Uncertain prices -> Receive shipments (must have at least one open basket) -> If necessary, receive a new shipment. Or click an invoice number to reach the "receive orders" page. -> Click "Receive" in the table listing baskets. -> Basket -> Add to basket -> From a suggestion -> From an external source Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Created attachment 149242 [details] [review] Bug 33005: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
All pages and links checked. Lovely!
Created attachment 149340 [details] [review] Bug 33005: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 149341 [details] [review] Bug 33005: (QA follow-up) Update breadcrumb when editing a vendor When editing a vendor the last part of the breadcrumbs read: Update: <vendor> This is very unusual, so updated to the standard wording: Modify <vendor> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 149342 [details] [review] Bug 33005: Use template wrapper for breadcrumbs: Acquisitions part 3 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions -> -> All available funds table -> Ordered -> Spent -> Vendor -> Vendor details -> Uncertain prices -> Receive shipments (must have at least one open basket) -> If necessary, receive a new shipment. Or click an invoice number to reach the "receive orders" page. -> Click "Receive" in the table listing baskets. -> Basket -> Add to basket -> From a suggestion -> From an external source Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Created attachment 149343 [details] [review] Bug 33005: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 149344 [details] [review] Bug 33005: (QA follow-up) Update breadcrumb when editing a vendor When editing a vendor the last part of the breadcrumbs read: Update: <vendor> This is very unusual, so updated to the standard wording: Modify <vendor> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 149345 [details] [review] Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions -> - Late orders, - moddeliverydate.tt - modordernotes.tt -- These two templates aren't linked to from anywhere, but you can navigate directly to: http://127.0.0.1:8081/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=X and http://127.0.0.1:8081/cgi-bin/koha/acqui/moddeliverydate.pl?ordernumber=1 - Order search, order search results - Invoice search, - Invoice details, - Invoice files - Vendor -> Basket -> Add to basket -> - From a new (empty) record - From existing orders (copy) - From a subscription Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 149346 [details] [review] Bug 33001: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.