Bug 33031 - Update OPAC lists page to use Bootstrap markup for tabs
Summary: Update OPAC lists page to use Bootstrap markup for tabs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 32969
  Show dependency tree / graph
 
Reported: 2023-02-21 19:41 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Circulation function:

Attachments
Bug 33031: Update OPAC lists page to use Bootstrap markup for tabs (20.01 KB, patch)
2023-02-21 20:00 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 33031: Update OPAC lists page to use Bootstrap markup for tabs (20.07 KB, patch)
2023-02-22 09:17 UTC, Jacob O'Mara 		Details | Diff | Splinter Review
Bug 33031: Update OPAC lists page to use Bootstrap markup for tabs (20.12 KB, patch)
2023-02-23 20:53 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-02-21 19:41:43 UTC 
The OPAC's lists page (specifically, the list of lists view) uses jQueryUI markup to display tabs, which I missed in my round of Bootstrap tab updates because they're not triggered by JavaScript. We can replace the markup with Bootstrap.
Comment 1 Owen Leonard 2023-02-21 20:00:02 UTC 
Created attachment 147086 [details] [review]
Bug 33031: Update OPAC lists page to use Bootstrap markup for tabs

This patch updates the OPAC lists page with Bootstrap markup for the
static tabs used to link to private and public shelves. These tabs are
not dependent on JavaScript.

To test, apply the patch and click "Lists" -> "Public lists" in the
OPAC. The "Your lists" and "Public lists" tabs should look correct, and
each should link to the correct view.
Comment 2 Jacob O'Mara 2023-02-22 09:17:09 UTC 
Created attachment 147112 [details] [review]
Bug 33031: Update OPAC lists page to use Bootstrap markup for tabs

This patch updates the OPAC lists page with Bootstrap markup for the
static tabs used to link to private and public shelves. These tabs are
not dependent on JavaScript.

To test, apply the patch and click "Lists" -> "Public lists" in the
OPAC. The "Your lists" and "Public lists" tabs should look correct, and
each should link to the correct view.

Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-02-23 20:53:32 UTC 
Created attachment 147265 [details] [review]
Bug 33031: Update OPAC lists page to use Bootstrap markup for tabs

This patch updates the OPAC lists page with Bootstrap markup for the
static tabs used to link to private and public shelves. These tabs are
not dependent on JavaScript.

To test, apply the patch and click "Lists" -> "Public lists" in the
OPAC. The "Your lists" and "Public lists" tabs should look correct, and
each should link to the correct view.

Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-03-10 14:15:05 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-03-10 16:37:24 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass (lukeg) 2023-04-14 16:28:10 UTC 
Enhancement will not be backported to 22.05.x