Bug 33032 - Alternate holdings broken in staff interface search results
Summary: Alternate holdings broken in staff interface search results
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords: regression
Depends on:
Blocks: 33509
  Show dependency treegraph
 
Reported: 2023-02-21 20:02 UTC by Fridolin Somers
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11,21.11.19
Circulation function:


Attachments
Bug 33032: Fix alternate holdings in staff interface search results (1.68 KB, patch)
2023-02-21 20:06 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 33032: Fix alternate holdings in staff interface search results (1.74 KB, patch)
2023-02-21 21:11 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 33032: Fix alternate holdings in staff interface search results (1.81 KB, patch)
2023-02-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33032: Remove alternateholdings_count (2.23 KB, patch)
2023-02-23 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-02-21 20:02:22 UTC
If system preference AlternateHoldingsField is used, one can see a display in OPAC search results.
This display does not appear in staff interface search results anymore.
Comment 1 Fridolin Somers 2023-02-21 20:06:56 UTC
Created attachment 147087 [details] [review]
Bug 33032: Fix alternate holdings in staff interface search results

If system preference AlternateHoldingsField is used, one can see a display in OPAC search results.
This display does not appear in staff interface search results anymore.

Test plan :
1) Enable feature with system preference 'AlternateHoldingsField', ie 852abc
2) Edit a record to add some datas in field 852
3) Perform a search in staff interface
=> You see the alternate holdings datas
Comment 2 Lucas Gass (lukeg) 2023-02-21 21:11:31 UTC
Created attachment 147097 [details] [review]
Bug 33032: Fix alternate holdings in staff interface search results

If system preference AlternateHoldingsField is used, one can see a display in OPAC search results.
This display does not appear in staff interface search results anymore.

Test plan :
1) Enable feature with system preference 'AlternateHoldingsField', ie 852abc
2) Edit a record to add some datas in field 852
3) Perform a search in staff interface
=> You see the alternate holdings datas

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2023-02-23 14:52:20 UTC
Created attachment 147247 [details] [review]
Bug 33032: Fix alternate holdings in staff interface search results

If system preference AlternateHoldingsField is used, one can see a display in OPAC search results.
This display does not appear in staff interface search results anymore.

Test plan :
1) Enable feature with system preference 'AlternateHoldingsField', ie 852abc
2) Edit a record to add some datas in field 852
3) Perform a search in staff interface
=> You see the alternate holdings datas

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2023-02-23 14:52:23 UTC
Created attachment 147248 [details] [review]
Bug 33032: Remove alternateholdings_count

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2023-02-23 14:52:38 UTC
Looks like it has been broken for years!
Comment 6 Tomás Cohen Arazi (tcohen) 2023-02-27 14:42:48 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-03-01 09:32:35 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass (lukeg) 2023-03-10 14:10:01 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 9 Arthur Suzuki 2023-03-29 12:56:56 UTC
applied to 21.11 for 21.11.19
Comment 10 Katrin Fischer 2023-04-12 17:09:14 UTC
With this patch in 22.11.04 we now show "Other holdings" in the staff interface result list, when the alternate holdings field is not present in the record.

Before this patch we showed "No items", which is correct.
Comment 11 Katrin Fischer 2023-04-12 17:13:36 UTC
(In reply to Katrin Fischer from comment #10)
> With this patch in 22.11.04 we now show "Other holdings" in the staff
> interface result list, when the alternate holdings field is not present in
> the record.
> 
> Before this patch we showed "No items", which is correct.

Filed as bug 33509
Comment 12 Wainui Witika-Park 2023-04-27 05:34:11 UTC
Not backported to 21.05.x