Bug 33509 - Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings
Summary: Staff search result list shows "other holdings" with AlternateHoldingsField w...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 33032
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-12 17:10 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05,22.05.13,21.11.21


Attachments
Bug 33509: Don't show Other holdings when there are no alternate holdings (2.01 KB, patch)
2023-04-12 20:01 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33509: Don't show Other holdings when there are no alternate holdings (2.06 KB, patch)
2023-04-13 17:26 UTC, David Nind
Details | Diff | Splinter Review
Bug 33509: Don't show Other holdings when there are no alternate holdings (2.15 KB, patch)
2023-04-14 06:29 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-12 17:10:44 UTC
With bug 33032 in 22.11.04 we now show "Other holdings" in the staff interface result list, when the alternate holdings field is not present in the record.

Before this patch we showed "No items", which is correct in this case.
Comment 1 Katrin Fischer 2023-04-12 20:01:53 UTC
Created attachment 149575 [details] [review]
Bug 33509: Don't show Other holdings when there are no alternate holdings

With bug 33509 alternate holdings defined in AlternateHoldingsField
are shown in the staff interface result list. This works greatly
when there are items or when there is are alternate holdings (the
configured field/subfields exist in the record), but not when there
are no items and no alternate holdings.

To test:
* Add 100a to AlternateHoldingsField
* Make a search with some records without items
  Sample data: perl
* Make sure the alternate holdings show when there are no items
  and 100a exists
* Change to 100z
* Verify the result list now shows "Other holdings:" with nothing below
* Apply patch
* Repeat
  * Alternate holdings should still show nicely
  * Without alternate holdings 'no items' is displayed
Comment 2 David Nind 2023-04-13 17:26:53 UTC
Created attachment 149616 [details] [review]
Bug 33509: Don't show Other holdings when there are no alternate holdings

With bug 33509 alternate holdings defined in AlternateHoldingsField
are shown in the staff interface result list. This works greatly
when there are items or when there is are alternate holdings (the
configured field/subfields exist in the record), but not when there
are no items and no alternate holdings.

To test:
* Add 100a to AlternateHoldingsField
* Make a search with some records without items
  Sample data: perl
* Make sure the alternate holdings show when there are no items
  and 100a exists
* Change to 100z
* Verify the result list now shows "Other holdings:" with nothing below
* Apply patch
* Repeat
  * Alternate holdings should still show nicely
  * Without alternate holdings 'no items' is displayed

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2023-04-14 06:29:29 UTC
Created attachment 149639 [details] [review]
Bug 33509: Don't show Other holdings when there are no alternate holdings

With bug 33509 alternate holdings defined in AlternateHoldingsField
are shown in the staff interface result list. This works greatly
when there are items or when there is are alternate holdings (the
configured field/subfields exist in the record), but not when there
are no items and no alternate holdings.

To test:
* Add 100a to AlternateHoldingsField
* Make a search with some records without items
  Sample data: perl
* Make sure the alternate holdings show when there are no items
  and 100a exists
* Change to 100z
* Verify the result list now shows "Other holdings:" with nothing below
* Apply patch
* Repeat
  * Alternate holdings should still show nicely
  * Without alternate holdings 'no items' is displayed

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi 2023-04-14 14:36:24 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-04-18 12:20:02 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass 2023-05-05 22:27:03 UTC
Backported to 22.05.x for upcoming 22.05.13
Comment 7 Arthur Suzuki 2023-05-23 12:22:48 UTC
applied to 21.11 for 21.11.21