Bug 33066 - We need a KohaTable Vue component
Summary: We need a KohaTable Vue component
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on: 32991
Blocks: 35919 32607 33483 33529 33705 33973
  Show dependency treegraph
 
Reported: 2023-02-24 16:15 UTC by Jonathan Druart
Modified: 2024-01-26 13:50 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33066: Introduce a KohaTable Vue component (52.39 KB, patch)
2023-02-24 16:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix dt - no need to reselect (1.01 KB, patch)
2023-02-24 16:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Add colvis (3.82 KB, patch)
2023-02-24 16:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Introduce a KohaTable Vue component (52.79 KB, patch)
2023-03-03 13:13 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 33066: Fix dt - no need to reselect (1.01 KB, patch)
2023-03-03 13:13 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 33066: Add colvis (3.82 KB, patch)
2023-03-03 13:13 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 33066: Fix search by vendor (21.58 KB, patch)
2023-03-03 16:18 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 33066: Fix "Loading..." (1.16 KB, patch)
2023-03-07 14:44 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Reintroduce column filters (6.56 KB, patch)
2023-03-07 14:44 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix name display (1.31 KB, patch)
2023-03-07 14:44 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Remove build_datatable (14.32 KB, patch)
2023-03-07 14:44 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Embed vendor and retrieve vendor name from the request (2.51 KB, patch)
2023-03-07 14:44 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Remove duplicate 'Actions' column (1.17 KB, patch)
2023-03-07 15:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix default_search (1.26 KB, patch)
2023-03-07 15:28 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix default_filters (1.24 KB, patch)
2023-03-07 15:33 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix ColVis (1.27 KB, patch)
2023-03-07 15:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix width after ColVis change (1.04 KB, patch)
2023-03-07 15:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix agreement name in delete confirmation dialog (1.79 KB, patch)
2023-03-07 15:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for LicensesList (19.02 KB, patch)
2023-03-07 16:04 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for LicensesList (19.07 KB, patch)
2023-03-07 16:37 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Restore HTML escaping (3.79 KB, patch)
2023-03-07 16:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Introduce a KohaTable Vue component (52.84 KB, patch)
2023-03-08 12:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix dt - no need to reselect (1.01 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Add colvis (3.82 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix "Loading..." (1.16 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Reintroduce column filters (6.56 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix name display (1.31 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Remove build_datatable (14.70 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Embed vendor and retrieve vendor name from the request (2.51 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Remove duplicate 'Actions' column (1.17 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix default_search (1.26 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix default_filters (1.24 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix ColVis (1.27 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix width after ColVis change (1.04 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix agreement name in delete confirmation dialog (1.79 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for LicensesList (19.07 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Restore HTML escaping (3.79 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Restore filter by mine (3.05 KB, patch)
2023-03-08 12:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsLocalPackagesList (18.60 KB, patch)
2023-03-08 13:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsLocalPackageTitlesList (7.73 KB, patch)
2023-03-08 13:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix style - FIXME (1.63 KB, patch)
2023-03-08 13:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsLocalTitlePackagesList (5.56 KB, patch)
2023-03-08 13:32 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsLocalPackagesList (18.57 KB, patch)
2023-03-08 13:36 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsLocalTitlesList (18.83 KB, patch)
2023-03-08 14:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: (follow-up) Use KohaTable for EHoldingsLocalTitlePackagesList (2.67 KB, patch)
2023-03-08 14:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsEBSCOPackagesList (14.13 KB, patch)
2023-03-08 14:58 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Restore '(#id)' to lists (3.18 KB, patch)
2023-03-08 18:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33066: Fix agreements and licenses cypress tests (2.12 KB, patch)
2023-03-08 18:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33066: Fix table style (4.76 KB, patch)
2023-03-26 10:55 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33066: Introduce a KohaTable Vue component (53.41 KB, patch)
2023-04-05 07:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix dt - no need to reselect (1.37 KB, patch)
2023-04-05 07:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Add colvis (4.02 KB, patch)
2023-04-05 07:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix "Loading..." (1.37 KB, patch)
2023-04-05 07:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Reintroduce column filters (6.77 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix name display (1.51 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Remove build_datatable (14.90 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Embed vendor and retrieve vendor name from the request (3.37 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Remove duplicate 'Actions' column (1.38 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix default_search (1.46 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix default_filters (1.44 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix ColVis (1.47 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix width after ColVis change (1.24 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for LicensesList (20.56 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Restore HTML escaping (3.99 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Restore filter by mine (3.25 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsLocalPackagesList (19.50 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsLocalPackageTitlesList (7.93 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsLocalTitlesList (19.01 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsEBSCOPackagesList (14.47 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Restore '(#id)' to lists (3.38 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsEBSCOPackageTitlesList (11.37 KB, patch)
2023-04-05 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Use KohaTable for EHoldingsEBSCOTitlesList (16.13 KB, patch)
2023-04-05 07:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Remove useless use of useDataTable (5.07 KB, patch)
2023-04-05 07:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix cypress tests (1.47 KB, patch)
2023-04-05 07:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33066: Fix table style (5.41 KB, patch)
2023-04-05 07:23 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-02-24 16:15:19 UTC
The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there.

When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now.
Comment 1 Jonathan Druart 2023-02-24 16:19:23 UTC
Created attachment 147352 [details] [review]
Bug 33066: Introduce a KohaTable Vue component

The way we deal with DataTables in Vue component is not nice, especially when we
need to add buttons/link in the cell and interact with the rest of the Vue app from
there.

When I started to work on Vue last year there was no good solution from DataTables,
now there is a Vue component. It is not perfect, you still cannot add Vue component
in the DT component, but it brings something to follow. Agustin implemented something
on theke/import_source_vue, but he went too far, and it will need to rewrite the
whole ERM module. Additionally he didn't provide a solution that has the same features
as what we have now.

The goal of this patch is to not duplicate the code in datatables.js, we
don't want to maintain two version of this code (one is enough already!)
We split the huge function in datatables.js in small ones to make them
reusable from the Vue component.

This is quite ugly, and it needs to lot more addition, but it's a first
start!

Help, ideas, and feedback welcome (and needed!)
Comment 2 Jonathan Druart 2023-02-24 16:19:26 UTC
Created attachment 147353 [details] [review]
Bug 33066: Fix dt - no need to reselect
Comment 3 Jonathan Druart 2023-02-24 16:19:29 UTC
Created attachment 147354 [details] [review]
Bug 33066: Add colvis
Comment 4 Jonathan Druart 2023-02-24 16:22:38 UTC
still needs to be done:
* column filter needs to be dropdown list when needed (see preDrawCallback in AgreementsList.vue)
* Remove useless code from AgreementsList.vue
* Fix UI display when using ColVis
* Improve "actions", it's really not nice how it's done (the -1 especifically)
* Confirm default_search is working
* Confirm default_filters is working
Comment 5 Agustín Moyano 2023-02-24 17:28:54 UTC
Hi Jonathan!, Great, I'll take a look at this as soon as I can.

Thanks
Comment 6 Agustín Moyano 2023-03-03 13:13:13 UTC
Created attachment 147692 [details] [review]
Bug 33066: Introduce a KohaTable Vue component

The way we deal with DataTables in Vue component is not nice, especially when we
need to add buttons/link in the cell and interact with the rest of the Vue app from
there.

When I started to work on Vue last year there was no good solution from DataTables,
now there is a Vue component. It is not perfect, you still cannot add Vue component
in the DT component, but it brings something to follow. Agustin implemented something
on theke/import_source_vue, but he went too far, and it will need to rewrite the
whole ERM module. Additionally he didn't provide a solution that has the same features
as what we have now.

The goal of this patch is to not duplicate the code in datatables.js, we
don't want to maintain two version of this code (one is enough already!)
We split the huge function in datatables.js in small ones to make them
reusable from the Vue component.

This is quite ugly, and it needs to lot more addition, but it's a first
start!

Help, ideas, and feedback welcome (and needed!)
Comment 7 Agustín Moyano 2023-03-03 13:13:16 UTC
Created attachment 147693 [details] [review]
Bug 33066: Fix dt - no need to reselect
Comment 8 Agustín Moyano 2023-03-03 13:13:18 UTC
Created attachment 147694 [details] [review]
Bug 33066: Add colvis
Comment 9 Agustín Moyano 2023-03-03 14:23:20 UTC
When I fixed the dependency from bug 23991 to bug 32991 patches no longer applied, so I rebased it.

The little code I could see it's ok and works as expected.
Comment 10 Agustín Moyano 2023-03-03 16:18:39 UTC
Created attachment 147713 [details] [review]
Bug 33066: Fix search by vendor
Comment 11 Jonathan Druart 2023-03-07 13:04:22 UTC
(In reply to Agustín Moyano from comment #10)
> Created attachment 147713 [details] [review] [review]
> Bug 33066: Fix search by vendor

Can you detail a bit?

This is not working as expected: the empty table should not be displayed if there are no agreements, but the "There are no agreements defined" message instead. And so we need the "Loading..." back.
Comment 12 Jonathan Druart 2023-03-07 13:05:28 UTC
The table is not loading with this last patch, I get "Uncaught TypeError: row.vendor is null"
Comment 13 Jonathan Druart 2023-03-07 14:44:40 UTC
Created attachment 147846 [details] [review]
Bug 33066: Fix "Loading..."
Comment 14 Jonathan Druart 2023-03-07 14:44:43 UTC
Created attachment 147847 [details] [review]
Bug 33066: Reintroduce column filters
Comment 15 Jonathan Druart 2023-03-07 14:44:46 UTC
Created attachment 147848 [details] [review]
Bug 33066: Fix name display
Comment 16 Jonathan Druart 2023-03-07 14:44:49 UTC
Created attachment 147849 [details] [review]
Bug 33066: Remove build_datatable
Comment 17 Jonathan Druart 2023-03-07 14:44:52 UTC
Created attachment 147850 [details] [review]
Bug 33066: Embed vendor and retrieve vendor name from the request
Comment 18 Jonathan Druart 2023-03-07 15:13:14 UTC
Created attachment 147851 [details] [review]
Bug 33066: Remove duplicate 'Actions' column
Comment 19 Jonathan Druart 2023-03-07 15:28:18 UTC
Created attachment 147852 [details] [review]
Bug 33066: Fix default_search
Comment 20 Jonathan Druart 2023-03-07 15:33:09 UTC
Created attachment 147853 [details] [review]
Bug 33066: Fix default_filters

Will need to be tested when EHoldingsEBSCOTitlesList.vue will be
adjusted
Comment 21 Jonathan Druart 2023-03-07 15:43:59 UTC
Created attachment 147855 [details] [review]
Bug 33066: Fix ColVis

The filter (header) was not removed alongwith the column
Comment 22 Jonathan Druart 2023-03-07 15:47:19 UTC
Created attachment 147856 [details] [review]
Bug 33066: Fix width after ColVis change

This fixes the width to 100%, otherwise it is not recalculated correctly
Comment 23 Jonathan Druart 2023-03-07 15:56:15 UTC
Created attachment 147857 [details] [review]
Bug 33066: Fix agreement name in delete confirmation dialog
Comment 24 Jonathan Druart 2023-03-07 16:04:17 UTC
Created attachment 147858 [details] [review]
Bug 33066: Use KohaTable for LicensesList
Comment 25 Jonathan Druart 2023-03-07 16:37:11 UTC
Created attachment 147862 [details] [review]
Bug 33066: Use KohaTable for LicensesList
Comment 26 Jonathan Druart 2023-03-07 16:41:25 UTC
Created attachment 147865 [details] [review]
Bug 33066: Restore HTML escaping

And we add a render function that will escape by default
Comment 27 Jonathan Druart 2023-03-07 16:45:26 UTC
I am done for today, feel free to have a look.

I will continue tomorrow and adjust the other tables. Basically the diff that is needed can be seen on "Bug 33066: Use KohaTable for LicensesList".
Comment 28 Jonathan Druart 2023-03-08 12:25:58 UTC
Created attachment 147902 [details] [review]
Bug 33066: Introduce a KohaTable Vue component

The way we deal with DataTables in Vue component is not nice, especially when we
need to add buttons/link in the cell and interact with the rest of the Vue app from
there.

When I started to work on Vue last year there was no good solution from DataTables,
now there is a Vue component. It is not perfect, you still cannot add Vue component
in the DT component, but it brings something to follow. Agustin implemented something
on theke/import_source_vue, but he went too far, and it will need to rewrite the
whole ERM module. Additionally he didn't provide a solution that has the same features
as what we have now.

The goal of this patch is to not duplicate the code in datatables.js, we
don't want to maintain two version of this code (one is enough already!)
We split the huge function in datatables.js in small ones to make them
reusable from the Vue component.

This is quite ugly, and it needs to lot more addition, but it's a first
start!

Help, ideas, and feedback welcome (and needed!)
Comment 29 Jonathan Druart 2023-03-08 12:26:01 UTC
Created attachment 147903 [details] [review]
Bug 33066: Fix dt - no need to reselect
Comment 30 Jonathan Druart 2023-03-08 12:26:05 UTC
Created attachment 147904 [details] [review]
Bug 33066: Add colvis
Comment 31 Jonathan Druart 2023-03-08 12:26:07 UTC
Created attachment 147905 [details] [review]
Bug 33066: Fix "Loading..."
Comment 32 Jonathan Druart 2023-03-08 12:26:11 UTC
Created attachment 147906 [details] [review]
Bug 33066: Reintroduce column filters
Comment 33 Jonathan Druart 2023-03-08 12:26:14 UTC
Created attachment 147907 [details] [review]
Bug 33066: Fix name display
Comment 34 Jonathan Druart 2023-03-08 12:26:17 UTC
Created attachment 147908 [details] [review]
Bug 33066: Remove build_datatable
Comment 35 Jonathan Druart 2023-03-08 12:26:20 UTC
Created attachment 147909 [details] [review]
Bug 33066: Embed vendor and retrieve vendor name from the request
Comment 36 Jonathan Druart 2023-03-08 12:26:24 UTC
Created attachment 147910 [details] [review]
Bug 33066: Remove duplicate 'Actions' column
Comment 37 Jonathan Druart 2023-03-08 12:26:29 UTC
Created attachment 147911 [details] [review]
Bug 33066: Fix default_search
Comment 38 Jonathan Druart 2023-03-08 12:26:33 UTC
Created attachment 147912 [details] [review]
Bug 33066: Fix default_filters

Will need to be tested when EHoldingsEBSCOTitlesList.vue will be
adjusted
Comment 39 Jonathan Druart 2023-03-08 12:26:37 UTC
Created attachment 147913 [details] [review]
Bug 33066: Fix ColVis

The filter (header) was not removed alongwith the column
Comment 40 Jonathan Druart 2023-03-08 12:26:41 UTC
Created attachment 147914 [details] [review]
Bug 33066: Fix width after ColVis change

This fixes the width to 100%, otherwise it is not recalculated correctly
Comment 41 Jonathan Druart 2023-03-08 12:26:44 UTC
Created attachment 147915 [details] [review]
Bug 33066: Fix agreement name in delete confirmation dialog
Comment 42 Jonathan Druart 2023-03-08 12:26:48 UTC
Created attachment 147916 [details] [review]
Bug 33066: Use KohaTable for LicensesList
Comment 43 Jonathan Druart 2023-03-08 12:26:51 UTC
Created attachment 147917 [details] [review]
Bug 33066: Restore HTML escaping

And we add a render function that will escape by default
Comment 44 Jonathan Druart 2023-03-08 12:26:54 UTC
Created attachment 147918 [details] [review]
Bug 33066: Restore filter by mine
Comment 45 Jonathan Druart 2023-03-08 12:28:18 UTC
Rebased patches + last patch is fixing the "additional filters" we are passing to KohaTable.
I have tried several things and it's the only way that makes things work, it reads weird and ugly however. Suggestions welcomed!
Comment 46 Jonathan Druart 2023-03-08 13:23:06 UTC
Created attachment 147921 [details] [review]
Bug 33066: Use KohaTable for EHoldingsLocalPackagesList
Comment 47 Jonathan Druart 2023-03-08 13:23:10 UTC
Created attachment 147922 [details] [review]
Bug 33066: Use KohaTable for EHoldingsLocalPackageTitlesList
Comment 48 Jonathan Druart 2023-03-08 13:23:13 UTC
Created attachment 147923 [details] [review]
Bug 33066: Fix style - FIXME

This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1
The table is not taking width: 100%
I fixed it previously with the display: table in the style block, but
here it's not applied.
Comment 49 Jonathan Druart 2023-03-08 13:23:34 UTC
(In reply to Jonathan Druart from comment #48)
> Created attachment 147923 [details] [review] [review]
> Bug 33066: Fix style - FIXME
> 
> This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1
> The table is not taking width: 100%
> I fixed it previously with the display: table in the style block, but
> here it's not applied.

This patch is not working, I don't understand what's happening!
Comment 50 Jonathan Druart 2023-03-08 13:32:36 UTC
Created attachment 147925 [details] [review]
Bug 33066: Use KohaTable for EHoldingsLocalTitlePackagesList
Comment 51 Jonathan Druart 2023-03-08 13:36:21 UTC
Created attachment 147926 [details] [review]
Bug 33066: Use KohaTable for EHoldingsLocalPackagesList
Comment 52 Jonathan Druart 2023-03-08 13:54:27 UTC
(In reply to Jonathan Druart from comment #51)
> Created attachment 147926 [details] [review] [review]
> Bug 33066: Use KohaTable for EHoldingsLocalPackagesList

This is not working because we were not using kohaTable from this component, but dataTable => not ajax but data from array directly.

We could adjust our KohaTable Vue component to deal with that, but that's for another day...
Comment 53 Jonathan Druart 2023-03-08 14:02:50 UTC
Created attachment 147928 [details] [review]
Bug 33066: Use KohaTable for EHoldingsLocalTitlesList
Comment 54 Jonathan Druart 2023-03-08 14:47:03 UTC
Created attachment 147957 [details] [review]
Bug 33066: (follow-up) Use KohaTable for EHoldingsLocalTitlePackagesList
Comment 55 Jonathan Druart 2023-03-08 14:58:29 UTC
Created attachment 147960 [details] [review]
Bug 33066: Use KohaTable for EHoldingsEBSCOPackagesList
Comment 56 Jonathan Druart 2023-03-08 14:59:19 UTC
(In reply to Jonathan Druart from comment #55)
This needs the last patch from 32983 to apply correctly
Comment 57 Jonathan Druart 2023-03-08 15:01:00 UTC
Remote branch up-to-date with master is at https://gitlab.com/joubu/Koha/-/commits/bug_33066

There are 2 components left: EHoldingsEBSCOPackageTitlesList and EHoldingsEBSCOTitlesList

I won't be able to finish this before the next two weeks unfortunately.
Comment 58 Pedro Amorim 2023-03-08 18:38:55 UTC
Created attachment 147971 [details] [review]
Bug 33066: Restore '(#id)' to lists
Comment 59 Pedro Amorim 2023-03-08 18:38:58 UTC
Created attachment 147972 [details] [review]
Bug 33066: Fix agreements and licenses cypress tests
Comment 60 Pedro Amorim 2023-03-08 18:39:57 UTC
I want to pick this up but not sure if I have the time to dedicate to it in the next few days.
Comment 61 Jonathan Druart 2023-03-17 15:12:40 UTC
Ready for signoff, the patches are on the remote branch at https://gitlab.com/joubu/Koha/-/commits/bug_33066
Comment 62 Jonathan Druart 2023-03-22 09:38:17 UTC
I've added a couple of follow-ups to the remote branch.
Comment 63 Pedro Amorim 2023-03-26 10:55:51 UTC
Created attachment 148718 [details] [review]
Bug 33066: Fix table style

Move table rendering outside <ol> to prevent unintended style in _forms.scss from being applied and causing table to not be full width
Remove unecessary table styling
Comment 64 Pedro Amorim 2023-03-26 10:58:00 UTC
@Joubu the above patch sits on top of https://gitlab.com/joubu/Koha/-/commits/bug_33066

I believe it fixes the styling problem with the related resources table not going full width.

Important: Please test EBSCO well, I have not tested EHoldingsEBSCOPackageTitlesList because I lack the EBSCO credentials at this time.
Comment 65 Pedro Amorim 2023-03-26 11:00:29 UTC
I have tested and reviewed this code and everything seems to be working nicely.
Not 100% familiarized with the previous datatables code so can't say there is 100% feature parity but it seems to be.

I think this is ready for squashing and sign-off at this point.
Comment 66 Jonathan Druart 2023-03-27 08:55:07 UTC
(In reply to Pedro Amorim from comment #63)
> Created attachment 148718 [details] [review] [review]
> Bug 33066: Fix table style
> 
> Move table rendering outside <ol> to prevent unintended style in _forms.scss
> from being applied and causing table to not be full width
> Remove unecessary table styling

Added to the remote branch, thanks!

Remote branch rebased and some patches have been squashed.
Comment 67 Jonathan Druart 2023-03-27 08:56:38 UTC
(In reply to Jonathan Druart from comment #49)
> (In reply to Jonathan Druart from comment #48)
> > Created attachment 147923 [details] [review] [review] [review]
> > Bug 33066: Fix style - FIXME
> > 
> > This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1
> > The table is not taking width: 100%
> > I fixed it previously with the display: table in the style block, but
> > here it's not applied.
> 
> This patch is not working, I don't understand what's happening!

The patch from Pedro is fixing both problems.
Comment 68 Pedro Amorim 2023-03-27 09:32:19 UTC
Signed-off from me
Comment 69 Agustín Moyano 2023-04-04 23:10:27 UTC
Signed-off from me
Comment 70 Jonathan Druart 2023-04-05 07:21:17 UTC
Added your signed-off-by lines to the remote branch, thanks a lot!
Comment 71 Jonathan Druart 2023-04-05 07:21:47 UTC
Created attachment 149158 [details] [review]
Bug 33066: Introduce a KohaTable Vue component

The way we deal with DataTables in Vue component is not nice, especially when we
need to add buttons/link in the cell and interact with the rest of the Vue app from
there.

When I started to work on Vue last year there was no good solution from DataTables,
now there is a Vue component. It is not perfect, you still cannot add Vue component
in the DT component, but it brings something to follow. Agustin implemented something
on theke/import_source_vue, but he went too far, and it will need to rewrite the
whole ERM module. Additionally he didn't provide a solution that has the same features
as what we have now.

The goal of this patch is to not duplicate the code in datatables.js, we
don't want to maintain two version of this code (one is enough already!)
We split the huge function in datatables.js in small ones to make them
reusable from the Vue component.

This is quite ugly, and it needs to lot more addition, but it's a first
start!

Help, ideas, and feedback welcome (and needed!)

Bug 33066: Fix agreement name in delete confirmation dialog

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 72 Jonathan Druart 2023-04-05 07:21:51 UTC
Created attachment 149159 [details] [review]
Bug 33066: Fix dt - no need to reselect

Bug 33066: (follow-up) Fix dt - no need to reselect

Patron search result table was not displayed correctly
Uncaught TypeError: this.on is not a function

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 73 Jonathan Druart 2023-04-05 07:21:54 UTC
Created attachment 149160 [details] [review]
Bug 33066: Add colvis

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 74 Jonathan Druart 2023-04-05 07:21:58 UTC
Created attachment 149161 [details] [review]
Bug 33066: Fix "Loading..."

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 75 Jonathan Druart 2023-04-05 07:22:01 UTC
Created attachment 149162 [details] [review]
Bug 33066: Reintroduce column filters

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 76 Jonathan Druart 2023-04-05 07:22:05 UTC
Created attachment 149163 [details] [review]
Bug 33066: Fix name display

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 77 Jonathan Druart 2023-04-05 07:22:08 UTC
Created attachment 149164 [details] [review]
Bug 33066: Remove build_datatable

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 78 Jonathan Druart 2023-04-05 07:22:11 UTC
Created attachment 149165 [details] [review]
Bug 33066: Embed vendor and retrieve vendor name from the request

Bug 33066: (follow-up) Embed vendor and retrieve vendor name from the request

It needs "Bug 32923: Allow to embed user_roles for agreements"

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 79 Jonathan Druart 2023-04-05 07:22:14 UTC
Created attachment 149166 [details] [review]
Bug 33066: Remove duplicate 'Actions' column

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 80 Jonathan Druart 2023-04-05 07:22:18 UTC
Created attachment 149167 [details] [review]
Bug 33066: Fix default_search

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 81 Jonathan Druart 2023-04-05 07:22:21 UTC
Created attachment 149168 [details] [review]
Bug 33066: Fix default_filters

Will need to be tested when EHoldingsEBSCOTitlesList.vue will be
adjusted

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 82 Jonathan Druart 2023-04-05 07:22:24 UTC
Created attachment 149169 [details] [review]
Bug 33066: Fix ColVis

The filter (header) was not removed alongwith the column

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 83 Jonathan Druart 2023-04-05 07:22:28 UTC
Created attachment 149170 [details] [review]
Bug 33066: Fix width after ColVis change

This fixes the width to 100%, otherwise it is not recalculated correctly

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 84 Jonathan Druart 2023-04-05 07:22:31 UTC
Created attachment 149171 [details] [review]
Bug 33066: Use KohaTable for LicensesList

Bug 33066: (follow-up) Use KohaTable for LicensesList

There was a mismatch, we can embed the whole vendor object info.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 85 Jonathan Druart 2023-04-05 07:22:34 UTC
Created attachment 149172 [details] [review]
Bug 33066: Restore HTML escaping

And we add a render function that will escape by default

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 86 Jonathan Druart 2023-04-05 07:22:37 UTC
Created attachment 149173 [details] [review]
Bug 33066: Restore filter by mine

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 87 Jonathan Druart 2023-04-05 07:22:41 UTC
Created attachment 149174 [details] [review]
Bug 33066: Use KohaTable for EHoldingsLocalPackagesList

Bug 33066: (follow-up) Use KohaTable for EHoldingsLocalTitlePackagesList

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 88 Jonathan Druart 2023-04-05 07:22:44 UTC
Created attachment 149175 [details] [review]
Bug 33066: Use KohaTable for EHoldingsLocalPackageTitlesList

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 89 Jonathan Druart 2023-04-05 07:22:48 UTC
Created attachment 149176 [details] [review]
Bug 33066: Use KohaTable for EHoldingsLocalTitlesList

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 90 Jonathan Druart 2023-04-05 07:22:51 UTC
Created attachment 149177 [details] [review]
Bug 33066: Use KohaTable for EHoldingsEBSCOPackagesList

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 91 Jonathan Druart 2023-04-05 07:22:54 UTC
Created attachment 149178 [details] [review]
Bug 33066: Restore '(#id)' to lists

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 92 Jonathan Druart 2023-04-05 07:22:57 UTC
Created attachment 149179 [details] [review]
Bug 33066: Use KohaTable for EHoldingsEBSCOPackageTitlesList

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 93 Jonathan Druart 2023-04-05 07:23:01 UTC
Created attachment 149180 [details] [review]
Bug 33066: Use KohaTable for EHoldingsEBSCOTitlesList

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 94 Jonathan Druart 2023-04-05 07:23:04 UTC
Created attachment 149181 [details] [review]
Bug 33066: Remove useless use of useDataTable

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 95 Jonathan Druart 2023-04-05 07:23:08 UTC
Created attachment 149182 [details] [review]
Bug 33066: Fix cypress tests

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 96 Jonathan Druart 2023-04-05 07:23:11 UTC
Created attachment 149183 [details] [review]
Bug 33066: Fix table style

Move table rendering outside <ol> to prevent unintended style in _forms.scss from being applied and causing table to not be full width
Remove unecessary table styling

JD: following commit has been squashed. Patch from Pedro is fixing the
FIXME
"""
Bug 33066: Fix style - FIXME

This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1
The table is not taking width: 100%
I fixed it previously with the display: table in the style block, but
here it's not applied.

There is also the "green tick" (fa-check-square-o) that is not on the
same line https://snipboard.io/jma923.jpg
"""

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 97 Tomás Cohen Arazi 2023-04-10 10:38:26 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 98 Katrin Fischer 2023-04-10 11:10:53 UTC
It looks like this broke Jenkins.
Comment 99 Tomás Cohen Arazi 2023-04-10 11:21:55 UTC
(In reply to Katrin Fischer from comment #98)
> It looks like this broke Jenkins.

Hey, we need the images rebuilt with the new deps. thanks for reporting.
Comment 100 Katrin Fischer 2023-04-11 20:47:37 UTC
ERM is totally broken for me :(

I have tried it all: git pull, ktd down, ktd pull, ktd up, etc. But I am still stuck with that and no table will display:

Source map error: Error: unsupported protocol for sourcemap request webpack://koha/node_modules/vue-select/dist/vue-select.js.map
Resource URL: webpack://koha/./node_modules/vue-select/dist/vue-select.js?
Source Map URL: vue-select.js.map
[Vue warn]: Unhandled error during execution of render function 
  at <DataTable columns= 
Array(8) [ Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, {…} ]
 options= 
Object { language: {…}, dom: '<"dt-info"i><"top pager"<"table_entries"lp><"table_controls"fB>>tr<"bottom pager"ip>', buttons: Proxy, lengthMenu: (2) […], pageLength: 20, fixedHeader: true, initComplete: initComplete(settings), deferRender: true, paging: true, serverSide: true, … }
 data= 
Array []
  ... > 
  at <KohaTable ref="table" columns= 
Array(7) [ {…}, {…}, {…}, {…}, {…}, {…}, {…} ]
 url="/api/v1/erm/licenses"  ... > 
  at <LicensesList onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< 
Proxy { <target>: {…}, <handler>: {…} }
 > > 
  at <RouterView> 
  at <Main> runtime-core.esm-bundler.js:167:17
[Vue warn]: Unhandled error during execution of scheduler flush. This is likely a Vue internals bug. Please open an issue at https://new-issue.vuejs.org/?repo=vuejs/core 
  at <DataTable columns= 
Array(8) [ Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, {…} ]
 options= 
Object { language: {…}, dom: '<"dt-info"i><"top pager"<"table_entries"lp><"table_controls"fB>>tr<"bottom pager"ip>', buttons: Proxy, lengthMenu: (2) […], pageLength: 20, fixedHeader: true, initComplete: initComplete(settings), deferRender: true, paging: true, serverSide: true, … }
 data= 
Array []
  ... > 
  at <KohaTable ref="table" columns= 
Array(7) [ {…}, {…}, {…}, {…}, {…}, {…}, {…} ]
 url="/api/v1/erm/licenses"  ... > 
  at <LicensesList onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< 
Proxy { <target>: {…}, <handler>: {…} }
 > > 
  at <RouterView> 
  at <Main> runtime-core.esm-bundler.js:167:17
Uncaught (in promise) TypeError: currentRenderingInstance is null
    renderSlot webpack://koha/../node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:3092
    render VueJS
    renderComponentRoot webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:1028
    componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5730
    run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225
    update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844
    setupRenderEffect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5858
    mountComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5640
    processComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5598
    patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5200
    componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5737
    run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225
    update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844
    setupRenderEffect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5858
    mountComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5640
    processComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5598
    patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5200
    mountChildren webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5384
    mountElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5294
    processElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5277
    patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5197
    mountChildren webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5384
    mountElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5294
    processElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5277
    patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5197
    componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5810
    run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225
    update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844
    callWithErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:284
    flushJobs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:514
    promise callback*queueFlush webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:406
    queueJob webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:400
    effect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5842
    triggerEffect webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:430
    triggerEffects webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:420
    trigger webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:392
    set webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:559
    set webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:3311
    beforeRouteEnter webpack://koha/./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue?./node_modules/vue-loader/dist/index.js??ruleSet[1].rules[5].use[0]:68
    promise callback*beforeRouteEnter/< webpack://koha/./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue?./node_modules/vue-loader/dist/index.js??ruleSet[1].rules[5].use[0]:68
    setup webpack://koha/./node_modules/vue-router/dist/vue-router.cjs?:2385
    setup webpack://koha/./node_modules/vue-router/dist/vue-router.cjs?:2385
    callWithErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:284
    callWithAsyncErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:293
    job webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:1915
    flushPostFlushCbs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:467
    flushJobs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:521
erm_22.1200019.js line 3481 > eval:3092:9
Comment 101 Katrin Fischer 2023-04-11 20:50:47 UTC
Fixed by a yarn install before yarn build.
Comment 102 Jacob O'Mara 2023-04-17 07:24:12 UTC
Enhancement - not backporting to 22.11.x

Nice work everyone!
Comment 103 Martin Renvoize 2023-05-11 13:41:49 UTC
Whilst this is most certainly an enhancement.. it's an important architectural one for ERM.

I've decided to overrule the decision made not to backport as I believe, especially as this is an LTS release, we need it to ensure we can continue to maintain ERM going forward for the rest of the maintanence period.
Comment 104 Martin Renvoize 2023-05-11 16:19:18 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 105 Lucas Gass 2023-05-15 22:38:31 UTC
Not needed for 22.05.x, no backport.