The modal opens empty with "Loading..."
Created attachment 149437 [details] [review] Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements.
Created attachment 149452 [details] [review] Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not
Created attachment 149455 [details] [review] Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 149456 [details] [review] Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not
Created attachment 149470 [details] [review] Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 149471 [details] [review] Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 149472 [details] [review] Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 149473 [details] [review] Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not
Created attachment 149527 [details] [review] Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 149528 [details] [review] Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 149529 [details] [review] Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not
I think there's a bug when adding more than one agreement to an EBSCO package (getting error 400 but need to double-check this), I also think we should only list agreements that are not already related to said package, i.e. when adding subsequent agreements to the same packages, the ones already related do not show up in the "to-relate" list. Working on this.
Created attachment 149555 [details] [review] Bug 33483: Prevent 400 when more than 1 agreement is linked We were passing package_agreements.agreement and the server returned Object { message: "Properties not allowed: agreement.", path: "/body/package_agreements/0" }
Created attachment 149564 [details] [review] Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 149565 [details] [review] Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 149566 [details] [review] Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 149567 [details] [review] Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 149568 [details] [review] Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 149569 [details] [review] Bug 33483: Prevent 400 when more than 1 agreement is linked We were passing package_agreements.agreement and the server returned Object { message: "Properties not allowed: agreement.", path: "/body/package_agreements/0" } Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Tested last patch, can confirm it fixes the 400 error when adding a 2nd agreement to an EBSCO package.
Hmmm.. I'd love to see some tests around this whole area...
(In reply to Martin Renvoize from comment #21) > Hmmm.. I'd love to see some tests around this whole area... See bug 33492.
*** Bug 33529 has been marked as a duplicate of this bug. ***
(In reply to Martin Renvoize from comment #21) > Hmmm.. I'd love to see some tests around this whole area... And also note that these patches are actually fixing several tests that are currently failing on master.
We really need this ASAP.
Created attachment 149847 [details] [review] Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 149848 [details] [review] Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 149849 [details] [review] Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 149850 [details] [review] Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 149851 [details] [review] Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 149852 [details] [review] Bug 33483: Prevent 400 when more than 1 agreement is linked We were passing package_agreements.agreement and the server returned Object { message: "Properties not allowed: agreement.", path: "/body/package_agreements/0" } Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All working as expected and code reads reasonably. I think I would have liked to have seen the KohaTable flexibility improvements on their own bug as Matt had done, but I also don't want to block this one moving through, and we're early enough in the Vue/ERM side of things that I think we're OK this way. Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
No need for any changes to the manual.