33104 – Add vendor interfaces

Bug 33104 - Add vendor interfaces

Summary: Add vendor interfaces

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Acquisitions (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P5 - low new feature
Assignee:	Jonathan Druart
QA Contact:	Katrin Fischer

URL:
Keywords:

Depends on:	33103
Blocks:	33105 33499 33797 33798
	Show dependency tree / graph

Reported:	2023-03-01 10:00 UTC by Jonathan Druart
Modified:	2024-07-04 20:37 UTC (History)
CC List:	5 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Medium patch
Documentation contact:	Caroline Cyr La Rose
Documentation submission:	https://gitlab.com/koha-community/koha-manual/-/merge_requests/687
Text to go in the release notes:	This adds the ability to create interfaces for vendors. An interface is a website, software, or portal that you use to manage orders or gather statistics from the vendor or organisation. Interfaces can also include usernames and passwords, that will be encrypted for storage, but can be decrypted and made visible in the staff interface. The type of an interface can be set using the `VENDOR_INTERFACE_TYPE` authorised values category.
Version(s) released in:	23.05.00
Circulation function:

Attachments
Bug 33104: DB changes (7.04 KB, patch) 2023-03-02 14:36 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: DBIC changes (4.33 KB, patch) 2023-03-02 14:36 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Koha classes (3.05 KB, patch) 2023-03-02 14:36 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Add the ability to create vendor interfaces (10.78 KB, patch) 2023-03-02 14:36 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Make the code reusable (4.13 KB, patch) 2023-03-02 14:36 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Encrypt password (5.84 KB, patch) 2023-03-02 14:36 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list (3.42 KB, patch) 2023-03-02 14:36 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Add tests (2.31 KB, patch) 2023-03-02 14:36 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: DB changes (7.04 KB, patch) 2023-03-21 13:12 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: DBIC changes (4.33 KB, patch) 2023-03-21 13:12 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Koha classes (3.05 KB, patch) 2023-03-21 13:12 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Add the ability to create vendor interfaces (10.78 KB, patch) 2023-03-21 13:12 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Make the code reusable (4.13 KB, patch) 2023-03-21 13:12 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Encrypt password (5.84 KB, patch) 2023-03-21 13:12 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list (3.20 KB, patch) 2023-03-21 13:12 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Add tests (2.31 KB, patch) 2023-03-21 13:12 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: DB changes (6.96 KB, patch) 2023-03-21 14:41 UTC, PTFS Europe Sandboxes	Details \| Diff \| Splinter Review
Bug 33104: DBIC changes (4.39 KB, patch) 2023-03-21 14:41 UTC, PTFS Europe Sandboxes	Details \| Diff \| Splinter Review
Bug 33104: Koha classes (3.11 KB, patch) 2023-03-21 14:41 UTC, PTFS Europe Sandboxes	Details \| Diff \| Splinter Review
Bug 33104: Add the ability to create vendor interfaces (10.83 KB, patch) 2023-03-21 14:41 UTC, PTFS Europe Sandboxes	Details \| Diff \| Splinter Review
Bug 33104: Make the code reusable (4.20 KB, patch) 2023-03-21 14:41 UTC, PTFS Europe Sandboxes	Details \| Diff \| Splinter Review
Bug 33104: Encrypt password (5.89 KB, patch) 2023-03-21 14:41 UTC, PTFS Europe Sandboxes	Details \| Diff \| Splinter Review
Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list (3.25 KB, patch) 2023-03-21 14:41 UTC, PTFS Europe Sandboxes	Details \| Diff \| Splinter Review
Bug 33104: Add tests (2.37 KB, patch) 2023-03-21 14:41 UTC, PTFS Europe Sandboxes	Details \| Diff \| Splinter Review
Screenshot of vendor detail page (41.64 KB, image/png) 2023-04-09 15:31 UTC, Katrin Fischer	Details
Bug 33104: Fix translatability (1.12 KB, patch) 2023-04-11 10:15 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Add email validation (1.09 KB, patch) 2023-04-11 10:16 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Prevent 'Type' to be cleared (1.17 KB, patch) 2023-04-11 10:16 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: Remove fieldset (3.39 KB, patch) 2023-04-11 10:24 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: DB changes (6.96 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: DBIC changes (4.39 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: Koha classes (3.11 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: Add the ability to create vendor interfaces (10.83 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: Make the code reusable (4.20 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: Encrypt password (5.89 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list (3.25 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: Add tests (2.37 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: Fix translatability (1.12 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: Add email validation (1.08 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: Prevent 'Type' to be cleared (1.22 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: Remove fieldset (3.44 KB, patch) 2023-04-11 21:13 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Bug 33104: Rename interfaces.id with interface_id (3.36 KB, patch) 2023-04-14 06:15 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 33104: DBIC changes (1.63 KB, patch) 2023-04-14 06:15 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Show Obsolete (29) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2023-03-01 10:00:02 UTC

An interface is a website, software, or portal that you use to manage orders or gather statistics from the vendor/organisation.

Comment 1 Jonathan Druart 2023-03-02 14:36:31 UTC

Created attachment 147632 [details] [review]
Bug 33104: DB changes

Comment 2 Jonathan Druart 2023-03-02 14:36:34 UTC

Created attachment 147633 [details] [review]
Bug 33104: DBIC changes

Comment 3 Jonathan Druart 2023-03-02 14:36:37 UTC

Created attachment 147634 [details] [review]
Bug 33104: Koha classes

Comment 4 Jonathan Druart 2023-03-02 14:36:39 UTC

Created attachment 147635 [details] [review]
Bug 33104: Add the ability to create vendor interfaces

This patchset is adding the ability to create interfaces for vendors.
An interface is a website, software, or portal that you use to manage orders or
gather statistics from the vendor/organisation.

It will help librarians to keep track of those different information
within Koha.

* new DB table aqbookseller_interfaces(id, vendor_id, type, name, uri,
login, password, account_email, notes)
* new AV category VENDOR_INTERFACE_TYPE with 3 example values ADMIN,
ORDERS, REPORTS
* new pair of Koha classes Koha::Acquisition::Bookseller::Interface[s]
* new method to retrieve the interfaces from the vendor
Koha::Acquisition::Bookseller->interfaces
* Add/Delete interfaces when editing a vendor
* Display the interfaces on the vendor show view

Test plan:
- Add a new vendor
=> Notice the new "Interfaces" block
- Create some interfaces
=> They are display on the vendor show view
=> The password is hashed and can displayed on the demand

QA Note:
The "contacts" code is not very nice and I didn't want to replicate it,
so I went another way and tried to make the code reusable, for further
reutilisation.

Comment 5 Jonathan Druart 2023-03-02 14:36:42 UTC

Created attachment 147636 [details] [review]
Bug 33104: Make the code reusable

We could then reuse it for the contacts code in this same template, on
another bug report.

Comment 6 Jonathan Druart 2023-03-02 14:36:44 UTC

Created attachment 147637 [details] [review]
Bug 33104: Encrypt password

Comment 7 Jonathan Druart 2023-03-02 14:36:47 UTC

Created attachment 147638 [details] [review]
Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list

Comment 8 Jonathan Druart 2023-03-02 14:36:50 UTC

Created attachment 147639 [details] [review]
Bug 33104: Add tests

Comment 9 Jonathan Druart 2023-03-21 13:12:09 UTC

Created attachment 148459 [details] [review]
Bug 33104: DB changes

Comment 10 Jonathan Druart 2023-03-21 13:12:12 UTC

Created attachment 148460 [details] [review]
Bug 33104: DBIC changes

Comment 11 Jonathan Druart 2023-03-21 13:12:14 UTC

Created attachment 148461 [details] [review]
Bug 33104: Koha classes

Comment 12 Jonathan Druart 2023-03-21 13:12:17 UTC

Created attachment 148462 [details] [review]
Bug 33104: Add the ability to create vendor interfaces

This patchset is adding the ability to create interfaces for vendors.
An interface is a website, software, or portal that you use to manage orders or
gather statistics from the vendor/organisation.

It will help librarians to keep track of those different information
within Koha.

* new DB table aqbookseller_interfaces(id, vendor_id, type, name, uri,
login, password, account_email, notes)
* new AV category VENDOR_INTERFACE_TYPE with 3 example values ADMIN,
ORDERS, REPORTS
* new pair of Koha classes Koha::Acquisition::Bookseller::Interface[s]
* new method to retrieve the interfaces from the vendor
Koha::Acquisition::Bookseller->interfaces
* Add/Delete interfaces when editing a vendor
* Display the interfaces on the vendor show view

Test plan:
- Add a new vendor
=> Notice the new "Interfaces" block
- Create some interfaces
=> They are display on the vendor show view
=> The password is hashed and can displayed on the demand

QA Note:
The "contacts" code is not very nice and I didn't want to replicate it,
so I went another way and tried to make the code reusable, for further
reutilisation.

Comment 13 Jonathan Druart 2023-03-21 13:12:19 UTC

Created attachment 148463 [details] [review]
Bug 33104: Make the code reusable

We could then reuse it for the contacts code in this same template, on
another bug report.

Comment 14 Jonathan Druart 2023-03-21 13:12:22 UTC

Created attachment 148464 [details] [review]
Bug 33104: Encrypt password

Comment 15 Jonathan Druart 2023-03-21 13:12:25 UTC

Created attachment 148465 [details] [review]
Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list

Comment 16 Jonathan Druart 2023-03-21 13:12:27 UTC

Created attachment 148466 [details] [review]
Bug 33104: Add tests

Comment 17 PTFS Europe Sandboxes 2023-03-21 14:41:37 UTC

Created attachment 148473 [details] [review]
Bug 33104: DB changes

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 18 PTFS Europe Sandboxes 2023-03-21 14:41:39 UTC

Created attachment 148474 [details] [review]
Bug 33104: DBIC changes

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 19 PTFS Europe Sandboxes 2023-03-21 14:41:41 UTC

Created attachment 148475 [details] [review]
Bug 33104: Koha classes

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 20 PTFS Europe Sandboxes 2023-03-21 14:41:43 UTC

Created attachment 148476 [details] [review]
Bug 33104: Add the ability to create vendor interfaces

This patchset is adding the ability to create interfaces for vendors.
An interface is a website, software, or portal that you use to manage orders or
gather statistics from the vendor/organisation.

It will help librarians to keep track of those different information
within Koha.

* new DB table aqbookseller_interfaces(id, vendor_id, type, name, uri,
login, password, account_email, notes)
* new AV category VENDOR_INTERFACE_TYPE with 3 example values ADMIN,
ORDERS, REPORTS
* new pair of Koha classes Koha::Acquisition::Bookseller::Interface[s]
* new method to retrieve the interfaces from the vendor
Koha::Acquisition::Bookseller->interfaces
* Add/Delete interfaces when editing a vendor
* Display the interfaces on the vendor show view

Test plan:
- Add a new vendor
=> Notice the new "Interfaces" block
- Create some interfaces
=> They are display on the vendor show view
=> The password is hashed and can displayed on the demand

QA Note:
The "contacts" code is not very nice and I didn't want to replicate it,
so I went another way and tried to make the code reusable, for further
reutilisation.

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 21 PTFS Europe Sandboxes 2023-03-21 14:41:46 UTC

Created attachment 148477 [details] [review]
Bug 33104: Make the code reusable

We could then reuse it for the contacts code in this same template, on
another bug report.

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 22 PTFS Europe Sandboxes 2023-03-21 14:41:48 UTC

Created attachment 148478 [details] [review]
Bug 33104: Encrypt password

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 23 PTFS Europe Sandboxes 2023-03-21 14:41:50 UTC

Created attachment 148479 [details] [review]
Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 24 PTFS Europe Sandboxes 2023-03-21 14:41:52 UTC

Created attachment 148480 [details] [review]
Bug 33104: Add tests

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 25 David Nind 2023-03-21 17:19:38 UTC

It looks like this has now been signed off by Jonathan.

Jonathan, if you could update the status that would be great! (This credits you on the dashboard for the sign-off).

Comment 26 Jonathan Field 2023-03-21 17:23:10 UTC

Sorry, forgot to do that at the end! Thanks!

Comment 27 David Nind 2023-03-21 17:50:39 UTC

(In reply to Jonathan Field from comment #26)
> Sorry, forgot to do that at the end! Thanks!

8-) No problem! I've certainly forgotten to do this on occasion.

Comment 28 Katrin Fischer 2023-04-09 15:29:36 UTC

1) I18N

ol.append(`<li><button class="btn btn-default" onclick="remove_interface(${i});"><i class="fa fa-trash"></i> Delete interface</li>`);

2) Vendor search

* I am seeing a strange effect there: the "My Vendor" vendor with booksellerid=1 is showing up twice after applying the patch.
Switching back to master makes the doubled up vendor go away.

3) Vendor edit form

* Adding the email validation to the email field would be good.
* If you add multiple interfaces, the type pull down empties/resets to "" for all interfaces when clicking on "Add another interface". This also happens to the already saved interfaces.

4) Vendor details page

* The new information is not displaying correctly (see screenshot). I did a yarn build and reset_all, nothing would fix. Background is wrong and also the line height doesn't match with the other sections on the page.

5) Database update and sample data

* This appears complete and correct :)

Comment 29 Katrin Fischer 2023-04-09 15:31:07 UTC

Created attachment 149375 [details]
Screenshot of vendor detail page

Comment 30 Jonathan Druart 2023-04-11 10:09:48 UTC

(In reply to Katrin Fischer from comment #28)
> 1) I18N
> 
> ol.append(`<li><button class="btn btn-default"
> onclick="remove_interface(${i});"><i class="fa fa-trash"></i> Delete
> interface</li>`);

Fixed.

> 2) Vendor search
> 
> * I am seeing a strange effect there: the "My Vendor" vendor with
> booksellerid=1 is showing up twice after applying the patch.
> Switching back to master makes the doubled up vendor go away.

Fixed on bug 33103.

> 3) Vendor edit form
> 
> * Adding the email validation to the email field would be good.

Done in "Add email validation"

> * If you add multiple interfaces, the type pull down empties/resets to ""
> for all interfaces when clicking on "Add another interface". This also
> happens to the already saved interfaces.

Done in "Prevent 'Type' to be cleared

> 4) Vendor details page
> 
> * The new information is not displaying correctly (see screenshot). I did a
> yarn build and reset_all, nothing would fix. Background is wrong and also
> the line height doesn't match with the other sections on the page.

What are you suggesting? I think this is nicer than the others :D

https://snipboard.io/Iwetbx.jpg

Contacts are missing padding, contracts are in a table (what we don't want here, it won't be easy to read).

Comment 31 Jonathan Druart 2023-04-11 10:15:57 UTC

Created attachment 149420 [details] [review]
Bug 33104: Fix translatability

Comment 32 Jonathan Druart 2023-04-11 10:16:00 UTC

Created attachment 149421 [details] [review]
Bug 33104: Add email validation

Comment 33 Jonathan Druart 2023-04-11 10:16:02 UTC

Created attachment 149422 [details] [review]
Bug 33104: Prevent 'Type' to be cleared

Comment 34 Jonathan Druart 2023-04-11 10:24:13 UTC

Created attachment 149431 [details] [review]
Bug 33104: Remove fieldset

For consistency with "Contacts"

Comment 35 Jonathan Druart 2023-04-11 10:25:24 UTC

(In reply to Jonathan Druart from comment #30)
> What are you suggesting? I think this is nicer than the others :D
> 
> https://snipboard.io/Iwetbx.jpg
> 
> Contacts are missing padding, contracts are in a table (what we don't want
> here, it won't be easy to read).

See last patch. Better for consistency, but IMO it was nicer prior to this patch (except the background weirdness)

https://snipboard.io/jv7yIe.jpg

Comment 36 Katrin Fischer 2023-04-11 21:11:07 UTC

(In reply to Jonathan Druart from comment #35)
> (In reply to Jonathan Druart from comment #30)
> > What are you suggesting? I think this is nicer than the others :D
> > 
> > https://snipboard.io/Iwetbx.jpg
> > 
> > Contacts are missing padding, contracts are in a table (what we don't want
> > here, it won't be easy to read).
> 
> See last patch. Better for consistency, but IMO it was nicer prior to this
> patch (except the background weirdness)
> 
> https://snipboard.io/jv7yIe.jpg

I've filed bug 33499 for improving the vendor detail page.

Otherwise... PQA now :)

Comment 37 Katrin Fischer 2023-04-11 21:13:19 UTC

Created attachment 149492 [details] [review]
Bug 33104: DB changes

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 38 Katrin Fischer 2023-04-11 21:13:22 UTC

Created attachment 149493 [details] [review]
Bug 33104: DBIC changes

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 39 Katrin Fischer 2023-04-11 21:13:24 UTC

Created attachment 149494 [details] [review]
Bug 33104: Koha classes

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 40 Katrin Fischer 2023-04-11 21:13:27 UTC

Created attachment 149495 [details] [review]
Bug 33104: Add the ability to create vendor interfaces

This patchset is adding the ability to create interfaces for vendors.
An interface is a website, software, or portal that you use to manage orders or
gather statistics from the vendor/organisation.

It will help librarians to keep track of those different information
within Koha.

* new DB table aqbookseller_interfaces(id, vendor_id, type, name, uri,
login, password, account_email, notes)
* new AV category VENDOR_INTERFACE_TYPE with 3 example values ADMIN,
ORDERS, REPORTS
* new pair of Koha classes Koha::Acquisition::Bookseller::Interface[s]
* new method to retrieve the interfaces from the vendor
Koha::Acquisition::Bookseller->interfaces
* Add/Delete interfaces when editing a vendor
* Display the interfaces on the vendor show view

Test plan:
- Add a new vendor
=> Notice the new "Interfaces" block
- Create some interfaces
=> They are display on the vendor show view
=> The password is hashed and can displayed on the demand

QA Note:
The "contacts" code is not very nice and I didn't want to replicate it,
so I went another way and tried to make the code reusable, for further
reutilisation.

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 41 Katrin Fischer 2023-04-11 21:13:30 UTC

Created attachment 149496 [details] [review]
Bug 33104: Make the code reusable

We could then reuse it for the contacts code in this same template, on
another bug report.

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 42 Katrin Fischer 2023-04-11 21:13:33 UTC

Created attachment 149497 [details] [review]
Bug 33104: Encrypt password

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 43 Katrin Fischer 2023-04-11 21:13:38 UTC

Created attachment 149498 [details] [review]
Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 44 Katrin Fischer 2023-04-11 21:13:42 UTC

Created attachment 149499 [details] [review]
Bug 33104: Add tests

Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com>

Comment 45 Katrin Fischer 2023-04-11 21:13:46 UTC

Created attachment 149500 [details] [review]
Bug 33104: Fix translatability

Comment 46 Katrin Fischer 2023-04-11 21:13:50 UTC

Created attachment 149501 [details] [review]
Bug 33104: Add email validation

Comment 47 Katrin Fischer 2023-04-11 21:13:53 UTC

Created attachment 149502 [details] [review]
Bug 33104: Prevent 'Type' to be cleared

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 48 Katrin Fischer 2023-04-11 21:13:56 UTC

Created attachment 149503 [details] [review]
Bug 33104: Remove fieldset

For consistency with "Contacts"

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 49 Jonathan Druart 2023-04-14 06:15:21 UTC

Created attachment 149631 [details] [review]
Bug 33104: Rename interfaces.id with interface_id

Comment 50 Jonathan Druart 2023-04-14 06:15:24 UTC

Created attachment 149632 [details] [review]
Bug 33104: DBIC changes

Comment 51 Jonathan Druart 2023-04-14 06:15:55 UTC

Rename asked by Tomas.

Comment 52 Tomás Cohen Arazi (tcohen) 2023-05-05 13:00:37 UTC

(In reply to Jonathan Druart from comment #51)
> Rename asked by Tomas.

Thanks

Comment 53 Tomás Cohen Arazi (tcohen) 2023-05-05 13:15:16 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 54 Martin Renvoize (ashimema) 2023-05-12 14:49:04 UTC

Enhancement and dependencies are not present.. won't backport to 22.11.x