Bug 33797 - Extra space in supplier.tt
Summary: Extra space in supplier.tt
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
: 33851 (view as bug list)
Depends on: 33104
Blocks:
  Show dependency treegraph
 
Reported: 2023-05-22 17:01 UTC by Tomás Cohen Arazi
Modified: 2023-06-08 17:12 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This removes the space between the field label and the colon for the notes field in the interfaces section for a vendor's details.
Version(s) released in:
23.05.00


Attachments
Bug 33797: Remove extra space (1.09 KB, patch)
2023-05-22 17:05 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 33797: Remove extra space (1.14 KB, patch)
2023-05-22 19:51 UTC, David Nind
Details | Diff | Splinter Review
Bug 33797: Remove extra space (1.21 KB, patch)
2023-05-23 09:02 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2023-05-22 17:01:35 UTC

    
Comment 1 Tomás Cohen Arazi 2023-05-22 17:05:17 UTC
Created attachment 151538 [details] [review]
Bug 33797: Remove extra space

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 David Nind 2023-05-22 19:51:55 UTC
Created attachment 151546 [details] [review]
Bug 33797: Remove extra space

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-05-22 20:03:06 UTC
Testing notes (using KTD):

1. Add a new vendor:
   1.1 Acquisitions > New vendor
   1.2 Enter name of vendor: My vendor name
   1.3 In the interfaces section, select 'Add another interface'
   1.4 Enter some details:
       - Name: Test bz33797
       - Email: me@example.com
       - Notes: Some notes!
   1.5 Save the new vendor.
   1.6 Search for vendors with: my
   1.7 In the search results, click 'My vendor name'
   1.8 Note that there is an extra space between Notes and the colon in the interfaces section.
2. Apply the patch.
3. Refresh the vendor page:
   ==> There is now no space between Notes and the colon in the interface section
Comment 4 Jonathan Druart 2023-05-23 09:02:16 UTC
Created attachment 151555 [details] [review]
Bug 33797: Remove extra space

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-05-23 19:53:51 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Owen Leonard 2023-05-31 13:09:20 UTC
*** Bug 33851 has been marked as a duplicate of this bug. ***
Comment 7 Matt Blenkinsop 2023-06-08 17:12:08 UTC
Dependencies missing - not backporting to 22.11.x