Bug 33128 - Add Polish translations for language descriptions
Summary: Add Polish translations for language descriptions
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: 22.11
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Janusz Kaczmarek
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-03 15:04 UTC by Janusz Kaczmarek
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33128: Add Polish translations for language descriptions (42.70 KB, patch)
2023-03-03 15:36 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 33128: Add Polish translations for language descriptions (42.70 KB, patch)
2023-03-10 23:38 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 33128: Add Polish translations for language descriptions (42.36 KB, patch)
2023-04-17 21:05 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 33128: Add Polish translations for language descriptions (42.41 KB, patch)
2023-04-19 00:42 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 33128: Add Polish translations for language descriptions (42.46 KB, patch)
2023-04-22 14:54 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2023-03-03 15:04:21 UTC
Koha lacks languages description in Polish.

A patch will follow.
Comment 1 Janusz Kaczmarek 2023-03-03 15:36:13 UTC
Created attachment 147703 [details] [review]
Bug 33128: Add Polish translations for language descriptions

This adds the Polish translations for the different languages to
subtag_registry.sql that is used by all languages during installation.

Test plan:
==========    
* Apply patch
* Run database update
* Install pl-PL and activate it for the OPAC
* Go to advanced search
* Look at the language pull down - it shows the languages in their
  language and then translated to English
* Switch to Polish - verify the Polish translations are used now
  There are 2-3 cases where the translation = name, so only name is shown.
* Drop your database, create your database
* Run the web installer
* Everything should complete without error and the language pull down
  should look exactly the same and be translated

[Test plan courtesy of Bug 31715 for German]
Comment 2 Janusz Kaczmarek 2023-03-10 23:38:25 UTC
Created attachment 148101 [details] [review]
Bug 33128: Add Polish translations for language descriptions

This adds the Polish translations for the different languages to
subtag_registry.sql that is used by all languages during installation.

Test plan:
==========    
* Apply patch
* Run database update
* Install pl-PL and activate it for the OPAC
* Go to advanced search
* Look at the language pull down - it shows the languages in their
  language and then translated to English
* Switch to Polish - verify the Polish translations are used now
  There are 2-3 cases where the translation = name, so only name is shown.
* Drop your database, create your database
* Run the web installer
* Everything should complete without error and the language pull down
  should look exactly the same and be translated

[Test plan courtesy of Bug 31715 for German]
Comment 3 Nick Clemens 2023-04-17 19:42:15 UTC
The update works well, but installing fresh failed.


It looks like a bad copy paste here:
installer/data/mysql/mandatory/subtag_registry.sql

All the lines like:
INSERT INTO language_subtag_registry( subtag, type, description, added)

Should be:
INSERT INTO language_descriptions(subtag, type, lang, description)
Comment 4 Janusz Kaczmarek 2023-04-17 20:54:33 UTC
(In reply to Nick Clemens from comment #3)
> The update works well, but installing fresh failed.
> 
> 
> It looks like a bad copy paste here:
> installer/data/mysql/mandatory/subtag_registry.sql
> 
> All the lines like:
> INSERT INTO language_subtag_registry( subtag, type, description, added)
> 
> Should be:
> INSERT INTO language_descriptions(subtag, type, lang, description)

What a shame--indeed.  Correction follows.
Comment 5 Janusz Kaczmarek 2023-04-17 21:05:54 UTC
Created attachment 149781 [details] [review]
Bug 33128: Add Polish translations for language descriptions

This adds the Polish translations for the different languages to
subtag_registry.sql that is used by all languages during installation.

Test plan:
==========    
* Apply patch
* Run database update
* Install pl-PL and activate it for the OPAC
* Go to advanced search
* Look at the language pull down - it shows the languages in their
  language and then translated to English
* Switch to Polish - verify the Polish translations are used now
  There are 2-3 cases where the translation = name, so only name is shown.
* Drop your database, create your database
* Run the web installer
* Everything should complete without error and the language pull down
  should look exactly the same and be translated

[Test plan courtesy of Bug 31715 for German]
Comment 6 Nick Clemens 2023-04-19 00:42:09 UTC
Created attachment 149833 [details] [review]
Bug 33128: Add Polish translations for language descriptions

This adds the Polish translations for the different languages to
subtag_registry.sql that is used by all languages during installation.

* Apply patch
* Run database update
* Install pl-PL and activate it for the OPAC
* Go to advanced search
* Look at the language pull down - it shows the languages in their
  language and then translated to English
* Switch to Polish - verify the Polish translations are used now
  There are 2-3 cases where the translation = name, so only name is shown.
* Drop your database, create your database
* Run the web installer
* Everything should complete without error and the language pull down
  should look exactly the same and be translated

Signed-off-by: Nick <nick@bywatersolutions.com>
Comment 7 Katrin Fischer 2023-04-22 14:54:46 UTC
Created attachment 150082 [details] [review]
Bug 33128: Add Polish translations for language descriptions

This adds the Polish translations for the different languages to
subtag_registry.sql that is used by all languages during installation.

* Apply patch
* Run database update
* Install pl-PL and activate it for the OPAC
* Go to advanced search
* Look at the language pull down - it shows the languages in their
  language and then translated to English
* Switch to Polish - verify the Polish translations are used now
  There are 2-3 cases where the translation = name, so only name is shown.
* Drop your database, create your database
* Run the web installer
* Everything should complete without error and the language pull down
  should look exactly the same and be translated

Signed-off-by: Nick <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2023-04-22 14:55:07 UTC
Ultimately, we should do better with the way we manage these, but for now, this is all good :)
Comment 9 Tomás Cohen Arazi 2023-04-24 13:49:58 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Martin Renvoize 2023-05-11 10:52:33 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release