Continuing the work of Bug 32571, the authorized values administration page should be updated to use the new WRAPPER for tabs.
Created attachment 147854 [details] [review] Bug 33158: Use template wrapper for authorized values and item types administration tabs This patch updates the authorized values and item types administration templates so that they use the new WRAPPER directive to build tabbed navigation. Seeing that the markup in itemtypes.tt and authorised_values.tt is indential when it comes to icon selection, I have moved that section of the template into an include file and updated both templates to use it. To test, apply the patch and go to Administration -> Item types. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g.https://via.placeholder.com/50/FF0000/FFFFFF.png) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. Perform the same tests in Administration -> Authorized values.
Hello, everything works, except the following in Item types and Authorized values: If you did not previously have any icon selected, the "None" tab should be active. There is no active Tab.
(In reply to Alexandra Speer from comment #2) > If you did not previously have any icon selected, the "None" tab should be > active. There is no active Tab. I believe this has just been fixed by Bug 33278
Everything works correctly in item types, including for adding the remote image. However, when you go back to edit the item type with the remote image, I think there is a bug in the display. Initially it lands correctly with the 'remote image' tab active. However, as well as the radio button for the 'Remote image' and the field for the url there is also a 'None' radio button and label. If I switch between that active 'Remote image' tab and another, then back again, this 'None' radio button disappears. See screenshots. In authorised values, everything works correctly EXCEPT for the remote image option. It allows you to set a remote image, and correctly displays the remote image. However, when you go back to edit the authorised value, it starts on the "None" tab, unselected. When you then click on the 'Remote image' tab, the radio button is unselected and there is no url showing in the field. Saving out of that screen removes the remote image, even without selecting the 'None' radio button on the 'None' tab.
Created attachment 149041 [details] Screenshots to show buggy behaviour on testing for signoff
Created attachment 149042 [details] Screenshot2 to show buggy behaviour on testing for signoff
(In reply to Andrew Auld from comment #4) > Saving out of that screen removes the remote image, even without > selecting the 'None' radio button on the 'None' tab. NB cancelling out of the screen leaves the remote image in place.
Created attachment 149621 [details] [review] Bug 33158: Use template wrapper for authorized values and item types administration tabs This patch updates the authorized values and item types administration templates so that they use the new WRAPPER directive to build tabbed navigation. Seeing that the markup in itemtypes.tt and authorised_values.tt is indential when it comes to icon selection, I have moved that section of the template into an include file and updated both templates to use it. The patch also makes minor SCSS changes, so to test you must rebuild the staff interface CSS. To test, apply the patch and go to Administration -> Item types. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g.https://via.placeholder.com/50/FF0000/FFFFFF.png) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. Perform the same tests in Administration -> Authorized values.
Created attachment 149669 [details] [review] Bug 33158: Use template wrapper for authorized values and item types administration tabs This patch updates the authorized values and item types administration templates so that they use the new WRAPPER directive to build tabbed navigation. Seeing that the markup in itemtypes.tt and authorised_values.tt is indential when it comes to icon selection, I have moved that section of the template into an include file and updated both templates to use it. The patch also makes minor SCSS changes, so to test you must rebuild the staff interface CSS. To test, apply the patch and go to Administration -> Item types. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g.https://via.placeholder.com/50/FF0000/FFFFFF.png) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. Perform the same tests in Administration -> Authorized values. Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Great! Works perfectly now.
Can you please check on the QA test fail? FAIL koha-tmpl/intranet-tmpl/prog/en/includes/admin-icon-selection.inc FAIL valid_template tab_item: not found
Created attachment 150893 [details] [review] Bug 33158: (follow-up) Fix for QA test failure The page seems to work fine without these changes but the QA test script is happier with "USE raw" and html_helpers.inc added.
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to 22.11.x for next release