The Pseudonymization system preference description in the staff interface is: "Disable/Enable pseudonymization to comply with GDPR for personal information. Patrons and transactions will be copied to a separate table for statistics purpose." GDPR is a European Union (and, at time of writing, UK) law; it makes the system preference look irrelevant for libraries outside this area. However, this is not correct: pseudonymization may be useful for libraries anywhere. The system preference description should be changed to reflect this. Instead, it could be something like: "Disable/Enable pseudonymization to help improve security in the way you store personal information. Selected patron and transaction fields will be copied to a separate table for statistics purposes."
Created attachment 148390 [details] [review] Bug 33916: Generalize pseudonymization system preference description The Pseudonymization system preference description in the staff interface is: "Disable/Enable pseudonymization to comply with GDPR for personal information. Patrons and transactions will be copied to a separate table for statistics purpose." GDPR is a European Union (and, at time of writing, UK) law; it makes the system preference look irrelevant for libraries outside this area. However, this is not correct: pseudonymization may be useful for libraries anywhere. This generalized the system preference description and only uses GDPR as an example instead of the only purpose. It also updates the fields listed to more closely reflect the labels on the patron form. To test: * Search for "Pseudonymization" in the systme preferences * Verify that the description of the system preference is very GDPR * Apply patch * Verify the system preference description is improved
Created attachment 148506 [details] [review] Bug 33196: Generalize pseudonymization system preference description The Pseudonymization system preference description in the staff interface is: "Disable/Enable pseudonymization to comply with GDPR for personal information. Patrons and transactions will be copied to a separate table for statistics purpose." GDPR is a European Union (and, at time of writing, UK) law; it makes the system preference look irrelevant for libraries outside this area. However, this is not correct: pseudonymization may be useful for libraries anywhere. This generalized the system preference description and only uses GDPR as an example instead of the only purpose. It also updates the fields listed to more closely reflect the labels on the patron form. To test: * Search for "Pseudonymization" in the systme preferences * Verify that the description of the system preference is very GDPR * Apply patch * Verify the system preference description is improved Signed-off-by: David Nind <david@davidnind.com>
Comment on attachment 148390 [details] [review] Bug 33916: Generalize pseudonymization system preference description I edited the commit to change the bug number in the title from 33916 to 33196. A nice improvement 8-).
Created attachment 150311 [details] [review] Bug 33196: Generalize pseudonymization system preference description The Pseudonymization system preference description in the staff interface is: "Disable/Enable pseudonymization to comply with GDPR for personal information. Patrons and transactions will be copied to a separate table for statistics purpose." GDPR is a European Union (and, at time of writing, UK) law; it makes the system preference look irrelevant for libraries outside this area. However, this is not correct: pseudonymization may be useful for libraries anywhere. This generalized the system preference description and only uses GDPR as an example instead of the only purpose. It also updates the fields listed to more closely reflect the labels on the patron form. To test: * Search for "Pseudonymization" in the systme preferences * Verify that the description of the system preference is very GDPR * Apply patch * Verify the system preference description is improved https://bugs.koha-community.org/show_bug.cgi?id=33196 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
The changes all make perfect sense, the QA script doesn't complain. An easy PQA.
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Backported to 22.05.x for upcoming 22.05.14
Backported to 21.11.x for upcoming 21.11.22.