Bug 33197 - Terminology: rename GDPR_Policy system preference
Summary: Terminology: rename GDPR_Policy system preference
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-10 16:00 UTC by Aude Charillon
Modified: 2023-07-04 16:34 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/687
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33197: Rename GDPR_Policy system preference (14.00 KB, patch)
2023-03-17 22:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33197: Rename GDPR_Policy system preference (15.03 KB, patch)
2023-03-17 22:48 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33197: Rename GDPR_Policy system preference (15.08 KB, patch)
2023-03-21 23:34 UTC, David Nind
Details | Diff | Splinter Review
Bug 33197: Rename GDPR_Policy system preference (15.17 KB, patch)
2023-04-27 05:02 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aude Charillon 2023-03-10 16:00:33 UTC
GDPR is a European Union (and, at time of writing, UK) law. The GDPR_Policy system preference is about a patron giving consent to their personal data being processed in line with the library's privacy policy.

The name of the preference is vague: there could be many policies implemented by libraries to comply with GDPR. It also makes the preference look irrelevant for libraries outside the areas where GDPR applies, while it may be useful for libraries anywhere.

The preference could be renamed something like "PrivacyPolicyConsent". The description text in the staff interface would need to be updated, as well as the description of the PrivacyPolicyURL preference.
Comment 1 Katrin Fischer 2023-03-17 22:30:08 UTC
Created attachment 148389 [details] [review]
Bug 33197: Rename GDPR_Policy system preference

GDPR is a European Union (and, at time of writing, UK) law.
The GDPR_Policy system preference is about a patron
giving consent to their personal data being processed in
line with the library's privacy policy.

The name of the preference is vague: there could be
many policies implemented by libraries to comply with
GDPR. It also makes the preference look irrelevant for
libraries outside the areas where GDPR applies, while
it may be useful for libraries anywhere.

This renames GDPR_Policy to PrivacyPolicyConsent and
adjusts the system preference descriptions.

To test:
* Apply the patch
* Run database update
* Search for GDPR_Policy in the system preference
  - you should not find anything.
* Search for DataPrivacyConsent in the system preferences
  - you should find it and be able to activate it
* Verify the feature works as expected
  - If the preference is set to "enforced", you will be
    asked to give consent to the data privacy agreement
    in the OPAC when you log in
* Verify the page is now phrased neutrally using 'privacy policy'

Bonus: Consent date is now formatted according to DateFormat
       system preference.
Comment 2 Katrin Fischer 2023-03-17 22:30:46 UTC
This bug might be a bit controversial. If you are using this feature with GDPR the more neutral phrasing might be not wanted. Ideas welcome.
Comment 3 Katrin Fischer 2023-03-17 22:48:47 UTC
Created attachment 148391 [details] [review]
Bug 33197: Rename GDPR_Policy system preference

GDPR is a European Union (and, at time of writing, UK) law.
The GDPR_Policy system preference is about a patron
giving consent to their personal data being processed in
line with the library's privacy policy.

The name of the preference is vague: there could be
many policies implemented by libraries to comply with
GDPR. It also makes the preference look irrelevant for
libraries outside the areas where GDPR applies, while
it may be useful for libraries anywhere.

This renames GDPR_Policy to PrivacyPolicyConsent and
adjusts the system preference descriptions.

To test:
* Apply the patch
* Run database update
* Search for GDPR_Policy in the system preference
  - you should not find anything.
* Search for DataPrivacyConsent in the system preferences
  - you should find it and be able to activate it
* Verify the feature works as expected
  - If the preference is set to "enforced", you will be
    asked to give consent to the data privacy agreement
    in the OPAC when you log in
* Verify the page is now phrased neutrally using 'privacy policy'

Bonus: Consent date is now formatted according to DateFormat
       system preference.
Comment 4 David Nind 2023-03-21 23:34:36 UTC
Created attachment 148499 [details] [review]
Bug 33197: Rename GDPR_Policy system preference

GDPR is a European Union (and, at time of writing, UK) law.
The GDPR_Policy system preference is about a patron
giving consent to their personal data being processed in
line with the library's privacy policy.

The name of the preference is vague: there could be
many policies implemented by libraries to comply with
GDPR. It also makes the preference look irrelevant for
libraries outside the areas where GDPR applies, while
it may be useful for libraries anywhere.

This renames GDPR_Policy to PrivacyPolicyConsent and
adjusts the system preference descriptions.

To test:
* Apply the patch
* Run database update
* Search for GDPR_Policy in the system preference
  - you should not find anything.
* Search for DataPrivacyConsent in the system preferences
  - you should find it and be able to activate it
* Verify the feature works as expected
  - If the preference is set to "enforced", you will be
    asked to give consent to the data privacy agreement
    in the OPAC when you log in
* Verify the page is now phrased neutrally using 'privacy policy'

Bonus: Consent date is now formatted according to DateFormat
       system preference.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-03-21 23:39:15 UTC
(In reply to Katrin Fischer from comment #2)
> This bug might be a bit controversial. If you are using this feature with
> GDPR the more neutral phrasing might be not wanted. Ideas welcome.

I don't have any particular views, but making it more generic so that it works for other countries outside the EU that require consent to the data collected and a privacy policy, makes sense to me.

Testing notes:

1. For step 4 of the test plan, DataPrivacyConsent should be PrivacyPolicyConsent I think.

2. Nice bonus with the date format!
Comment 6 Jonathan Druart 2023-03-22 16:04:52 UTC
Then people won't find the syspref when searching for "GDPR". Shouldn't we add a ref in the description at least?
Comment 7 Marcel de Rooy 2023-03-22 16:13:06 UTC
Hmm. Interesting. I added it once and know that there are more references to GDPR; you see some of them already scrolling thru this patch. We will now have a general name that still uses gdpr artifacts under the surface.
No blocker, but also a bit hesistant to change.
Comment 8 Jonathan Druart 2023-04-25 18:54:53 UTC
ping regarding the last 2 comments?
Comment 9 Aude Charillon 2023-04-26 09:10:31 UTC
I don't understand what's happening under the surface, so can only comment on what goes on above :-D I disagree with the idea that the sys pref not mentioning GDPR will hamper librarians. There are several other system preferences that are useful for data protection compliance, and they don't mention GDPR. I would expect librarians wanting to enhance their data protection practices to look for anything related to patrons, privacy and security; if they only look for GDPR surely they're already missing tons of things!?
Comment 10 Jonathan Druart 2023-04-27 05:02:24 UTC
Created attachment 150264 [details] [review]
Bug 33197: Rename GDPR_Policy system preference

GDPR is a European Union (and, at time of writing, UK) law.
The GDPR_Policy system preference is about a patron
giving consent to their personal data being processed in
line with the library's privacy policy.

The name of the preference is vague: there could be
many policies implemented by libraries to comply with
GDPR. It also makes the preference look irrelevant for
libraries outside the areas where GDPR applies, while
it may be useful for libraries anywhere.

This renames GDPR_Policy to PrivacyPolicyConsent and
adjusts the system preference descriptions.

To test:
* Apply the patch
* Run database update
* Search for GDPR_Policy in the system preference
  - you should not find anything.
* Search for DataPrivacyConsent in the system preferences
  - you should find it and be able to activate it
* Verify the feature works as expected
  - If the preference is set to "enforced", you will be
    asked to give consent to the data privacy agreement
    in the OPAC when you log in
* Verify the page is now phrased neutrally using 'privacy policy'

Bonus: Consent date is now formatted according to DateFormat
       system preference.
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Tomás Cohen Arazi 2023-05-05 13:15:21 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 12 Martin Renvoize 2023-05-12 15:12:41 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 13 Lucas Gass 2023-06-13 16:00:42 UTC
Doesn't apply cleanly in 22.05.x, no backport.