<failure message="Timed out retrying after 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying a fter 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it.
Not sure where it's coming from, but on top of bug 33408 it is failing consistently.
Created attachment 149187 [details] [review] Bug 33416: Fix Agreements.ts <failure message="Timed out retrying after 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying a fter 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it.
Created attachment 149199 [details] [review] Bug 33416: Fix Agreements.ts <failure message="Timed out retrying after 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying a fter 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Do we have instructions on how to run the Cypress tests somewhere? ... or in other words, can you please add a test plan? :)
In ktd root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Or you can run only Agreements.ts with: kohadev-koha@kohadevbox:koha$ yarn cypress run --spec /kohadevbox/koha/t/cypress/integration/Agreements_spec.ts
This is temporarily BLOCKED by the dependent patch waiting for sign-off.
I think I might still be missing some step? yarn cypress run --spec /kohadevbox/koha/t/cypress/integration/Agreements_spec.ts yarn run v1.22.19 $ cypress run --spec /kohadevbox/koha/t/cypress/integration/Agreements_spec.ts [4571:0412/200617.573954:ERROR:sandbox_linux.cc(377)] InitializeSandbox() called with multiple threads in process gpu-process. [4571:0412/200617.575611:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported. Can't run because no spec files were found. We searched for specs matching this glob pattern: > /kohadevbox/koha/t/cypress/integration/Agreements_spec.ts error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Yesterday the tests have been moved to t/cypress/integration/ERM
(In reply to Jonathan Druart from comment #8) > Yesterday the tests have been moved to t/cypress/integration/ERM Sabotage...
... I tried again, but I think I can't reproduce the problem without the patch: Spec Tests Passing Failing Pending Skipped ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✔ ERM/Agreements_spec.ts 00:36 5 5 - - - │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ✔ All specs passed! 00:36 5 5 - - -
It's failing consistently for me on master right now and jenkins agrees with that, please try again.
And this patch does not fix the failures... There are more.
Ok, bug 33483 is fixing most of the other failures. The remaining one (see comment 0) is fixed by this patch.
Created attachment 149870 [details] [review] Bug 33416: Fix Agreements.ts <failure message="Timed out retrying after 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying a fter 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 149871 [details] [review] Bug 33416: Fix Searchbar_spec.ts Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
PLEASE IGNORE THE ABOVE, NOT PUSHED TO STABLE
Missing dependencies for 22.05.x, no backport.