Bug 33480 - Improve display of the vendor aliases in the ERM module
Summary: Improve display of the vendor aliases in the ERM module
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on: 33103
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-11 07:57 UTC by Jonathan Druart
Modified: 2023-10-14 12:30 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33480: Improve vendor aliases display in dropdown list (11.72 KB, patch)
2023-04-11 09:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33480: Remove vendors when not needed (4.73 KB, patch)
2023-04-11 09:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33480: Display aliases on different lines (1.06 KB, patch)
2023-04-11 09:36 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33480: Improve vendor aliases display in dropdown list (11.69 KB, patch)
2023-08-30 08:14 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33480: Remove vendors when not needed (4.73 KB, patch)
2023-08-30 08:14 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33480: Improve vendor aliases display in dropdown list (11.73 KB, patch)
2023-08-30 09:47 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33480: Remove vendors when not needed (4.78 KB, patch)
2023-08-30 09:47 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33480: (QA follow-up) Add cypress tests: (7.14 KB, patch)
2023-09-06 15:45 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-04-11 07:57:42 UTC
Coming from bug 33103 comment 34

"""
I am not persuaded by the display tbh, I believe it will get messy very soon as often those aliases will be quite long and we might even want to record a slight name change. 

Could it be an option to show the aliases in the list as "second level" entries, kind of a hiearchical display, like we have it for funds? 
"""
Comment 1 Jonathan Druart 2023-04-11 09:10:07 UTC
Created attachment 149415 [details] [review]
Bug 33480: Improve vendor aliases display in dropdown list

On bug 33103 we are adding the ability to filter vendors by aliases.
To make it possible in the ERM module we are adding the alias list in
the dropdown list. However it's not nicely displayed, especially if
there are several entries.

This patch suggests to display the aliases in a different line, and not
for the selected option.

To acchieve that we create a new Vue component FormSelectVendors.

Test plan:
Create several vendors, and add some aliases to them (keep one vendor
without alias)
Go to the ERM module go to the following page, search for vendors by
aliases, save the form, and confirm that everything is nice and works
correctly:
* Add/edit an agreement
* Add/edit a license
* Add/edit a local package
* Add a new package to a title (edit a title)
Comment 2 Jonathan Druart 2023-04-11 09:10:09 UTC
Created attachment 149416 [details] [review]
Bug 33480: Remove vendors when not needed

Several components retrieve the vendor list from store but it's not
needed in those components.
Comment 3 Jonathan Druart 2023-04-11 09:36:46 UTC
Created attachment 149418 [details] [review]
Bug 33480: Display aliases on different lines
Comment 4 Jonathan Druart 2023-04-11 09:37:24 UTC
This last patch is supposed to add an indentation for the aliases but it does not work...
Comment 5 Jonathan Druart 2023-08-30 08:14:46 UTC
Created attachment 154936 [details] [review]
Bug 33480: Improve vendor aliases display in dropdown list

On bug 33103 we are adding the ability to filter vendors by aliases.
To make it possible in the ERM module we are adding the alias list in
the dropdown list. However it's not nicely displayed, especially if
there are several entries.

This patch suggests to display the aliases in a different line, and not
for the selected option.

To acchieve that we create a new Vue component FormSelectVendors.

Test plan:
Create several vendors, and add some aliases to them (keep one vendor
without alias)
Go to the ERM module go to the following page, search for vendors by
aliases, save the form, and confirm that everything is nice and works
correctly:
* Add/edit an agreement
* Add/edit a license
* Add/edit a local package
* Add a new package to a title (edit a title)
Comment 6 Jonathan Druart 2023-08-30 08:14:49 UTC
Created attachment 154937 [details] [review]
Bug 33480: Remove vendors when not needed

Several components retrieve the vendor list from store but it's not
needed in those components.
Comment 7 Jonathan Druart 2023-08-30 08:21:23 UTC
Before those patch: https://snipboard.io/vMatno.jpg
After: https://snipboard.io/hoBVG0.jpg

With the third patch (obsoleted now), "Display aliases on different lines", I was trying to have one alias by line, and add some indent (left margin).

I think the display is improved anyway and we can go with it as it.
Comment 8 Pedro Amorim 2023-08-30 09:47:53 UTC
Created attachment 154942 [details] [review]
Bug 33480: Improve vendor aliases display in dropdown list

On bug 33103 we are adding the ability to filter vendors by aliases.
To make it possible in the ERM module we are adding the alias list in
the dropdown list. However it's not nicely displayed, especially if
there are several entries.

This patch suggests to display the aliases in a different line, and not
for the selected option.

To acchieve that we create a new Vue component FormSelectVendors.

Test plan:
Create several vendors, and add some aliases to them (keep one vendor
without alias)
Go to the ERM module go to the following page, search for vendors by
aliases, save the form, and confirm that everything is nice and works
correctly:
* Add/edit an agreement
* Add/edit a license
* Add/edit a local package
* Add a new package to a title (edit a title)

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 9 Pedro Amorim 2023-08-30 09:47:55 UTC
Created attachment 154943 [details] [review]
Bug 33480: Remove vendors when not needed

Several components retrieve the vendor list from store but it's not
needed in those components.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 10 Pedro Amorim 2023-08-30 09:48:32 UTC
Should we also consider displaying the vendor aliases on the show and list pages or not needed?
Comment 11 Jonathan Druart 2023-08-31 07:09:25 UTC
(In reply to Pedro Amorim from comment #10)
> Should we also consider displaying the vendor aliases on the show and list
> pages or not needed?

In my understanding the aliases are there to easy searching vendors, not sure it makes sense to have them on the show/list views.

Jonathan (Field), what do you think?
Comment 12 Jonathan Field 2023-09-06 13:05:25 UTC
I agree, not needed
Comment 13 Pedro Amorim 2023-09-06 14:10:00 UTC
QA happy
Comment 14 Pedro Amorim 2023-09-06 15:45:15 UTC
Created attachment 155277 [details] [review]
Bug 33480: (QA follow-up) Add cypress tests:

Add tests for vendor aliases
Test plan:
perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only
Comment 15 Tomás Cohen Arazi 2023-09-06 18:10:52 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 16 Fridolin Somers 2023-09-08 19:31:01 UTC
Enhancement not pushed to 23.05.x