Bug 34217 - Add missing cypress tests for vendors in agreements and licenses
Summary: Add missing cypress tests for vendors in agreements and licenses
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Pedro Amorim
QA Contact:
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-07-06 10:13 UTC by Pedro Amorim
Modified: 2024-07-04 20:37 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:

Attachments
Bug 34217: Add vendor tests for agreements (3.71 KB, patch)
2023-07-06 10:15 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Bug 34217: Add vendor tests for agreements (3.72 KB, patch)
2023-07-10 12:49 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Bug 34217: (QA follow-up) Clean-up old unused code (1.10 KB, patch)
2023-07-20 13:50 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Bug 34217: Add vendor tests for licenses (2.82 KB, patch)
2023-08-25 10:20 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Bug 34217: Add vendor tests for agreements (3.80 KB, patch)
2023-08-31 07:18 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 34217: (QA follow-up) Clean-up old unused code (1.18 KB, patch)
2023-08-31 07:18 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 34217: Add vendor tests for licenses (2.90 KB, patch)
2023-08-31 07:18 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 34217: Add vendor tests for agreements (3.72 KB, patch)
2023-09-06 09:10 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 34217: (QA follow-up) Clean-up old unused code (1.18 KB, patch)
2023-09-06 09:10 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 34217: Add vendor tests for licenses (2.90 KB, patch)
2023-09-06 09:10 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 34217: Add vendor tests for agreements and licenses (7.06 KB, patch)
2023-09-06 09:12 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-07-06 10:13:51 UTC 
Bug 34206 made it evident we are missing tests for vendors in agreements and licenses.
Comment 1 Pedro Amorim 2023-07-06 10:15:05 UTC 
Created attachment 153088 [details] [review]
Bug 34217: Add vendor tests for agreements
Comment 2 Pedro Amorim 2023-07-06 10:15:23 UTC 
Missing the same for licenses.
Comment 3 Pedro Amorim 2023-07-10 12:49:58 UTC 
Created attachment 153266 [details] [review]
Bug 34217: Add vendor tests for agreements
Comment 4 Pedro Amorim 2023-07-20 13:50:23 UTC 
Created attachment 153722 [details] [review]
Bug 34217: (QA follow-up) Clean-up old unused code

Spotted this and didn't want to open a new bug for it
Comment 5 Pedro Amorim 2023-08-25 10:20:44 UTC 
Created attachment 154794 [details] [review]
Bug 34217: Add vendor tests for licenses
Comment 6 Pedro Amorim 2023-08-25 10:24:27 UTC 
Test plan, k-t-d, run:
cypress run
Comment 7 Jonathan Druart 2023-08-31 07:18:03 UTC 
Created attachment 154996 [details] [review]
Bug 34217: Add vendor tests for agreements

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2023-08-31 07:18:06 UTC 
Created attachment 154997 [details] [review]
Bug 34217: (QA follow-up) Clean-up old unused code

Spotted this and didn't want to open a new bug for it

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2023-08-31 07:18:09 UTC 
Created attachment 154998 [details] [review]
Bug 34217: Add vendor tests for licenses

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Tomás Cohen Arazi (tcohen) 2023-09-05 17:30:13 UTC 
Please rebase.
Comment 11 Jonathan Druart 2023-09-06 09:10:07 UTC 
Created attachment 155257 [details] [review]
Bug 34217: Add vendor tests for agreements

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Jonathan Druart 2023-09-06 09:10:11 UTC 
Created attachment 155258 [details] [review]
Bug 34217: (QA follow-up) Clean-up old unused code

Spotted this and didn't want to open a new bug for it

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Jonathan Druart 2023-09-06 09:10:14 UTC 
Created attachment 155259 [details] [review]
Bug 34217: Add vendor tests for licenses

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 14 Pedro Amorim 2023-09-06 09:12:07 UTC Comment hidden (obsolete)
Comment 15 Pedro Amorim 2023-09-06 09:14:35 UTC 
Little mid-air collision there, all sorted!
Comment 16 Tomás Cohen Arazi (tcohen) 2023-09-06 12:58:05 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 17 Fridolin Somers 2023-09-08 19:18:51 UTC 
Enhancement not pushed to 23.05.x