To continue the process started by Bug 32507, this patch will update several more serials templates so that they use the new template wrapper for breadcrumbs. - serials/serials-edit.tt - serials/serials-home.tt - serials/serials-search.tt - serials/subscription-add.tt - serials/subscription-batchedit.tt
Created attachment 149905 [details] [review] Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page
Created attachment 149909 [details] [review] Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page
Created attachment 150167 [details] [review] Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Lovely, thanks Owen!
Created attachment 150424 [details] [review] Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Serial collection -> edit serials On this page the breadcrumb for current subscription leads 'subscription not found' - this is true before these patches as well
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release