Bug 33559 - Use template wrapper for breadcrumbs: Serials part 2
Summary: Use template wrapper for breadcrumbs: Serials part 2
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32507 33560
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-18 15:42 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 (8.91 KB, patch)
2023-04-19 17:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 (9.08 KB, patch)
2023-04-19 17:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 (9.14 KB, patch)
2023-04-24 17:23 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 (9.19 KB, patch)
2023-04-29 19:56 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-18 15:42:02 UTC
To continue the process started by Bug 32507, this patch will update several more serials templates so that they use the new template wrapper for breadcrumbs.

- serials/serials-edit.tt
- serials/serials-home.tt
- serials/serials-search.tt
- serials/subscription-add.tt
- serials/subscription-batchedit.tt
Comment 1 Owen Leonard 2023-04-19 17:33:37 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-04-19 17:44:50 UTC
Created attachment 149909 [details] [review]
Bug 33559: Use template wrapper for breadcrumbs: Serials part 2

This patch updates several serials templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Serials ->
  - Serials home page
    - New subscription
    - Serials search results
      - Subscription details -> Edit subscription
      - Subscription details -> Serial collection -> Edit serials
      - Select one or more seach results and click the "Edit selected
        serials" to test the batch edit page
Comment 3 PTFS Europe Sandboxes 2023-04-24 17:23:09 UTC
Created attachment 150167 [details] [review]
Bug 33559: Use template wrapper for breadcrumbs: Serials part 2

This patch updates several serials templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Serials ->
  - Serials home page
    - New subscription
    - Serials search results
      - Subscription details -> Edit subscription
      - Subscription details -> Serial collection -> Edit serials
      - Select one or more seach results and click the "Edit selected
        serials" to test the batch edit page

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 4 Andrew Auld 2023-04-24 17:23:46 UTC
Lovely, thanks Owen!
Comment 5 Nick Clemens 2023-04-29 19:56:44 UTC
Created attachment 150424 [details] [review]
Bug 33559: Use template wrapper for breadcrumbs: Serials part 2

This patch updates several serials templates so that they use the new
WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Serials ->
  - Serials home page
    - New subscription
    - Serials search results
      - Subscription details -> Edit subscription
      - Subscription details -> Serial collection -> Edit serials
      - Select one or more seach results and click the "Edit selected
        serials" to test the batch edit page

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Nick Clemens 2023-04-29 19:57:44 UTC
Serial collection -> edit serials

On this page the breadcrumb for current subscription leads  'subscription not found' - this is true before these patches as well
Comment 7 Tomás Cohen Arazi 2023-05-05 12:17:51 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Martin Renvoize 2023-05-11 11:23:55 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release