When you use the mouse to check checkboxes on the serial search results page, it activates an "Edit selected serials" link which when clicked takes you to the batch edit page. If you use the "Select all" link to check the checkboxes the "Edit selected serials" link is activated but it doesn't work.
Created attachment 149895 [details] [review] Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab.
Created attachment 150112 [details] [review] Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 150117 [details] [review] Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Not needed in 22.05.x, no backport.