Bug 33560 - Batch edit link broken if subscriptions are selected using "select all" link
Summary: Batch edit link broken if subscriptions are selected using "select all" link
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32698
Blocks: 33559
  Show dependency treegraph
 
Reported: 2023-04-18 16:50 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link (6.90 KB, patch)
2023-04-19 16:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link (6.95 KB, patch)
2023-04-23 06:05 UTC, David Nind
Details | Diff | Splinter Review
Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link (7.00 KB, patch)
2023-04-23 09:48 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-18 16:50:29 UTC
When you use the mouse to check checkboxes on the serial search results page, it activates an "Edit selected serials" link which when clicked takes you to the batch edit page.

If you use the "Select all" link to check the checkboxes the "Edit selected serials" link is activated but it doesn't work.
Comment 1 Owen Leonard 2023-04-19 16:34:26 UTC
Created attachment 149895 [details] [review]
Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link

This patch revises the process by which the serials search results page
redirects to the batch edit page based on which checkboxes are checked.

To test, apply the patch and go to serials. You should have some
subscriptions which are open and some which are closed.

- Perform a search which will return at least one result under each tab
  (Open and Closed).
  - Checking one or more checkboxes should activate the "Edit selected
    serials" link, which should work correctly to redirect you to the
    batch edit page.
  - Unchecking all the checkboxes should make the edit link disappear.
  - Check that the "Select all" and "Clear all" links work the same way
    manually checking checkboxes does.
  - Confirm that controls under each tab work correctly just for the
    results under that tab.
Comment 2 David Nind 2023-04-23 06:05:05 UTC
Created attachment 150112 [details] [review]
Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link

This patch revises the process by which the serials search results page
redirects to the batch edit page based on which checkboxes are checked.

To test, apply the patch and go to serials. You should have some
subscriptions which are open and some which are closed.

- Perform a search which will return at least one result under each tab
  (Open and Closed).
  - Checking one or more checkboxes should activate the "Edit selected
    serials" link, which should work correctly to redirect you to the
    batch edit page.
  - Unchecking all the checkboxes should make the edit link disappear.
  - Check that the "Select all" and "Clear all" links work the same way
    manually checking checkboxes does.
  - Confirm that controls under each tab work correctly just for the
    results under that tab.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-04-23 09:48:27 UTC
Created attachment 150117 [details] [review]
Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link

This patch revises the process by which the serials search results page
redirects to the batch edit page based on which checkboxes are checked.

To test, apply the patch and go to serials. You should have some
subscriptions which are open and some which are closed.

- Perform a search which will return at least one result under each tab
  (Open and Closed).
  - Checking one or more checkboxes should activate the "Edit selected
    serials" link, which should work correctly to redirect you to the
    batch edit page.
  - Unchecking all the checkboxes should make the edit link disappear.
  - Check that the "Select all" and "Clear all" links work the same way
    manually checking checkboxes does.
  - Confirm that controls under each tab work correctly just for the
    results under that tab.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-04-24 13:50:09 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-05-11 10:52:37 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 6 Lucas Gass 2023-05-15 21:47:45 UTC
Not needed in 22.05.x, no backport.