Bug 33634 - Sidebar navigation links in system preferences not taking user to the clicked section
Summary: Sidebar navigation links in system preferences not taking user to the clicked...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Aleisha Amohia
URL:
Keywords: rel_22_11_candidate
: 33687 (view as bug list)
Depends on: 32926
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-27 23:11 UTC by Aleisha Amohia
Modified: 2023-12-28 20:44 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.13


Attachments
Bug 33634: Correct anchors in system preference submenu (1.49 KB, patch)
2023-04-28 15:55 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33634: Correct anchors in system preference submenu (1.55 KB, patch)
2023-04-28 18:16 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33634: Correct anchors in system preference submenu (1.61 KB, patch)
2023-04-30 21:24 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2023-04-27 23:11:31 UTC
This is a bug that was reported in 22.11.04 but also exists in main.

To reproduce:

1. Go to Koha Administration -> Global system preferences
2. Go to a tab with a few headings like Circulation
3. Click on a heading in the sidebar navigation under Circulation that takes you a bit down the page, like Recalls
4. Notice this anchor link does not work, you are not taken to the recalls preferences
Comment 1 Lucas Gass 2023-04-28 15:55:30 UTC
Created attachment 150393 [details] [review]
Bug 33634: Correct anchors in system preference submenu

To test:
1. Go to Koha Administration -> Global system preferences
2. Go to a tab with a few headings like Circulation
3. Click on a heading in the sidebar navigation under Circulation that takes you a bit down the page, like Recalls
4. Notice this anchor link does not work, you are not taken to the recalls preferences
5. Apply patch
6. Try again, the links should take you to the proper place.
Comment 2 PTFS Europe Sandboxes 2023-04-28 18:16:38 UTC
Created attachment 150408 [details] [review]
Bug 33634: Correct anchors in system preference submenu

To test:
1. Go to Koha Administration -> Global system preferences
2. Go to a tab with a few headings like Circulation
3. Click on a heading in the sidebar navigation under Circulation that takes you a bit down the page, like Recalls
4. Notice this anchor link does not work, you are not taken to the recalls preferences
5. Apply patch
6. Try again, the links should take you to the proper place.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Aleisha Amohia 2023-04-30 21:24:00 UTC
Created attachment 150432 [details] [review]
Bug 33634: Correct anchors in system preference submenu

To test:
1. Go to Koha Administration -> Global system preferences
2. Go to a tab with a few headings like Circulation
3. Click on a heading in the sidebar navigation under Circulation that takes you a bit down the page, like Recalls
4. Notice this anchor link does not work, you are not taken to the recalls preferences
5. Apply patch
6. Try again, the links should take you to the proper place.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 4 Tomás Cohen Arazi 2023-05-05 12:18:35 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Pedro Amorim 2023-05-09 08:50:08 UTC
*** Bug 33687 has been marked as a duplicate of this bug. ***
Comment 6 Martin Renvoize 2023-05-11 11:24:13 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 7 Lucas Gass 2023-05-15 22:23:40 UTC
Backported to 22.05.x for upcoming 22.05.13