Bug 33687 - Clicking on a system preference sub-menu item does not scroll to that item
Summary: Clicking on a system preference sub-menu item does not scroll to that item
Status: RESOLVED DUPLICATE of bug 33634
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Pedro Amorim
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32926
Blocks:
  Show dependency treegraph
 
Reported: 2023-05-05 12:15 UTC by Pedro Amorim
Modified: 2023-05-09 08:50 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 33687: Restore scroll to sub-tab (1.27 KB, patch)
2023-05-05 12:16 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 33687: Restore scroll to sub-tab (1.34 KB, patch)
2023-05-05 12:55 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-05-05 12:15:32 UTC

    
Comment 1 Pedro Amorim 2023-05-05 12:16:09 UTC
Created attachment 150740 [details] [review]
Bug 33687: Restore scroll to sub-tab

Test plan:
Go to sys prefs, click 'Enhanced Content'
Click 'OverDrive', notice it doesnt scroll there

Apply this patch:
Do the same test plan, but notice it does scroll there, like before
Comment 2 Martin Renvoize 2023-05-05 12:55:37 UTC
Created attachment 150748 [details] [review]
Bug 33687: Restore scroll to sub-tab

Test plan:
Go to sys prefs, click 'Enhanced Content'
Click 'OverDrive', notice it doesnt scroll there

Apply this patch:
Do the same test plan, but notice it does scroll there, like before

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2023-05-05 12:56:20 UTC
Working as expected, fixes the regression from bug 32926 without causing further issues.

Signing off
Comment 4 Katrin Fischer 2023-05-08 22:05:19 UTC
Is it possible this was already fixed elsewhere or is browser dependent?

I just tried without the patches applied and it works for me (Enhanced content - Overdrive)
Comment 5 Katrin Fischer 2023-05-08 22:07:40 UTC
Also: patch currently doesn't apply:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 33687: Restore scroll to sub-tab
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc
error: Failed to merge in the changes.
Patch failed at 0001 Bug 33687: Restore scroll to sub-tab
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-33687-Restore-scroll-to-sub-tab-a82QmL.patch
Comment 6 Andreas Roussos 2023-05-09 07:23:15 UTC
(In reply to Katrin Fischer from comment #4)
> Is it possible this was already fixed elsewhere or is browser dependent?
Please see earlier Bug 33634, looks like it was fixed there.
However, as per the patch Pedro has provided here, the TT filter
for the TAB.tab_id variable needs to be 'htmlId' instead of 'html'.

(In reply to Katrin Fischer from comment #5)
> Also: patch currently doesn't apply:
Looks like the same line (line 200) in the template file was
modified by commit 0d1278aa14b from Bug 33634. That would
explain why this patch currently doesn't apply.
Comment 7 Pedro Amorim 2023-05-09 08:50:08 UTC
Thanks everyone, yes this certainly is a duplicate of bug 33634

*** This bug has been marked as a duplicate of bug 33634 ***