Bug 33875 - Missing closing tag a in API key management page
Summary: Missing closing tag a in API key management page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 20568
Blocks: 33883
  Show dependency treegraph
 
Reported: 2023-05-31 20:48 UTC by Fridolin Somers
Modified: 2023-12-28 20:46 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.01,22.11.07


Attachments
Bug 33875: Fix missing closing tag a in API key management page (2.04 KB, patch)
2023-05-31 21:04 UTC, Fridolin Somers
Details | Diff | Splinter Review
Screenshot with patch (25.83 KB, image/png)
2023-05-31 21:05 UTC, Fridolin Somers
Details
Bug 33875: Fix missing closing tag a in API key management page (2.08 KB, patch)
2023-06-01 16:58 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 33875: Fix missing closing tag a in API key management page (2.13 KB, patch)
2023-06-02 01:25 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-05-31 20:48:17 UTC
In API key management page, anchor closing tag is missing in :

<div class="dialog message">No keys defined for the current patron. <a href="#" class="toggle_element" data-element="#add-api-key" id="show-api-form"><i class="fa fa-plus"></i> Generate a new client id/secret pair</div>
Comment 1 Fridolin Somers 2023-05-31 21:04:04 UTC
Created attachment 151888 [details] [review]
Bug 33875: Fix missing closing tag a in API key management page

In API key management page, anchor closing tag is missing in message "No keys defined for the current patron".

This patch fixes that.
Also changes display with link on a new line.
Translatable text is on purpose surrounded by span or div.

Test plan :
1) Enable system preference  RESTOAuth2ClientCredentials
2) Go to a patron page
3) Click More > Manage API Keys
4) Look at page source HTML code
=> Check code is OK
Comment 2 Fridolin Somers 2023-05-31 21:05:57 UTC
Created attachment 151889 [details]
Screenshot with patch

I choose to propose a minor change in display to move link on a new line.
This looks better I think.
Also each translatable text is surrounded by span or div to ease translation.
Comment 3 Sam Lau 2023-06-01 16:58:14 UTC
Created attachment 151950 [details] [review]
Bug 33875: Fix missing closing tag a in API key management page

In API key management page, anchor closing tag is missing in message "No keys defined for the current patron".

This patch fixes that.
Also changes display with link on a new line.
Translatable text is on purpose surrounded by span or div.

Test plan :
1) Enable system preference  RESTOAuth2ClientCredentials
2) Go to a patron page
3) Click More > Manage API Keys
4) Look at page source HTML code
=> Check code is OK

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 4 David Cook 2023-06-02 01:25:08 UTC
Created attachment 151956 [details] [review]
Bug 33875: Fix missing closing tag a in API key management page

In API key management page, anchor closing tag is missing in message "No keys defined for the current patron".

This patch fixes that.
Also changes display with link on a new line.
Translatable text is on purpose surrounded by span or div.

Test plan :
1) Enable system preference  RESTOAuth2ClientCredentials
2) Go to a patron page
3) Click More > Manage API Keys
4) Look at page source HTML code
=> Check code is OK

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 5 Tomás Cohen Arazi 2023-06-05 17:37:27 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-06-12 10:15:22 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x