In API key management page, anchor closing tag is missing in : <div class="dialog message">No keys defined for the current patron. <a href="#" class="toggle_element" data-element="#add-api-key" id="show-api-form"><i class="fa fa-plus"></i> Generate a new client id/secret pair</div>
Created attachment 151888 [details] [review] Bug 33875: Fix missing closing tag a in API key management page In API key management page, anchor closing tag is missing in message "No keys defined for the current patron". This patch fixes that. Also changes display with link on a new line. Translatable text is on purpose surrounded by span or div. Test plan : 1) Enable system preference RESTOAuth2ClientCredentials 2) Go to a patron page 3) Click More > Manage API Keys 4) Look at page source HTML code => Check code is OK
Created attachment 151889 [details] Screenshot with patch I choose to propose a minor change in display to move link on a new line. This looks better I think. Also each translatable text is surrounded by span or div to ease translation.
Created attachment 151950 [details] [review] Bug 33875: Fix missing closing tag a in API key management page In API key management page, anchor closing tag is missing in message "No keys defined for the current patron". This patch fixes that. Also changes display with link on a new line. Translatable text is on purpose surrounded by span or div. Test plan : 1) Enable system preference RESTOAuth2ClientCredentials 2) Go to a patron page 3) Click More > Manage API Keys 4) Look at page source HTML code => Check code is OK Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 151956 [details] [review] Bug 33875: Fix missing closing tag a in API key management page In API key management page, anchor closing tag is missing in message "No keys defined for the current patron". This patch fixes that. Also changes display with link on a new line. Translatable text is on purpose surrounded by span or div. Test plan : 1) Enable system preference RESTOAuth2ClientCredentials 2) Go to a patron page 3) Click More > Manage API Keys 4) Look at page source HTML code => Check code is OK Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: David Cook <dcook@prosentient.com.au>
Pushed to master for 23.11. Nice work everyone, thanks!
Nice work everyone! Pushed to oldstable for 22.11.x